![]() There is a call to local_irq_restore in the normal exit case, so it would seem that there should be one on an error return as well. The semantic patch that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // <smpl> @@ expression l; expression E,E1,E2; @@ local_irq_save(l); ... when != local_irq_restore(l) when != spin_unlock_irqrestore(E,l) when any when strict ( if (...) { ... when != local_irq_restore(l) when != spin_unlock_irqrestore(E1,l) + local_irq_restore(l); return ...; } | if (...) + {local_irq_restore(l); return ...; + } | spin_unlock_irqrestore(E2,l); | local_irq_restore(l); ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: Avi Kivity <avi@qumranet.com> |
||
---|---|---|
.. | ||
configs | ||
dig | ||
hp | ||
ia32 | ||
kernel | ||
kvm | ||
lib | ||
mm | ||
oprofile | ||
pci | ||
scripts | ||
sn | ||
uv | ||
install.sh | ||
Kconfig | ||
Kconfig.debug | ||
Makefile | ||
module.lds |