dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

USB: ehci-fsl: Use usb_put_transceiver instead of put_device 

Currently usb_put_transceiver calls put_device so this is a no-op but it
is better to keep API usage consistent as ehci->transceiver is allocated
with usb_get_transceiver.

While at there remove one extra ehci->transceiver test as the code block
has already tested it.

Signed-off-by: Jarkko Nikula <jarkko.nikula@bitmer.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Jarkko Nikula 2012-05-13 21:10:20 +03:00 committed by Greg Kroah-Hartman
parent bebc56d58d
commit fee8bc1c8e
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/usb/host/ehci-fsl.c
View File

@ -150,8 +150,7 @@ static int usb_hcd_fsl_probe(const struct hc_driver *driver,
retval = otg_set_host(ehci->transceiver->otg,
&ehci_to_hcd(ehci)->self);
if (retval) {
if (ehci->transceiver)
put_device(ehci->transceiver->dev);
usb_put_transceiver(ehci->transceiver);
goto err4;
}
} else {
@ -195,7 +194,7 @@ static void usb_hcd_fsl_remove(struct usb_hcd *hcd,
if (ehci->transceiver) {
otg_set_host(ehci->transceiver->otg, NULL);
put_device(ehci->transceiver->dev);
usb_put_transceiver(ehci->transceiver);
}
usb_remove_hcd(hcd);