isci: fix oem parameter validation on single controller skus
OEM parameters [1] are parsed from the platform option-rom / efi driver. By default the driver was validating the parameters for the dual-controller case, but in single-controller case only the first set of parameters may be valid. Limit the validation to the number of actual controllers detected otherwise the driver may fail to parse the valid parameters leading to driver-load or runtime failures. [1] the platform specific set of phy address, configuration,and analog tuning values [stable v3.0+] Cc: <stable@vger.kernel.org> Reported-by: Dave Jiang <dave.jiang@intel.com> Tested-by: Dave Jiang <dave.jiang@intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This commit is contained in:
parent
08e73be56b
commit
fc25f79af3
1 changed files with 1 additions and 1 deletions
|
@ -639,7 +639,7 @@ static int __devinit isci_pci_probe(struct pci_dev *pdev, const struct pci_devic
|
||||||
if (!orom)
|
if (!orom)
|
||||||
orom = isci_request_oprom(pdev);
|
orom = isci_request_oprom(pdev);
|
||||||
|
|
||||||
for (i = 0; orom && i < ARRAY_SIZE(orom->ctrl); i++) {
|
for (i = 0; orom && i < num_controllers(pdev); i++) {
|
||||||
if (sci_oem_parameters_validate(&orom->ctrl[i],
|
if (sci_oem_parameters_validate(&orom->ctrl[i],
|
||||||
orom->hdr.version)) {
|
orom->hdr.version)) {
|
||||||
dev_warn(&pdev->dev,
|
dev_warn(&pdev->dev,
|
||||||
|
|
Reference in a new issue