dect/linux-2.6
Archived
14
0
Fork 0
Code Releases Activity

smsc95xx: generate random MAC address once, not every ifup

Browse source 
The smsc95xx driver currently generates a new random MAC address
every time the interface is brought up. This makes it impossible to
override using the standard `ifconfig hw ether` approach.

Past patches tried to make the MAC address a module parameter or
base it off the die ID, but it seems to me much simpler (and
hopefully less controversial) to stick with the current random
generation scheme, but allow the user to change the address.

This patch does exactly that - it moves the random address
generation from smsc95xx_reset() into smsc95xx_bind(), so that it is
done once on module load, not on every ifup. The user can then
override this using the standard mechanisms.

Applies against 2.6.35 and linux-2.6 head.

Signed-off-by: Bernard Blackham <b-omap@largestprime.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Bernard Blackham 2010-10-18 13:16:39 +00:00 committed by David S. Miller
parent fdb246f526
commit f4e8ab7cc4
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/net/usb/smsc95xx.c
View file

@ -805,8 +805,6 @@ static int smsc95xx_reset(struct usbnet *dev)
return ret;
}
smsc95xx_init_mac_address(dev);
ret = smsc95xx_set_mac_address(dev);
if (ret < 0)
return ret;
@ -1047,6 +1045,8 @@ static int smsc95xx_bind(struct usbnet *dev, struct usb_interface *intf)
pdata->use_tx_csum = DEFAULT_TX_CSUM_ENABLE;
pdata->use_rx_csum = DEFAULT_RX_CSUM_ENABLE;
smsc95xx_init_mac_address(dev);
/* Init all registers */
ret = smsc95xx_reset(dev);