dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

isdn: cleanup: make buffer smaller 

This showed up in my audit because we use strcpy() to copy "ds" into a
32 character buffer inside the isdn_tty_dial() function.  But it turns
out that we only ever use the first 32 characters so it's OK.  I have
changed the declaration to make the static checkers happy.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Dan Carpenter 2010-09-04 08:33:03 +00:00 committed by David S. Miller
parent 017d79ef00
commit f417f5e4ba
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
drivers/isdn/i4l/isdn_tty.c
View File

@ -3515,7 +3515,7 @@ isdn_tty_parse_at(modem_info * info)
{
atemu *m = &info->emu;
char *p;
char ds[40];
char ds[ISDN_MSNLEN];
#ifdef ISDN_DEBUG_AT
printk(KERN_DEBUG "AT: '%s'\n", m->mdmcmd);
@ -3594,7 +3594,7 @@ isdn_tty_parse_at(modem_info * info)
break;
case '3':
p++;
sprintf(ds, "\r\n%d", info->emu.charge);
snprintf(ds, sizeof(ds), "\r\n%d", info->emu.charge);
isdn_tty_at_cout(ds, info);
break;
default:;