dect/linux-2.6
Archived
14
0
Fork 0
Code Releases Activity

qlcnic: fix race in skb->len access.

Browse source 
As soon as skb is given to hardware, TX completion can free skb under us.
Therefore, we should update dev stats before kicking the device.

Signed-off-by: Sucheta Chakraborty <sucheta.chakraborty@qlogic.com>
Signed-off-by: Amit Kumar Salecha <amit.salecha@qlogic.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Sucheta Chakraborty 2011-07-14 03:16:53 +00:00 committed by David S. Miller
parent e5dcf6dcde
commit f127f4727f
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/net/qlcnic/qlcnic_main.c
View file

@ -2290,11 +2290,11 @@ qlcnic_xmit_frame(struct sk_buff *skb, struct net_device *netdev)
if (adapter->mac_learn)
qlcnic_send_filter(adapter, tx_ring, first_desc, skb);
qlcnic_update_cmd_producer(adapter, tx_ring);
adapter->stats.txbytes += skb->len;
adapter->stats.xmitcalled++;
qlcnic_update_cmd_producer(adapter, tx_ring);
return NETDEV_TX_OK;
unwind_buff: