dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

irda: Fix parameter extraction stack overflow 

Cc: stable@kernel.org
Reported-by: Ilja Van Sprundel <ivansprundel@ioactive.com>
Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
This commit is contained in:
Samuel Ortiz 2010-10-11 01:17:56 +02:00 committed by Samuel Ortiz
parent 3b06dbbead
commit efc463eb50
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
net/irda/parameters.c
View File

@ -298,6 +298,8 @@ static int irda_extract_string(void *self, __u8 *buf, int len, __u8 pi,
p.pi = pi; /* In case handler needs to know */
p.pl = buf[1]; /* Extract length of value */
if (p.pl > 32)
p.pl = 32;
IRDA_DEBUG(2, "%s(), pi=%#x, pl=%d\n", __func__,
p.pi, p.pl);
@ -318,7 +320,7 @@ static int irda_extract_string(void *self, __u8 *buf, int len, __u8 pi,
(__u8) str[0], (__u8) str[1]);
/* Null terminate string */
str[p.pl+1] = '\0';
str[p.pl] = '\0';
p.pv.c = str; /* Handler will need to take a copy */