dect/linux-2.6
Archived
14
0
Fork 0
Code Releases Activity

USB: sisusbvga: Fix bug

Browse source 
drivers/usb/misc/sisusbvga/sisusb.c: In function sisusb_open
drivers/usb/misc/sisusbvga/sisusb.c:2444: warning: sisusb is used uninitialized in this function

is a genuine bug (which will cause oops). We cannot use "sisusb" in
error path for (!interface), because sisusb will itself be derived
from "interface" later.

Signed-off-by: Satyam Sharma <satyam@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Satyam Sharma 2007-09-03 01:37:31 +05:30 committed by Greg Kroah-Hartman
parent 5adceac5da
commit e6d42f0e96
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/usb/misc/sisusbvga/sisusb.c
View file

@ -2440,10 +2440,8 @@ sisusb_open(struct inode *inode, struct file *file)
struct usb_interface *interface;
int subminor = iminor(inode);
if (!(interface = usb_find_interface(&sisusb_driver, subminor))) {
dev_err(&sisusb->sisusb_dev->dev, "Failed to find interface\n");
if (!(interface = usb_find_interface(&sisusb_driver, subminor)))
return -ENODEV;
}
if (!(sisusb = usb_get_intfdata(interface)))
return -ENODEV;