[PATCH] md: Avoid oops when attempting to fix read errors on raid10
We should add to the counter for the rdev *after* checking if the rdev is NULL!!! Signed-off-by: Neil Brown <neilb@suse.de> Cc: <stable@kernel.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
parent
235acec78e
commit
df30d0f4ca
|
@ -1435,9 +1435,9 @@ static void raid10d(mddev_t *mddev)
|
||||||
sl--;
|
sl--;
|
||||||
d = r10_bio->devs[sl].devnum;
|
d = r10_bio->devs[sl].devnum;
|
||||||
rdev = conf->mirrors[d].rdev;
|
rdev = conf->mirrors[d].rdev;
|
||||||
atomic_add(s, &rdev->corrected_errors);
|
|
||||||
if (rdev &&
|
if (rdev &&
|
||||||
test_bit(In_sync, &rdev->flags)) {
|
test_bit(In_sync, &rdev->flags)) {
|
||||||
|
atomic_add(s, &rdev->corrected_errors);
|
||||||
if (sync_page_io(rdev->bdev,
|
if (sync_page_io(rdev->bdev,
|
||||||
r10_bio->devs[sl].addr +
|
r10_bio->devs[sl].addr +
|
||||||
sect + rdev->data_offset,
|
sect + rdev->data_offset,
|
||||||
|
|
Reference in New Issue