vmxnet3: fail when try to setup unsupported features
Return EOPNOTSUPP in ethtool_ops->set_flags. Fix coding style while at it. Signed-off-by: Stanislaw Gruszka <sgruszka@redhat.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
52b6dcfe59
commit
d92be4b166
1 changed files with 7 additions and 2 deletions
|
@ -276,16 +276,21 @@ vmxnet3_get_strings(struct net_device *netdev, u32 stringset, u8 *buf)
|
|||
}
|
||||
|
||||
static u32
|
||||
vmxnet3_get_flags(struct net_device *netdev) {
|
||||
vmxnet3_get_flags(struct net_device *netdev)
|
||||
{
|
||||
return netdev->features;
|
||||
}
|
||||
|
||||
static int
|
||||
vmxnet3_set_flags(struct net_device *netdev, u32 data) {
|
||||
vmxnet3_set_flags(struct net_device *netdev, u32 data)
|
||||
{
|
||||
struct vmxnet3_adapter *adapter = netdev_priv(netdev);
|
||||
u8 lro_requested = (data & ETH_FLAG_LRO) == 0 ? 0 : 1;
|
||||
u8 lro_present = (netdev->features & NETIF_F_LRO) == 0 ? 0 : 1;
|
||||
|
||||
if (data & ~ETH_FLAG_LRO)
|
||||
return -EOPNOTSUPP;
|
||||
|
||||
if (lro_requested ^ lro_present) {
|
||||
/* toggle the LRO feature*/
|
||||
netdev->features ^= NETIF_F_LRO;
|
||||
|
|
Reference in a new issue