dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

k_getrusage: don't take rcu_read_lock() 

Just a trivial example, more to come.

k_getrusage() holds rcu_read_lock() because it was previously required by
lock_task_sighand().  Unneeded now.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Oleg Nesterov 2008-04-30 00:52:38 -07:00 committed by Linus Torvalds
parent 1406f2d321
commit d6cf723a14
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
kernel/sys.c
View File

@ -1572,11 +1572,8 @@ static void k_getrusage(struct task_struct *p, int who, struct rusage *r)
goto out;
}
rcu_read_lock();
if (!lock_task_sighand(p, &flags)) {
rcu_read_unlock();
if (!lock_task_sighand(p, &flags))
return;
}
switch (who) {
case RUSAGE_BOTH:
@ -1612,9 +1609,7 @@ static void k_getrusage(struct task_struct *p, int who, struct rusage *r)
default:
BUG();
}
unlock_task_sighand(p, &flags);
rcu_read_unlock();
out:
cputime_to_timeval(utime, &r->ru_utime);