dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

printk: Optimize if statement logic where newline exists 

In reviewing Kay's fix up patch: "printk: Have printk() never buffer its
data", I found two if statements that could be combined and optimized.

Put together the two 'cont.len && cont.owner == current' if statements
into a single one, and check if we need to call cont_add(). This also
removes the unneeded double cont_flush() calls.

Link: http://lkml.kernel.org/r/1340869133.876.10.camel@mop

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Kay Sievers <kay@vrfy.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Steven Rostedt 2012-06-29 11:40:11 -04:00 committed by Greg Kroah-Hartman
parent 084681d14e
commit d36208227d
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
kernel/printk.c
View File

@ -1496,15 +1496,14 @@ asmlinkage int vprintk_emit(int facility, int level,
bool stored = false;
/*
* Flush the conflicting buffer. An earlier newline was missing,
* or we race with a continuation line from an interrupt.
* If an earlier newline was missing and it was the same task,
* either merge it with the current buffer and flush, or if
* there was a race with interrupts (prefix == true) then just
* flush it out and store this line separately.
*/
if (cont.len && prefix && cont.owner == current)
cont_flush();
/* Merge with our buffer if possible; flush it in any case */
if (cont.len && cont.owner == current) {
stored = cont_add(facility, level, text, text_len);
if (!prefix)
stored = cont_add(facility, level, text, text_len);
cont_flush();
}