dect/linux-2.6
Archived
14
0
Fork 0
Code Releases Activity

[POWERPC] spufs: Don't return -ENOSYS as extra notes size if spufs is not loaded

Browse source 
Because the SPU coredump code might be built as part of a module (spufs),
we have a stub which is called by the coredump code, this routine then calls
into spufs if it's loaded.

Unfortunately the stub returns -ENOSYS if spufs is not loaded, which is
interpreted by the coredump code as an extra note size of -38 bytes. This
leads to a corrupt core dump.

If spufs is not loaded there will be no SPU ELF notes to write, and so the
extra notes size will be == 0.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Acked-by: Arnd Bergmann <arnd.bergmann@de.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
This commit is contained in:
Michael Ellerman 2007-09-19 14:38:12 +10:00 committed by Paul Mackerras
parent 59000b53c7
commit c1a72173ab
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
arch/powerpc/platforms/cell/spu_coredump.c
View file

@ -31,15 +31,19 @@ static DEFINE_MUTEX(spu_coredump_mutex);
int arch_notes_size(void) int arch_notes_size(void)
{ {
long ret; int ret;
ret = -ENOSYS;
mutex_lock(&spu_coredump_mutex); mutex_lock(&spu_coredump_mutex);
if (spu_coredump_calls && try_module_get(spu_coredump_calls->owner)) { if (spu_coredump_calls && try_module_get(spu_coredump_calls->owner)) {
ret = spu_coredump_calls->arch_notes_size(); ret = spu_coredump_calls->arch_notes_size();
module_put(spu_coredump_calls->owner); module_put(spu_coredump_calls->owner);
} else {
ret = 0;
} }
mutex_unlock(&spu_coredump_mutex); mutex_unlock(&spu_coredump_mutex);
return ret; return ret;
} }