dect/linux-2.6
Archived
14
0
Fork 0
Code Releases Activity

iommu/dmar: Replace printks with appropriate pr_*()

Browse source 
Just some cleanup so next patch can keep the info printing
the same way throughout the file.

Replace printk(KERN_*  with pr_*() functions.

Signed-off-by: Donald Dutile <ddutile@redhat.com>
Cc: iommu@lists.linux-foundation.org
Cc: chrisw@redhat.com
Cc: suresh.b.siddha@intel.com
Cc: dwmw2@infradead.org
Link: http://lkml.kernel.org/r/1338845342-12464-2-git-send-email-ddutile@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
This commit is contained in:
Donald Dutile 2012-06-04 17:29:01 -04:00 committed by Ingo Molnar
parent 48d212a2ee
commit bf947fcb77
1 changed files with 35 additions and 48 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

83
drivers/iommu/dmar.c
View file

@ -83,15 +83,14 @@ static int __init dmar_parse_one_dev_scope(struct acpi_dmar_device_scope *scope,
* ignore it * ignore it
*/ */
if (!bus) { if (!bus) {
printk(KERN_WARNING pr_warn(PREFIX "Device scope bus [%d] not found\n",
PREFIX "Device scope bus [%d] not found\n", scope->bus);
scope->bus);
break; break;
} }
pdev = pci_get_slot(bus, PCI_DEVFN(path->dev, path->fn)); pdev = pci_get_slot(bus, PCI_DEVFN(path->dev, path->fn));
if (!pdev) { if (!pdev) {
printk(KERN_WARNING PREFIX pr_warn(PREFIX "Device scope device"
"Device scope device [%04x:%02x:%02x.%02x] not found\n", "[%04x:%02x:%02x.%02x] not found\n",
segment, bus->number, path->dev, path->fn); segment, bus->number, path->dev, path->fn);
break; break;
} }
@ -100,9 +99,9 @@ static int __init dmar_parse_one_dev_scope(struct acpi_dmar_device_scope *scope,
bus = pdev->subordinate; bus = pdev->subordinate;
} }
if (!pdev) { if (!pdev) {
printk(KERN_WARNING PREFIX pr_warn(PREFIX
"Device scope device [%04x:%02x:%02x.%02x] not found\n", "Device scope device [%04x:%02x:%02x.%02x] not found\n",
segment, scope->bus, path->dev, path->fn); segment, scope->bus, path->dev, path->fn);
*dev = NULL; *dev = NULL;
return 0; return 0;
} }
@ -110,8 +109,7 @@ static int __init dmar_parse_one_dev_scope(struct acpi_dmar_device_scope *scope,
pdev->subordinate) || (scope->entry_type == \ pdev->subordinate) || (scope->entry_type == \
ACPI_DMAR_SCOPE_TYPE_BRIDGE && !pdev->subordinate)) { ACPI_DMAR_SCOPE_TYPE_BRIDGE && !pdev->subordinate)) {
pci_dev_put(pdev); pci_dev_put(pdev);
printk(KERN_WARNING PREFIX pr_warn(PREFIX "Device scope type does not match for %s\n",
"Device scope type does not match for %s\n",
pci_name(pdev)); pci_name(pdev));
return -EINVAL; return -EINVAL;
} }
@ -134,8 +132,7 @@ int __init dmar_parse_dev_scope(void *start, void *end, int *cnt,
scope->entry_type == ACPI_DMAR_SCOPE_TYPE_BRIDGE) scope->entry_type == ACPI_DMAR_SCOPE_TYPE_BRIDGE)
(*cnt)++; (*cnt)++;
else if (scope->entry_type != ACPI_DMAR_SCOPE_TYPE_IOAPIC) { else if (scope->entry_type != ACPI_DMAR_SCOPE_TYPE_IOAPIC) {
printk(KERN_WARNING PREFIX pr_warn(PREFIX "Unsupported device scope\n");
"Unsupported device scope\n");
} }
start += scope->length; start += scope->length;
} }
@ -261,25 +258,23 @@ dmar_table_print_dmar_entry(struct acpi_dmar_header *header)
case ACPI_DMAR_TYPE_HARDWARE_UNIT: case ACPI_DMAR_TYPE_HARDWARE_UNIT:
drhd = container_of(header, struct acpi_dmar_hardware_unit, drhd = container_of(header, struct acpi_dmar_hardware_unit,
header); header);
printk (KERN_INFO PREFIX pr_info(PREFIX "DRHD base: %#016Lx flags: %#x\n",
"DRHD base: %#016Lx flags: %#x\n",
(unsigned long long)drhd->address, drhd->flags); (unsigned long long)drhd->address, drhd->flags);
break; break;
case ACPI_DMAR_TYPE_RESERVED_MEMORY: case ACPI_DMAR_TYPE_RESERVED_MEMORY:
rmrr = container_of(header, struct acpi_dmar_reserved_memory, rmrr = container_of(header, struct acpi_dmar_reserved_memory,
header); header);
printk (KERN_INFO PREFIX pr_info(PREFIX "RMRR base: %#016Lx end: %#016Lx\n",
"RMRR base: %#016Lx end: %#016Lx\n",
(unsigned long long)rmrr->base_address, (unsigned long long)rmrr->base_address,
(unsigned long long)rmrr->end_address); (unsigned long long)rmrr->end_address);
break; break;
case ACPI_DMAR_TYPE_ATSR: case ACPI_DMAR_TYPE_ATSR:
atsr = container_of(header, struct acpi_dmar_atsr, header); atsr = container_of(header, struct acpi_dmar_atsr, header);
printk(KERN_INFO PREFIX "ATSR flags: %#x\n", atsr->flags); pr_info(PREFIX "ATSR flags: %#x\n", atsr->flags);
break; break;
case ACPI_DMAR_HARDWARE_AFFINITY: case ACPI_DMAR_HARDWARE_AFFINITY:
rhsa = container_of(header, struct acpi_dmar_rhsa, header); rhsa = container_of(header, struct acpi_dmar_rhsa, header);
printk(KERN_INFO PREFIX "RHSA base: %#016Lx proximity domain: %#x\n", pr_info(PREFIX "RHSA base: %#016Lx proximity domain: %#x\n",
(unsigned long long)rhsa->base_address, (unsigned long long)rhsa->base_address,
rhsa->proximity_domain); rhsa->proximity_domain);
break; break;
@ -299,7 +294,7 @@ static int __init dmar_table_detect(void)
&dmar_tbl_size); &dmar_tbl_size);
if (ACPI_SUCCESS(status) && !dmar_tbl) { if (ACPI_SUCCESS(status) && !dmar_tbl) {
printk (KERN_WARNING PREFIX "Unable to map DMAR\n"); pr_warn(PREFIX "Unable to map DMAR\n");
status = AE_NOT_FOUND; status = AE_NOT_FOUND;
} }
@ -333,20 +328,18 @@ parse_dmar_table(void)
return -ENODEV; return -ENODEV;
if (dmar->width < PAGE_SHIFT - 1) { if (dmar->width < PAGE_SHIFT - 1) {
printk(KERN_WARNING PREFIX "Invalid DMAR haw\n"); pr_warn(PREFIX "Invalid DMAR haw\n");
return -EINVAL; return -EINVAL;
} }
printk (KERN_INFO PREFIX "Host address width %d\n", pr_info(PREFIX "Host address width %d\n", dmar->width + 1);
dmar->width + 1);
entry_header = (struct acpi_dmar_header *)(dmar + 1); entry_header = (struct acpi_dmar_header *)(dmar + 1);
while (((unsigned long)entry_header) < while (((unsigned long)entry_header) <
(((unsigned long)dmar) + dmar_tbl->length)) { (((unsigned long)dmar) + dmar_tbl->length)) {
/* Avoid looping forever on bad ACPI tables */ /* Avoid looping forever on bad ACPI tables */
if (entry_header->length == 0) { if (entry_header->length == 0) {
printk(KERN_WARNING PREFIX pr_warn(PREFIX "Invalid 0-length structure\n");
"Invalid 0-length structure\n");
ret = -EINVAL; ret = -EINVAL;
break; break;
} }
@ -369,8 +362,7 @@ parse_dmar_table(void)
#endif #endif
break; break;
default: default:
printk(KERN_WARNING PREFIX pr_warn(PREFIX "Unknown DMAR structure type %d\n",
"Unknown DMAR structure type %d\n",
entry_header->type); entry_header->type);
ret = 0; /* for forward compatibility */ ret = 0; /* for forward compatibility */
break; break;
@ -469,12 +461,12 @@ int __init dmar_table_init(void)
ret = parse_dmar_table(); ret = parse_dmar_table();
if (ret) { if (ret) {
if (ret != -ENODEV) if (ret != -ENODEV)
printk(KERN_INFO PREFIX "parse DMAR table failure.\n"); pr_info(PREFIX "parse DMAR table failure.\n");
return ret; return ret;
} }
if (list_empty(&dmar_drhd_units)) { if (list_empty(&dmar_drhd_units)) {
printk(KERN_INFO PREFIX "No DMAR devices found\n"); pr_info(PREFIX "No DMAR devices found\n");
return -ENODEV; return -ENODEV;
} }
@ -506,8 +498,7 @@ int __init check_zero_address(void)
(((unsigned long)dmar) + dmar_tbl->length)) { (((unsigned long)dmar) + dmar_tbl->length)) {
/* Avoid looping forever on bad ACPI tables */ /* Avoid looping forever on bad ACPI tables */
if (entry_header->length == 0) { if (entry_header->length == 0) {
printk(KERN_WARNING PREFIX pr_warn(PREFIX "Invalid 0-length structure\n");
"Invalid 0-length structure\n");
return 0; return 0;
} }
@ -558,8 +549,8 @@ int __init detect_intel_iommu(void)
if (ret && irq_remapping_enabled && cpu_has_x2apic && if (ret && irq_remapping_enabled && cpu_has_x2apic &&
dmar->flags & 0x1) dmar->flags & 0x1)
printk(KERN_INFO pr_info("Queued invalidation will be enabled to "
"Queued invalidation will be enabled to support x2apic and Intr-remapping.\n"); "support x2apic and Intr-remapping.\n");
if (ret && !no_iommu && !iommu_detected && !dmar_disabled) { if (ret && !no_iommu && !iommu_detected && !dmar_disabled) {
iommu_detected = 1; iommu_detected = 1;
@ -602,7 +593,7 @@ int alloc_iommu(struct dmar_drhd_unit *drhd)
iommu->reg = ioremap(drhd->reg_base_addr, VTD_PAGE_SIZE); iommu->reg = ioremap(drhd->reg_base_addr, VTD_PAGE_SIZE);
if (!iommu->reg) { if (!iommu->reg) {
printk(KERN_ERR "IOMMU: can't map the region\n"); pr_err("IOMMU: can't map the region\n");
goto error; goto error;
} }
iommu->cap = dmar_readq(iommu->reg + DMAR_CAP_REG); iommu->cap = dmar_readq(iommu->reg + DMAR_CAP_REG);
@ -615,15 +606,13 @@ int alloc_iommu(struct dmar_drhd_unit *drhd)
agaw = iommu_calculate_agaw(iommu); agaw = iommu_calculate_agaw(iommu);
if (agaw < 0) { if (agaw < 0) {
printk(KERN_ERR pr_err("Cannot get a valid agaw for iommu (seq_id = %d)\n",
"Cannot get a valid agaw for iommu (seq_id = %d)\n", iommu->seq_id);
iommu->seq_id);
goto err_unmap; goto err_unmap;
} }
msagaw = iommu_calculate_max_sagaw(iommu); msagaw = iommu_calculate_max_sagaw(iommu);
if (msagaw < 0) { if (msagaw < 0) {
printk(KERN_ERR pr_err("Cannot get a valid max agaw for iommu (seq_id = %d)\n",
"Cannot get a valid max agaw for iommu (seq_id = %d)\n",
iommu->seq_id); iommu->seq_id);
goto err_unmap; goto err_unmap;
} }
@ -640,7 +629,7 @@ int alloc_iommu(struct dmar_drhd_unit *drhd)
iounmap(iommu->reg); iounmap(iommu->reg);
iommu->reg = ioremap(drhd->reg_base_addr, map_size); iommu->reg = ioremap(drhd->reg_base_addr, map_size);
if (!iommu->reg) { if (!iommu->reg) {
printk(KERN_ERR "IOMMU: can't map the region\n"); pr_err("IOMMU: can't map the region\n");
goto error; goto error;
} }
} }
@ -710,7 +699,7 @@ static int qi_check_fault(struct intel_iommu *iommu, int index)
if (fault & DMA_FSTS_IQE) { if (fault & DMA_FSTS_IQE) {
head = readl(iommu->reg + DMAR_IQH_REG); head = readl(iommu->reg + DMAR_IQH_REG);
if ((head >> DMAR_IQ_SHIFT) == index) { if ((head >> DMAR_IQ_SHIFT) == index) {
printk(KERN_ERR "VT-d detected invalid descriptor: " pr_err("VT-d detected invalid descriptor: "
"low=%llx, high=%llx\n", "low=%llx, high=%llx\n",
(unsigned long long)qi->desc[index].low, (unsigned long long)qi->desc[index].low,
(unsigned long long)qi->desc[index].high); (unsigned long long)qi->desc[index].high);
@ -1129,15 +1118,14 @@ static int dmar_fault_do_one(struct intel_iommu *iommu, int type,
reason = dmar_get_fault_reason(fault_reason, &fault_type); reason = dmar_get_fault_reason(fault_reason, &fault_type);
if (fault_type == INTR_REMAP) if (fault_type == INTR_REMAP)
printk(KERN_ERR "INTR-REMAP: Request device [[%02x:%02x.%d] " pr_err("INTR-REMAP: Request device [[%02x:%02x.%d] "
"fault index %llx\n" "fault index %llx\n"
"INTR-REMAP:[fault reason %02d] %s\n", "INTR-REMAP:[fault reason %02d] %s\n",
(source_id >> 8), PCI_SLOT(source_id & 0xFF), (source_id >> 8), PCI_SLOT(source_id & 0xFF),
PCI_FUNC(source_id & 0xFF), addr >> 48, PCI_FUNC(source_id & 0xFF), addr >> 48,
fault_reason, reason); fault_reason, reason);
else else
printk(KERN_ERR pr_err("DMAR:[%s] Request device [%02x:%02x.%d] "
"DMAR:[%s] Request device [%02x:%02x.%d] "
"fault addr %llx \n" "fault addr %llx \n"
"DMAR:[fault reason %02d] %s\n", "DMAR:[fault reason %02d] %s\n",
(type ? "DMA Read" : "DMA Write"), (type ? "DMA Read" : "DMA Write"),
@ -1157,8 +1145,7 @@ irqreturn_t dmar_fault(int irq, void *dev_id)
raw_spin_lock_irqsave(&iommu->register_lock, flag); raw_spin_lock_irqsave(&iommu->register_lock, flag);
fault_status = readl(iommu->reg + DMAR_FSTS_REG); fault_status = readl(iommu->reg + DMAR_FSTS_REG);
if (fault_status) if (fault_status)
printk(KERN_ERR "DRHD: handling fault status reg %x\n", pr_err("DRHD: handling fault status reg %x\n", fault_status);
fault_status);
/* TBD: ignore advanced fault log currently */ /* TBD: ignore advanced fault log currently */
if (!(fault_status & DMA_FSTS_PPF)) if (!(fault_status & DMA_FSTS_PPF))
@ -1224,7 +1211,7 @@ int dmar_set_interrupt(struct intel_iommu *iommu)
irq = create_irq(); irq = create_irq();
if (!irq) { if (!irq) {
printk(KERN_ERR "IOMMU: no free vectors\n"); pr_err("IOMMU: no free vectors\n");
return -EINVAL; return -EINVAL;
} }
@ -1241,7 +1228,7 @@ int dmar_set_interrupt(struct intel_iommu *iommu)
ret = request_irq(irq, dmar_fault, IRQF_NO_THREAD, iommu->name, iommu); ret = request_irq(irq, dmar_fault, IRQF_NO_THREAD, iommu->name, iommu);
if (ret) if (ret)
printk(KERN_ERR "IOMMU: can't request irq\n"); pr_err("IOMMU: can't request irq\n");
return ret; return ret;
} }
@ -1258,7 +1245,7 @@ int __init enable_drhd_fault_handling(void)
ret = dmar_set_interrupt(iommu); ret = dmar_set_interrupt(iommu);
if (ret) { if (ret) {
printk(KERN_ERR "DRHD %Lx: failed to enable fault, " pr_err("DRHD %Lx: failed to enable fault, "
" interrupt, ret %d\n", " interrupt, ret %d\n",
(unsigned long long)drhd->reg_base_addr, ret); (unsigned long long)drhd->reg_base_addr, ret);
return -1; return -1;