dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

w1_bq27000: remove unnecessary NULL test. 

As recent change means that we now dereference 'dev' before testing
for NULL.

That means either the change was wrong, or the test isn't needed.
As this function is only called from one driver (bq27x000_battery) and
it always passed a non-NULL dev, it seems good to assume that the
test isn't needed.

So remove it.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
NeilBrown 2012-02-19 13:10:00 +11:00 committed by Greg Kroah-Hartman
parent 93518dd2eb
commit b6c40b8581
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/w1/slaves/w1_bq27000.c
View File

@ -45,9 +45,6 @@ static int w1_bq27000_read(struct device *dev, unsigned int reg)
u8 val;
struct w1_slave *sl = container_of(dev->parent, struct w1_slave, dev);
if (!dev)
return 0;
w1_write_8(sl->master, HDQ_CMD_READ | reg);
val = w1_read_8(sl->master);