dect/linux-2.6
Archived
14
0
Fork 0
Code Releases Activity

[PATCH] ioremap balanced with iounmap for drivers/video/atyfb_base

Browse source 
ioremap must be balanced by an iounmap and failing to do so can result in a
memory leak.

Signed-off-by: Amol Lad <amol@verismonetworks.com>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This commit is contained in:
Amol Lad 2006-12-08 02:40:14 -08:00 committed by Linus Torvalds
parent d8b8c0a697
commit b2a85aebf9
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/video/aty/atyfb_base.c
View file

@ -3527,6 +3527,10 @@ static int __devinit atyfb_setup_generic(struct pci_dev *pdev, struct fb_info *i
atyfb_setup_generic_fail: atyfb_setup_generic_fail:
iounmap(par->ati_regbase); iounmap(par->ati_regbase);
par->ati_regbase = NULL; par->ati_regbase = NULL;
if (info->screen_base) {
iounmap(info->screen_base);
info->screen_base = NULL;
}
return ret; return ret;
} }
@ -3695,6 +3699,10 @@ static int __devinit atyfb_atari_probe(void)
} }
if (aty_init(info, "ISA bus")) { if (aty_init(info, "ISA bus")) {
if (info->screen_base)
iounmap(info->screen_base);
if (par->ati_regbase)
iounmap(par->ati_regbase);
framebuffer_release(info); framebuffer_release(info);
/* This is insufficient! kernel_map has added two large chunks!! */ /* This is insufficient! kernel_map has added two large chunks!! */
return -ENXIO; return -ENXIO;