perf annotate browser: The idx_asm field should be used in asm only view
When hide_src_view is true we can't use browser_disasm_line->idx, that takes into account also non asm lines, we must use browser_disasm_line->idx_asm instead, otherwise we may end up with an index after the number of entries, oops, fix it. Cc: David Ahern <dsahern@gmail.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Namhyung Kim <namhyung@gmail.com> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/n/tip-o1szpyjh3z87yi0n6x0cr8uu@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
parent
3780f4883b
commit
a44b45f236
|
@ -300,10 +300,14 @@ static void annotate_browser__set_rb_top(struct annotate_browser *browser,
|
||||||
{
|
{
|
||||||
struct browser_disasm_line *bpos;
|
struct browser_disasm_line *bpos;
|
||||||
struct disasm_line *pos;
|
struct disasm_line *pos;
|
||||||
|
u32 idx;
|
||||||
|
|
||||||
bpos = rb_entry(nd, struct browser_disasm_line, rb_node);
|
bpos = rb_entry(nd, struct browser_disasm_line, rb_node);
|
||||||
pos = ((struct disasm_line *)bpos) - 1;
|
pos = ((struct disasm_line *)bpos) - 1;
|
||||||
annotate_browser__set_top(browser, pos, bpos->idx);
|
idx = bpos->idx;
|
||||||
|
if (browser->hide_src_code)
|
||||||
|
idx = bpos->idx_asm;
|
||||||
|
annotate_browser__set_top(browser, pos, idx);
|
||||||
browser->curr_hot = nd;
|
browser->curr_hot = nd;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Reference in New Issue