perf python: Use exception to propagate errors
We were using pr_debug to tell the user about not being able to parse a sample where we should really use the python way of reporting errors: exceptions. Fixes this problem: [root@emilia ~]# python >>> import perf Traceback (most recent call last): File "<stdin>", line 1, in <module> ImportError: /home/acme/git/build/perf/python/perf.so: undefined symbol: eprintf >>> [root@emilia ~] As we want to keep the objects linked in the python binding (and in the future in a shared library) minimal. Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Mike Galbraith <efault@gmx.de> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Link: http://lkml.kernel.org/n/tip-m9dba9kaluas0kq8r58z191c@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
This commit is contained in:
parent
d21cc9f67d
commit
9c850d6c4b
1 changed files with 4 additions and 6 deletions
|
@ -694,14 +694,12 @@ static PyObject *pyrf_evlist__read_on_cpu(struct pyrf_evlist *pevlist,
|
||||||
err = perf_event__parse_sample(event, first->attr.sample_type,
|
err = perf_event__parse_sample(event, first->attr.sample_type,
|
||||||
perf_sample_size(first->attr.sample_type),
|
perf_sample_size(first->attr.sample_type),
|
||||||
sample_id_all, &pevent->sample);
|
sample_id_all, &pevent->sample);
|
||||||
if (err) {
|
if (err)
|
||||||
pr_err("Can't parse sample, err = %d\n", err);
|
return PyErr_Format(PyExc_OSError,
|
||||||
goto end;
|
"perf: can't parse sample, err=%d", err);
|
||||||
}
|
|
||||||
|
|
||||||
return pyevent;
|
return pyevent;
|
||||||
}
|
}
|
||||||
end:
|
|
||||||
Py_INCREF(Py_None);
|
Py_INCREF(Py_None);
|
||||||
return Py_None;
|
return Py_None;
|
||||||
}
|
}
|
||||||
|
|
Reference in a new issue