dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

sound: read i_size with i_size_read() 

Convert direct read of inode->i_size to using i_size_read().
i_size_read is guaranteed to return a valid value and
its caller does not need to use addtional locking.

Signed-off-by: Xiaochen Wang <wangxiaochen0@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Xiaochen Wang 2011-03-18 16:29:25 +08:00 committed by Takashi Iwai
parent d351cf4603
commit 977a6ef3c0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sound/sound_firmware.c
View File

@ -19,7 +19,7 @@ static int do_mod_firmware_load(const char *fn, char **fp)
printk(KERN_INFO "Unable to load '%s'.\n", fn); printk(KERN_INFO "Unable to load '%s'.\n", fn);
return 0; return 0;
} }
l = filp->f_path.dentry->d_inode->i_size; l = i_size_read(filp->f_path.dentry->d_inode);
if (l <= 0 || l > 131072) if (l <= 0 || l > 131072)
{ {
printk(KERN_INFO "Invalid firmware '%s'\n", fn); printk(KERN_INFO "Invalid firmware '%s'\n", fn);