USB: usblp: fixed switch, brace, whitespace and spacing coding style issues
Fixed switch, brace, whitespace and spacing coding style issues. Signed-off-by: Nicolas Kaiser <nikai@nikai.net> Acked-by: Pete Zaitcev <zaitcev@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Nicolas Kaiser
Greg Kroah-Hartman
parent
3da7cff4e7
commit
916de02720
|
|
@ -169,7 +169,8 @@ struct usblp {
|
|||
};
|
||||
|
||||
#ifdef DEBUG
|
||||
static void usblp_dump(struct usblp *usblp) {
|
||||
static void usblp_dump(struct usblp *usblp)
|
||||
{
|
||||
int p;
|
||||
|
||||
dbg("usblp=0x%p", usblp);
|
||||
|
|
@ -254,9 +255,8 @@ static int usblp_ctrl_msg(struct usblp *usblp, int request, int type, int dir, i
|
|||
/* High byte has the interface index.
|
||||
Low byte has the alternate setting.
|
||||
*/
|
||||
if ((request == USBLP_REQ_GET_ID) && (type == USB_TYPE_CLASS)) {
|
||||
if ((request == USBLP_REQ_GET_ID) && (type == USB_TYPE_CLASS))
|
||||
index = (usblp->ifnum<<8)|usblp->protocol[usblp->current_protocol].alt_setting;
|
||||
}
|
||||
|
||||
retval = usb_control_msg(usblp->dev,
|
||||
dir ? usb_rcvctrlpipe(usblp->dev, 0) : usb_sndctrlpipe(usblp->dev, 0),
|
||||
|
|
@ -372,7 +372,7 @@ static int usblp_check_status(struct usblp *usblp, int err)
|
|||
return newerr;
|
||||
}
|
||||
|
||||
static int handle_bidir (struct usblp *usblp)
|
||||
static int handle_bidir(struct usblp *usblp)
|
||||
{
|
||||
if (usblp->bidir && usblp->used) {
|
||||
if (usblp_submit_read(usblp) < 0)
|
||||
|
|
@ -395,14 +395,13 @@ static int usblp_open(struct inode *inode, struct file *file)
|
|||
if (minor < 0)
|
||||
return -ENODEV;
|
||||
|
||||
mutex_lock (&usblp_mutex);
|
||||
mutex_lock(&usblp_mutex);
|
||||
|
||||
retval = -ENODEV;
|
||||
intf = usb_find_interface(&usblp_driver, minor);
|
||||
if (!intf) {
|
||||
if (!intf)
|
||||
goto out;
|
||||
}
|
||||
usblp = usb_get_intfdata (intf);
|
||||
usblp = usb_get_intfdata(intf);
|
||||
if (!usblp || !usblp->dev || !usblp->present)
|
||||
goto out;
|
||||
|
||||
|
|
@ -433,18 +432,18 @@ static int usblp_open(struct inode *inode, struct file *file)
|
|||
retval = -EIO;
|
||||
}
|
||||
out:
|
||||
mutex_unlock (&usblp_mutex);
|
||||
mutex_unlock(&usblp_mutex);
|
||||
return retval;
|
||||
}
|
||||
|
||||
static void usblp_cleanup (struct usblp *usblp)
|
||||
static void usblp_cleanup(struct usblp *usblp)
|
||||
{
|
||||
printk(KERN_INFO "usblp%d: removed\n", usblp->minor);
|
||||
|
||||
kfree(usblp->readbuf);
|
||||
kfree (usblp->device_id_string);
|
||||
kfree (usblp->statusbuf);
|
||||
kfree (usblp);
|
||||
kfree(usblp->device_id_string);
|
||||
kfree(usblp->statusbuf);
|
||||
kfree(usblp);
|
||||
}
|
||||
|
||||
static void usblp_unlink_urbs(struct usblp *usblp)
|
||||
|
|
@ -458,14 +457,14 @@ static int usblp_release(struct inode *inode, struct file *file)
|
|||
|
||||
usblp->flags &= ~LP_ABORT;
|
||||
|
||||
mutex_lock (&usblp_mutex);
|
||||
mutex_lock(&usblp_mutex);
|
||||
usblp->used = 0;
|
||||
if (usblp->present) {
|
||||
usblp_unlink_urbs(usblp);
|
||||
usb_autopm_put_interface(usblp->intf);
|
||||
} else /* finish cleanup from disconnect */
|
||||
usblp_cleanup (usblp);
|
||||
mutex_unlock (&usblp_mutex);
|
||||
usblp_cleanup(usblp);
|
||||
mutex_unlock(&usblp_mutex);
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
|
@ -495,14 +494,14 @@ static long usblp_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
|||
int twoints[2];
|
||||
int retval = 0;
|
||||
|
||||
mutex_lock (&usblp->mut);
|
||||
mutex_lock(&usblp->mut);
|
||||
if (!usblp->present) {
|
||||
retval = -ENODEV;
|
||||
goto done;
|
||||
}
|
||||
|
||||
dbg("usblp_ioctl: cmd=0x%x (%c nr=%d len=%d dir=%d)", cmd, _IOC_TYPE(cmd),
|
||||
_IOC_NR(cmd), _IOC_SIZE(cmd), _IOC_DIR(cmd) );
|
||||
_IOC_NR(cmd), _IOC_SIZE(cmd), _IOC_DIR(cmd));
|
||||
|
||||
if (_IOC_TYPE(cmd) == 'P') /* new-style ioctl number */
|
||||
|
||||
|
|
@ -662,7 +661,7 @@ static long usblp_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
|||
goto done;
|
||||
}
|
||||
status = *usblp->statusbuf;
|
||||
if (copy_to_user ((void __user *)arg, &status, sizeof(int)))
|
||||
if (copy_to_user((void __user *)arg, &status, sizeof(int)))
|
||||
retval = -EFAULT;
|
||||
break;
|
||||
|
||||
|
|
@ -678,7 +677,7 @@ static long usblp_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
|
|||
}
|
||||
|
||||
done:
|
||||
mutex_unlock (&usblp->mut);
|
||||
mutex_unlock(&usblp->mut);
|
||||
return retval;
|
||||
}
|
||||
|
||||
|
|
@ -840,7 +839,7 @@ static ssize_t usblp_read(struct file *file, char __user *buffer, size_t len, lo
|
|||
}
|
||||
|
||||
done:
|
||||
mutex_unlock (&usblp->mut);
|
||||
mutex_unlock(&usblp->mut);
|
||||
return count;
|
||||
}
|
||||
|
||||
|
|
@ -1023,7 +1022,7 @@ raise_urb:
|
|||
* while you are sending print data, and you don't try to query the
|
||||
* printer status every couple of milliseconds, you will probably be OK.
|
||||
*/
|
||||
static unsigned int usblp_quirks (__u16 vendor, __u16 product)
|
||||
static unsigned int usblp_quirks(__u16 vendor, __u16 product)
|
||||
{
|
||||
int i;
|
||||
|
||||
|
|
@ -1061,7 +1060,7 @@ static struct usb_class_driver usblp_class = {
|
|||
static ssize_t usblp_show_ieee1284_id(struct device *dev, struct device_attribute *attr, char *buf)
|
||||
{
|
||||
struct usb_interface *intf = to_usb_interface(dev);
|
||||
struct usblp *usblp = usb_get_intfdata (intf);
|
||||
struct usblp *usblp = usb_get_intfdata(intf);
|
||||
|
||||
if (usblp->device_id_string[0] == 0 &&
|
||||
usblp->device_id_string[1] == 0)
|
||||
|
|
@ -1075,7 +1074,7 @@ static DEVICE_ATTR(ieee1284_id, S_IRUGO, usblp_show_ieee1284_id, NULL);
|
|||
static int usblp_probe(struct usb_interface *intf,
|
||||
const struct usb_device_id *id)
|
||||
{
|
||||
struct usb_device *dev = interface_to_usbdev (intf);
|
||||
struct usb_device *dev = interface_to_usbdev(intf);
|
||||
struct usblp *usblp;
|
||||
int protocol;
|
||||
int retval;
|
||||
|
|
@ -1089,7 +1088,7 @@ static int usblp_probe(struct usb_interface *intf,
|
|||
}
|
||||
usblp->dev = dev;
|
||||
mutex_init(&usblp->wmut);
|
||||
mutex_init (&usblp->mut);
|
||||
mutex_init(&usblp->mut);
|
||||
spin_lock_init(&usblp->lock);
|
||||
init_waitqueue_head(&usblp->rwait);
|
||||
init_waitqueue_head(&usblp->wwait);
|
||||
|
|
@ -1153,7 +1152,7 @@ static int usblp_probe(struct usb_interface *intf,
|
|||
usblp_check_status(usblp, 0);
|
||||
#endif
|
||||
|
||||
usb_set_intfdata (intf, usblp);
|
||||
usb_set_intfdata(intf, usblp);
|
||||
|
||||
usblp->present = 1;
|
||||
|
||||
|
|
@ -1177,7 +1176,7 @@ static int usblp_probe(struct usb_interface *intf,
|
|||
return 0;
|
||||
|
||||
abort_intfdata:
|
||||
usb_set_intfdata (intf, NULL);
|
||||
usb_set_intfdata(intf, NULL);
|
||||
device_remove_file(&intf->dev, &dev_attr_ieee1284_id);
|
||||
abort:
|
||||
kfree(usblp->readbuf);
|
||||
|
|
@ -1340,35 +1339,35 @@ static int usblp_cache_device_id_string(struct usblp *usblp)
|
|||
|
||||
static void usblp_disconnect(struct usb_interface *intf)
|
||||
{
|
||||
struct usblp *usblp = usb_get_intfdata (intf);
|
||||
struct usblp *usblp = usb_get_intfdata(intf);
|
||||
|
||||
usb_deregister_dev(intf, &usblp_class);
|
||||
|
||||
if (!usblp || !usblp->dev) {
|
||||
dev_err(&intf->dev, "bogus disconnect\n");
|
||||
BUG ();
|
||||
BUG();
|
||||
}
|
||||
|
||||
device_remove_file(&intf->dev, &dev_attr_ieee1284_id);
|
||||
|
||||
mutex_lock (&usblp_mutex);
|
||||
mutex_lock (&usblp->mut);
|
||||
mutex_lock(&usblp_mutex);
|
||||
mutex_lock(&usblp->mut);
|
||||
usblp->present = 0;
|
||||
wake_up(&usblp->wwait);
|
||||
wake_up(&usblp->rwait);
|
||||
usb_set_intfdata (intf, NULL);
|
||||
usb_set_intfdata(intf, NULL);
|
||||
|
||||
usblp_unlink_urbs(usblp);
|
||||
mutex_unlock (&usblp->mut);
|
||||
mutex_unlock(&usblp->mut);
|
||||
|
||||
if (!usblp->used)
|
||||
usblp_cleanup (usblp);
|
||||
mutex_unlock (&usblp_mutex);
|
||||
usblp_cleanup(usblp);
|
||||
mutex_unlock(&usblp_mutex);
|
||||
}
|
||||
|
||||
static int usblp_suspend(struct usb_interface *intf, pm_message_t message)
|
||||
{
|
||||
struct usblp *usblp = usb_get_intfdata (intf);
|
||||
struct usblp *usblp = usb_get_intfdata(intf);
|
||||
|
||||
usblp_unlink_urbs(usblp);
|
||||
#if 0 /* XXX Do we want this? What if someone is reading, should we fail? */
|
||||
|
|
@ -1382,10 +1381,10 @@ static int usblp_suspend(struct usb_interface *intf, pm_message_t message)
|
|||
|
||||
static int usblp_resume(struct usb_interface *intf)
|
||||
{
|
||||
struct usblp *usblp = usb_get_intfdata (intf);
|
||||
struct usblp *usblp = usb_get_intfdata(intf);
|
||||
int r;
|
||||
|
||||
r = handle_bidir (usblp);
|
||||
r = handle_bidir(usblp);
|
||||
|
||||
return r;
|
||||
}
|
||||
|
|
@ -1401,7 +1400,7 @@ static const struct usb_device_id usblp_ids[] = {
|
|||
{ } /* Terminating entry */
|
||||
};
|
||||
|
||||
MODULE_DEVICE_TABLE (usb, usblp_ids);
|
||||
MODULE_DEVICE_TABLE(usb, usblp_ids);
|
||||
|
||||
static struct usb_driver usblp_driver = {
|
||||
.name = "usblp",
|
||||
|
|
@ -1426,8 +1425,8 @@ static void __exit usblp_exit(void)
|
|||
module_init(usblp_init);
|
||||
module_exit(usblp_exit);
|
||||
|
||||
MODULE_AUTHOR( DRIVER_AUTHOR );
|
||||
MODULE_DESCRIPTION( DRIVER_DESC );
|
||||
MODULE_AUTHOR(DRIVER_AUTHOR);
|
||||
MODULE_DESCRIPTION(DRIVER_DESC);
|
||||
module_param(proto_bias, int, S_IRUGO | S_IWUSR);
|
||||
MODULE_PARM_DESC(proto_bias, "Favourite protocol number");
|
||||
MODULE_LICENSE("GPL");
|
||||
|
|
|
|||
Reference in New Issue