drivers/net/qlcnic: Use available error codes
The error code is stored in the variable err, but it is the variable ret that is returned instead. So store the error code in ret. Err is then useless. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r@ local idexpression x; constant C; @@ if (...) { ... x = -C ... when != x ( return <+...x...+>; | return NULL; | return; | * return ...; ) } // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
49339ccae5
commit
900853a4db
1 changed files with 3 additions and 3 deletions
|
@ -474,7 +474,7 @@ static int
|
|||
qlcnic_init_pci_info(struct qlcnic_adapter *adapter)
|
||||
{
|
||||
struct qlcnic_pci_info *pci_info;
|
||||
int i, ret = 0, err;
|
||||
int i, ret = 0;
|
||||
u8 pfn;
|
||||
|
||||
pci_info = kcalloc(QLCNIC_MAX_PCI_FUNC, sizeof(*pci_info), GFP_KERNEL);
|
||||
|
@ -484,14 +484,14 @@ qlcnic_init_pci_info(struct qlcnic_adapter *adapter)
|
|||
adapter->npars = kzalloc(sizeof(struct qlcnic_npar_info) *
|
||||
QLCNIC_MAX_PCI_FUNC, GFP_KERNEL);
|
||||
if (!adapter->npars) {
|
||||
err = -ENOMEM;
|
||||
ret = -ENOMEM;
|
||||
goto err_pci_info;
|
||||
}
|
||||
|
||||
adapter->eswitch = kzalloc(sizeof(struct qlcnic_eswitch) *
|
||||
QLCNIC_NIU_MAX_XG_PORTS, GFP_KERNEL);
|
||||
if (!adapter->eswitch) {
|
||||
err = -ENOMEM;
|
||||
ret = -ENOMEM;
|
||||
goto err_npars;
|
||||
}
|
||||
|
||||
|
|
Reference in a new issue