dect/linux-2.6
Archived
14
0
Fork 0
Code Releases Activity

Remove bogons from the iSeries console

Browse source 
The iSeries driver calls into the n_tty ldisc code directly for some
bizarre reason. I previously tagged this with a query but this actually
does need fixing as n_tty methods when you have a different ldisc set are
not a good thing to call.

In n_tty mode this change should have no effect, the core tty layer has
always called the ldisc ioctl method *anyway* and will call the one for
the right ldisc.

Signed-off-by: Alan Cox <alan@redhat.com>
Acked-by: Stephen Rothwell <sfr@canb.auug.org.au>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Alan Cox 2008-08-06 14:06:29 +01:00 committed by Linus Torvalds
parent 3a35c27ac6
commit 8bc5fb6abb
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/char/viocons.c
View file

@ -705,10 +705,6 @@ static int viotty_ioctl(struct tty_struct *tty, struct file *file,
case KDSKBLED:
return 0;
}
/* FIXME: WTF is this being called for ??? */
lock_kernel();
ret = n_tty_ioctl(tty, file, cmd, arg);
unlock_kernel();
return ret;
}