dect/linux-2.6
Archived
14
0
Fork 0
Code Releases Activity

staging: hv: remove ASSERT()s in RndisFilter.c

Browse source 
return -EINVAL instead of calling ASSERT() for these conditionals.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Bill Pemberton 2010-05-05 15:27:47 -04:00 committed by Greg Kroah-Hartman
parent 45e4431468
commit 8a62d7168a
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
drivers/staging/hv/RndisFilter.c
View file

@ -391,7 +391,9 @@ static int RndisFilterOnReceive(struct hv_device *Device,
DPRINT_ENTER(NETVSC);
ASSERT(netDevice);
if (!netDevice)
return -EINVAL;
/* Make sure the rndis device state is initialized */
if (!netDevice->Extension) {
DPRINT_ERR(NETVSC, "got rndis message but no rndis device..."
@ -492,7 +494,8 @@ static int RndisFilterQueryDevice(struct rndis_device *Device, u32 Oid,
DPRINT_ENTER(NETVSC);
ASSERT(Result);
if (!Result)
return -EINVAL;
*ResultSize = 0;
request = GetRndisRequest(Device, REMOTE_NDIS_QUERY_MSG,
@ -885,7 +888,9 @@ int RndisFilterOnOpen(struct hv_device *Device)
DPRINT_ENTER(NETVSC);
ASSERT(netDevice);
if (!netDevice)
return -EINVAL;
ret = RndisFilterOpenDevice(netDevice->Extension);
DPRINT_EXIT(NETVSC);
@ -900,7 +905,9 @@ int RndisFilterOnClose(struct hv_device *Device)
DPRINT_ENTER(NETVSC);
ASSERT(netDevice);
if (!netDevice)
return -EINVAL;
ret = RndisFilterCloseDevice(netDevice->Extension);
DPRINT_EXIT(NETVSC);