dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

rcu: Add warning for RCU_FAST_NO_HZ timer firing 

RCU_FAST_NO_HZ uses a timer to limit the time that a CPU with callbacks
can remain in dyntick-idle mode.  This timer is cancelled when the CPU
exits idle, and therefore should never fire.  However, if the timer
were migrated to some other CPU for whatever reason (1) the timer could
actually fire and (2) firing on some other CPU would fail to wake up the
CPU with callbacks, possibly resulting in sluggishness or a system hang.

This commit therfore adds a WARN_ON_ONCE() to the timer handler in order
to detect this condition.

Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
This commit is contained in:
Paul E. McKenney 2012-04-23 10:06:39 -07:00 committed by Paul E. McKenney
parent c57afe80db
commit 79b9a75fb7
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
kernel/rcutree_plugin.h
View File

@ -2065,6 +2065,7 @@ static bool rcu_cpu_has_nonlazy_callbacks(int cpu)
*/
static void rcu_idle_gp_timer_func(unsigned long unused)
{
WARN_ON_ONCE(1); /* Getting here can hang the system... */
trace_rcu_prep_idle("Timer");
}