[SCSI] ufs: reverse the ufshcd_is_device_present logic
Otherwise it counter intuitively returns 0 if device is present. Signed-off-by: Venkatraman S <svenkatr@ti.com> Reviewed-by: Namjae Jeon <linkinjeon@gmail.com> Acked-by: Santosh Y <santoshsy@gmail.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
This commit is contained in:
parent
17ccafc4ef
commit
73ec513a3b
1 changed files with 3 additions and 3 deletions
|
@ -232,11 +232,11 @@ static inline u32 ufshcd_get_ufs_version(struct ufs_hba *hba)
|
||||||
* the host controller
|
* the host controller
|
||||||
* @reg_hcs - host controller status register value
|
* @reg_hcs - host controller status register value
|
||||||
*
|
*
|
||||||
* Returns 0 if device present, non-zero if no device detected
|
* Returns 1 if device present, 0 if no device detected
|
||||||
*/
|
*/
|
||||||
static inline int ufshcd_is_device_present(u32 reg_hcs)
|
static inline int ufshcd_is_device_present(u32 reg_hcs)
|
||||||
{
|
{
|
||||||
return (DEVICE_PRESENT & reg_hcs) ? 0 : -1;
|
return (DEVICE_PRESENT & reg_hcs) ? 1 : 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@ -911,7 +911,7 @@ static int ufshcd_make_hba_operational(struct ufs_hba *hba)
|
||||||
|
|
||||||
/* check if device present */
|
/* check if device present */
|
||||||
reg = readl((hba->mmio_base + REG_CONTROLLER_STATUS));
|
reg = readl((hba->mmio_base + REG_CONTROLLER_STATUS));
|
||||||
if (ufshcd_is_device_present(reg)) {
|
if (!ufshcd_is_device_present(reg)) {
|
||||||
dev_err(&hba->pdev->dev, "cc: Device not present\n");
|
dev_err(&hba->pdev->dev, "cc: Device not present\n");
|
||||||
err = -ENXIO;
|
err = -ENXIO;
|
||||||
goto out;
|
goto out;
|
||||||
|
|
Reference in a new issue