dect/linux-2.6
Archived
14
0
Fork 0
Code Releases Activity

drm: cdev lock_kernel() pushdown

Browse source 
Signed-off-by: Jonathan Corbet <corbet@lwn.net>
This commit is contained in:
Jonathan Corbet 2008-05-15 11:34:16 -06:00
parent abedd296e9
commit 70ffa16e60
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
drivers/char/drm/drm_fops.c
View file

@ -37,6 +37,7 @@
#include "drmP.h" #include "drmP.h"
#include "drm_sarea.h" #include "drm_sarea.h"
#include <linux/poll.h> #include <linux/poll.h>
#include <linux/smp_lock.h>
static int drm_open_helper(struct inode *inode, struct file *filp, static int drm_open_helper(struct inode *inode, struct file *filp,
struct drm_device * dev); struct drm_device * dev);
@ -174,12 +175,14 @@ int drm_stub_open(struct inode *inode, struct file *filp)
DRM_DEBUG("\n"); DRM_DEBUG("\n");
/* BKL pushdown: note that nothing else serializes idr_find() */
lock_kernel();
minor = idr_find(&drm_minors_idr, minor_id); minor = idr_find(&drm_minors_idr, minor_id);
if (!minor) if (!minor)
return -ENODEV; goto out;
if (!(dev = minor->dev)) if (!(dev = minor->dev))
return -ENODEV; goto out;
old_fops = filp->f_op; old_fops = filp->f_op;
filp->f_op = fops_get(&dev->driver->fops); filp->f_op = fops_get(&dev->driver->fops);
@ -189,6 +192,8 @@ int drm_stub_open(struct inode *inode, struct file *filp)
} }
fops_put(old_fops); fops_put(old_fops);
out:
unlock_kernel();
return err; return err;
} }