dect/linux-2.6
Archived
14
0
Fork 0
Code Releases Activity

perf tools: Fix memory leak in read_ftrace_printk()

Browse source 
get_tracing_file() should be paired with put_tracing_file().

Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
LKML-Reference: <4AB1F48F.4070807@cn.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Li Zefan 2009-09-17 16:34:23 +08:00 committed by Ingo Molnar
parent 40749d0ff4
commit 6706ccf8e7
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
tools/perf/util/trace-event-info.c
View file

@ -458,7 +458,7 @@ static void read_proc_kallsyms(void)
static void read_ftrace_printk(void) static void read_ftrace_printk(void)
{ {
unsigned int size, check_size; unsigned int size, check_size;
const char *path; char *path;
struct stat st; struct stat st;
int ret; int ret;
@ -468,14 +468,15 @@ static void read_ftrace_printk(void)
/* not found */ /* not found */
size = 0; size = 0;
write_or_die(&size, 4); write_or_die(&size, 4);
return; goto out;
} }
size = get_size(path); size = get_size(path);
write_or_die(&size, 4); write_or_die(&size, 4);
check_size = copy_file(path); check_size = copy_file(path);
if (size != check_size) if (size != check_size)
die("error in size of file '%s'", path); die("error in size of file '%s'", path);
out:
put_tracing_file(path);
} }
static struct tracepoint_path * static struct tracepoint_path *