dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

ftrace: binary and not logical for continue test 

Peter Zijlstra provided me with a nice brown paper bag while letting me know
that I was doing a logical AND and not a binary one, making a condition
true more often than it should be.

Luckily, a false true is handled by the calling function and no harm is
done. But this needs to be fixed regardless.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Steven Rostedt 2008-09-03 17:42:50 -04:00 committed by Ingo Molnar
parent a6168353d1
commit 652567aa20
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
kernel/trace/trace.c
View File

@ -1655,7 +1655,7 @@ print_lat_fmt(struct trace_iterator *iter, unsigned int trace_idx, int cpu)
case TRACE_PRINT:
seq_print_ip_sym(s, field->print.ip, sym_flags);
trace_seq_printf(s, ": %s", field->print.buf);
if (field->flags && TRACE_FLAG_CONT)
if (field->flags & TRACE_FLAG_CONT)
trace_seq_print_cont(s, iter);
break;
default:
@ -1768,7 +1768,7 @@ static int print_trace_fmt(struct trace_iterator *iter)
case TRACE_PRINT:
seq_print_ip_sym(s, field->print.ip, sym_flags);
trace_seq_printf(s, ": %s", field->print.buf);
if (field->flags && TRACE_FLAG_CONT)
if (field->flags & TRACE_FLAG_CONT)
trace_seq_print_cont(s, iter);
break;
}
@ -1833,7 +1833,7 @@ static int print_raw_fmt(struct trace_iterator *iter)
case TRACE_PRINT:
trace_seq_printf(s, "# %lx %s",
field->print.ip, field->print.buf);
if (field->flags && TRACE_FLAG_CONT)
if (field->flags & TRACE_FLAG_CONT)
trace_seq_print_cont(s, iter);
break;
}