tg3: Report invalid link from tg3_get_settings()
Currently the tg3 driver leaves the speed and duplex fields uninitialized in tg3_get_settings() if the device is not up. This can lead to some strange deductions in certain versions of ethtool. When the device is up and the link is down, the driver reports SPEED_INVALID and DUPLEX_INVALID for these fields. This patch makes the presentation consistent by returning SPEED_INVALID and DUPLEX_INVALID when the device has not been brought up as well. Signed-off-by: Matt Carlson <mcarlson@broadcom.com> Reviewed-by: Michael Chan <mchan@broadcom.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
parent
4803572815
commit
64c2218266
1 changed files with 3 additions and 0 deletions
|
@ -9807,6 +9807,9 @@ static int tg3_get_settings(struct net_device *dev, struct ethtool_cmd *cmd)
|
|||
if (netif_running(dev)) {
|
||||
cmd->speed = tp->link_config.active_speed;
|
||||
cmd->duplex = tp->link_config.active_duplex;
|
||||
} else {
|
||||
cmd->speed = SPEED_INVALID;
|
||||
cmd->duplex = DUPLEX_INVALID;
|
||||
}
|
||||
cmd->phy_address = tp->phy_addr;
|
||||
cmd->transceiver = XCVR_INTERNAL;
|
||||
|
|
Reference in a new issue