acerhdf: driver didn't verify the pointers in which it got product information
Driver didn't verify the pointers in which it got product information back from DMI; on QEMU one of the pointers came back null, which made the driver crash and subsequently caused a kernel panic. Signed-off-by: Rahul Chaturvedi <rkc@chromium.org> Signed-off-by: Peter Feuerer <peter@piie.net> Cc: Borislav Petkov <petkovbb@gmail.com> Cc: Andreas Mohr <andi@lisas.de> Cc: Len Brown <lenb@kernel.org> Cc: Matthew Garrett <mjg@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Matthew Garrett <mjg@redhat.com>
This commit is contained in:
parent
210183d4af
commit
5cf4c07a28
1 changed files with 4 additions and 0 deletions
|
@ -524,6 +524,10 @@ static int acerhdf_check_hardware(void)
|
|||
version = dmi_get_system_info(DMI_BIOS_VERSION);
|
||||
product = dmi_get_system_info(DMI_PRODUCT_NAME);
|
||||
|
||||
if (!vendor || !version || !product) {
|
||||
pr_err("error getting hardware information\n");
|
||||
return -EINVAL;
|
||||
}
|
||||
|
||||
pr_info("Acer Aspire One Fan driver, v.%s\n", DRV_VER);
|
||||
|
||||
|
|
Reference in a new issue