dect/linux-2.6
Archived
14
0
Fork 0
Code Releases Activity

net: emaclite: Use resource_size

Browse source 
Use the resource_size function instead of manually calculating the
resource size.  This reduces the chance of introducing off-by-one
errors.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Tobias Klauser 2010-05-05 22:12:20 +00:00 committed by David S. Miller
parent 627c8a041f
commit 575400bf5d
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/net/xilinx_emaclite.c
View file

@ -1171,7 +1171,7 @@ static int __devinit xemaclite_of_probe(struct of_device *ofdev,
} }
/* Get the virtual base address for the device */ /* Get the virtual base address for the device */
lp->base_addr = ioremap(r_mem.start, r_mem.end - r_mem.start + 1); lp->base_addr = ioremap(r_mem.start, resource_size(&r_mem));
if (NULL == lp->base_addr) { if (NULL == lp->base_addr) {
dev_err(dev, "EmacLite: Could not allocate iomem\n"); dev_err(dev, "EmacLite: Could not allocate iomem\n");
rc = -EIO; rc = -EIO;
@ -1224,7 +1224,7 @@ static int __devinit xemaclite_of_probe(struct of_device *ofdev,
return 0; return 0;
error1: error1:
release_mem_region(ndev->mem_start, r_mem.end - r_mem.start + 1); release_mem_region(ndev->mem_start, resource_size(&r_mem));
error2: error2:
xemaclite_remove_ndev(ndev); xemaclite_remove_ndev(ndev);