dect/linux-2.6
Archived
14
0
Fork 0
Code Releases Activity

Staging: comedi: s626: Possible read buffer overflow fix

Browse source 
If `cmd->chanlist_len' is 0, then we write ppl[-1].

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Roel Kluin 2009-08-08 00:14:20 +02:00 committed by Greg Kroah-Hartman
parent 88a28c828f
commit 4ff863b1db
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
drivers/staging/comedi/drivers/s626.c
View file

@ -1707,7 +1707,8 @@ static int s626_ai_load_polllist(uint8_t * ppl, struct comedi_cmd *cmd)
else
ppl[n] = (CR_CHAN((cmd->chanlist)[n])) | (RANGE_10V);
}
ppl[n - 1] |= EOPL;
if (n != 0)
ppl[n - 1] |= EOPL;
return n;
}