dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

igb: don't read eicr when responding to legacy interrupts 

The interrupt handler was reading eicr and then doing nothing with the
result.  I have removed the variable and the register read since they
provide no value to the legacy interrupt handler.

Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Alexander Duyck 2009-02-06 23:20:49 +00:00 committed by David S. Miller
parent 28b0759c22
commit 4a3c6433e4
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
drivers/net/igb/igb_main.c
View File

@ -3519,7 +3519,7 @@ static irqreturn_t igb_intr_msi(int irq, void *data)
}
/**
* igb_intr - Interrupt Handler
* igb_intr - Legacy Interrupt Handler
* @irq: interrupt number
* @data: pointer to a network interface device structure
**/
@ -3531,7 +3531,6 @@ static irqreturn_t igb_intr(int irq, void *data)
/* Interrupt Auto-Mask...upon reading ICR, interrupts are masked. No
* need for the IMC write */
u32 icr = rd32(E1000_ICR);
u32 eicr = 0;
if (!icr)
return IRQ_NONE; /* Not our interrupt */
@ -3547,8 +3546,6 @@ static irqreturn_t igb_intr(int irq, void *data)
adapter->stats.doosync++;
}
eicr = rd32(E1000_EICR);
if (icr & (E1000_ICR_RXSEQ | E1000_ICR_LSC)) {
hw->mac.get_link_status = 1;
/* guard against interrupt when we're going down */