dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

USB: input: keyspan_remote.c: fix up dev_err() usage 

We should always reference the input device for dev_err(), not the USB
device.  Fix up the places where I got this wrong.

Reported-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Greg Kroah-Hartman 2012-05-01 20:56:41 -04:00
parent 388fd20266
commit 3b449fe5d5
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
drivers/input/misc/keyspan_remote.c
View File

@ -267,7 +267,7 @@ static void keyspan_check_data(struct usb_keyspan *remote)
remote->data.tester = remote->data.tester >> 6;
remote->data.bits_left -= 6;
} else {
dev_err(&remote->udev->dev,
dev_err(&remote->input->dev,
"%s - Unknown sequence found in system data.\n",
__func__);
remote->stage = 0;
@ -288,7 +288,7 @@ static void keyspan_check_data(struct usb_keyspan *remote)
remote->data.tester = remote->data.tester >> 6;
remote->data.bits_left -= 6;
} else {
dev_err(&remote->udev->dev,
dev_err(&remote->input->dev,
"%s - Unknown sequence found in button data.\n",
__func__);
remote->stage = 0;
@ -306,7 +306,7 @@ static void keyspan_check_data(struct usb_keyspan *remote)
remote->data.tester = remote->data.tester >> 6;
remote->data.bits_left -= 6;
} else {
dev_err(&remote->udev->dev,
dev_err(&remote->input->dev,
"%s - Error in message, invalid toggle.\n",
__func__);
remote->stage = 0;
@ -318,7 +318,7 @@ static void keyspan_check_data(struct usb_keyspan *remote)
remote->data.tester = remote->data.tester >> 5;
remote->data.bits_left -= 5;
} else {
dev_err(&remote->udev->dev,
dev_err(&remote->input->dev,
"Bad message received, no stop bit found.\n");
}
@ -404,7 +404,7 @@ static void keyspan_irq_recv(struct urb *urb)
resubmit:
retval = usb_submit_urb(urb, GFP_ATOMIC);
if (retval)
dev_err(&dev->udev->dev,
dev_err(&dev->input->dev,
"%s - usb_submit_urb failed with result: %d\n",
__func__, retval);
}