dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

IB/srpt: Fix ERR_PTR() vs. NULL checking confusion 

transport_init_session() and target_fabric_configfs_init() don't
return NULL pointers, they only return ERR_PTRs or valid pointers.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
This commit is contained in:
Dan Carpenter 2011-11-04 21:27:32 +03:00 committed by Roland Dreier
parent ebfded8c4b
commit 3af336376f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/infiniband/ulp/srpt/ib_srpt.c
View File

@ -2595,7 +2595,7 @@ static int srpt_cm_req_recv(struct ib_cm_id *cm_id,
}
ch->sess = transport_init_session();
if (!ch->sess) {
if (IS_ERR(ch->sess)) {
rej->reason = __constant_cpu_to_be32(
SRP_LOGIN_REJ_INSUFFICIENT_RESOURCES);
pr_debug("Failed to create session\n");
@ -4009,10 +4009,10 @@ static int __init srpt_init_module(void)
goto out;
}
ret = -ENODEV;
srpt_target = target_fabric_configfs_init(THIS_MODULE, "srpt");
if (!srpt_target) {
if (IS_ERR(srpt_target)) {
printk(KERN_ERR "couldn't register\n");
ret = PTR_ERR(srpt_target);
goto out;
}