dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

x86: Eliminate redundant/contradicting cache line size config options 

Rather than having X86_L1_CACHE_BYTES and X86_L1_CACHE_SHIFT
(with inconsistent defaults), just having the latter suffices as
the former can be easily calculated from it.

To be consistent, also change X86_INTERNODE_CACHE_BYTES to
X86_INTERNODE_CACHE_SHIFT, and set it to 7 (128 bytes) for NUMA
to account for last level cache line size (which here matters
more than L1 cache line size).

Finally, make sure the default value for X86_L1_CACHE_SHIFT,
when X86_GENERIC is selected, is being seen before that for the
individual CPU model options (other than on x86-64, where
GENERIC_CPU is part of the choice construct, X86_GENERIC is a
separate option on ix86).

Signed-off-by: Jan Beulich <jbeulich@novell.com>
Acked-by: Ravikiran Thirumalai <kiran@scalex86.org>
Acked-by: Nick Piggin <npiggin@suse.de>
LKML-Reference: <4AFD5710020000780001F8F0@vpn.id2.novell.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
This commit is contained in:
Jan Beulich 2009-11-13 11:54:40 +00:00 committed by Ingo Molnar
parent 508d85c2c6
commit 350f8f5631
5 changed files with 18 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
arch/x86/Kconfig.cpu
View File

@ -301,15 +301,11 @@ config X86_CPU
# #
# Define implied options from the CPU selection here # Define implied options from the CPU selection here
config X86_L1_CACHE_BYTES config X86_INTERNODE_CACHE_SHIFT
int int
default "128" if MPSC default "12" if X86_VSMP
default "64" if GENERIC_CPU || MK8 || MCORE2 || MATOM || X86_32 default "7" if NUMA
default X86_L1_CACHE_SHIFT
config X86_INTERNODE_CACHE_BYTES
int
default "4096" if X86_VSMP
default X86_L1_CACHE_BYTES if !X86_VSMP
config X86_CMPXCHG config X86_CMPXCHG
def_bool X86_64 || (X86_32 && !M386) def_bool X86_64 || (X86_32 && !M386)
@ -317,9 +313,9 @@ config X86_CMPXCHG
config X86_L1_CACHE_SHIFT config X86_L1_CACHE_SHIFT
int int
default "7" if MPENTIUM4 || MPSC default "7" if MPENTIUM4 || MPSC
default "6" if MK7 || MK8 || MPENTIUMM || MCORE2 || MATOM || MVIAC7 || X86_GENERIC || GENERIC_CPU
default "4" if X86_ELAN || M486 || M386 || MGEODEGX1 default "4" if X86_ELAN || M486 || M386 || MGEODEGX1
default "5" if MWINCHIP3D || MWINCHIPC6 || MCRUSOE || MEFFICEON || MCYRIXIII || MK6 || MPENTIUMIII || MPENTIUMII || M686 || M586MMX || M586TSC || M586 || MVIAC3_2 || MGEODE_LX default "5" if MWINCHIP3D || MWINCHIPC6 || MCRUSOE || MEFFICEON || MCYRIXIII || MK6 || MPENTIUMIII || MPENTIUMII || M686 || M586MMX || M586TSC || M586 || MVIAC3_2 || MGEODE_LX
default "6" if MK7 || MK8 || MPENTIUMM || MCORE2 || MATOM || MVIAC7 || X86_GENERIC || GENERIC_CPU
config X86_XADD config X86_XADD
def_bool y def_bool y

3
arch/x86/boot/compressed/vmlinux.lds.S
View File

@ -4,6 +4,7 @@ OUTPUT_FORMAT(CONFIG_OUTPUT_FORMAT, CONFIG_OUTPUT_FORMAT, CONFIG_OUTPUT_FORMAT)
#undef i386 #undef i386
#include <asm/cache.h>
#include <asm/page_types.h> #include <asm/page_types.h>
#ifdef CONFIG_X86_64 #ifdef CONFIG_X86_64
@ -46,7 +47,7 @@ SECTIONS
*(.data.*) *(.data.*)
_edata = . ; _edata = . ;
} }
. = ALIGN(CONFIG_X86_L1_CACHE_BYTES); . = ALIGN(L1_CACHE_BYTES);
.bss : { .bss : {
_bss = . ; _bss = . ;
*(.bss) *(.bss)

7
arch/x86/include/asm/cache.h
View File

@ -9,12 +9,13 @@
#define __read_mostly __attribute__((__section__(".data.read_mostly"))) #define __read_mostly __attribute__((__section__(".data.read_mostly")))
#define INTERNODE_CACHE_SHIFT CONFIG_X86_INTERNODE_CACHE_SHIFT
#define INTERNODE_CACHE_BYTES (1 << INTERNODE_CACHE_SHIFT)
#ifdef CONFIG_X86_VSMP #ifdef CONFIG_X86_VSMP
/* vSMP Internode cacheline shift */
#define INTERNODE_CACHE_SHIFT (12)
#ifdef CONFIG_SMP #ifdef CONFIG_SMP
#define __cacheline_aligned_in_smp \ #define __cacheline_aligned_in_smp \
__attribute__((__aligned__(1 << (INTERNODE_CACHE_SHIFT)))) \ __attribute__((__aligned__(INTERNODE_CACHE_BYTES))) \
__page_aligned_data __page_aligned_data
#endif #endif
#endif #endif

10
arch/x86/kernel/vmlinux.lds.S
View File

@ -135,13 +135,13 @@ SECTIONS
PAGE_ALIGNED_DATA(PAGE_SIZE) PAGE_ALIGNED_DATA(PAGE_SIZE)
CACHELINE_ALIGNED_DATA(CONFIG_X86_L1_CACHE_BYTES) CACHELINE_ALIGNED_DATA(L1_CACHE_BYTES)
DATA_DATA DATA_DATA
CONSTRUCTORS CONSTRUCTORS
/* rarely changed data like cpu maps */ /* rarely changed data like cpu maps */
READ_MOSTLY_DATA(CONFIG_X86_INTERNODE_CACHE_BYTES) READ_MOSTLY_DATA(INTERNODE_CACHE_BYTES)
/* End of data section */ /* End of data section */
_edata = .; _edata = .;
@ -165,12 +165,12 @@ SECTIONS
*(.vsyscall_0) *(.vsyscall_0)
} :user } :user
. = ALIGN(CONFIG_X86_L1_CACHE_BYTES); . = ALIGN(L1_CACHE_BYTES);
.vsyscall_fn : AT(VLOAD(.vsyscall_fn)) { .vsyscall_fn : AT(VLOAD(.vsyscall_fn)) {
*(.vsyscall_fn) *(.vsyscall_fn)
} }
. = ALIGN(CONFIG_X86_L1_CACHE_BYTES); . = ALIGN(L1_CACHE_BYTES);
.vsyscall_gtod_data : AT(VLOAD(.vsyscall_gtod_data)) { .vsyscall_gtod_data : AT(VLOAD(.vsyscall_gtod_data)) {
*(.vsyscall_gtod_data) *(.vsyscall_gtod_data)
} }
@ -194,7 +194,7 @@ SECTIONS
} }
vgetcpu_mode = VVIRT(.vgetcpu_mode); vgetcpu_mode = VVIRT(.vgetcpu_mode);
. = ALIGN(CONFIG_X86_L1_CACHE_BYTES); . = ALIGN(L1_CACHE_BYTES);
.jiffies : AT(VLOAD(.jiffies)) { .jiffies : AT(VLOAD(.jiffies)) {
*(.jiffies) *(.jiffies)
} }

3
arch/x86/mm/tlb.c
View File

@ -8,6 +8,7 @@
#include <asm/tlbflush.h> #include <asm/tlbflush.h>
#include <asm/mmu_context.h> #include <asm/mmu_context.h>
#include <asm/cache.h>
#include <asm/apic.h> #include <asm/apic.h>
#include <asm/uv/uv.h> #include <asm/uv/uv.h>
@ -43,7 +44,7 @@ union smp_flush_state {
spinlock_t tlbstate_lock; spinlock_t tlbstate_lock;
DECLARE_BITMAP(flush_cpumask, NR_CPUS); DECLARE_BITMAP(flush_cpumask, NR_CPUS);
}; };
char pad[CONFIG_X86_INTERNODE_CACHE_BYTES]; char pad[INTERNODE_CACHE_BYTES];
} ____cacheline_internodealigned_in_smp; } ____cacheline_internodealigned_in_smp;
/* State is put into the per CPU data section, but padded /* State is put into the per CPU data section, but padded