dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

Btrfs: fix error handling in __add_reloc_root() 

We dereferenced "node" in the error message after freeing it.  Also
btrfs_panic() can return so we should return an error code instead of
continuing.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
This commit is contained in:
Dan Carpenter 2012-06-25 05:15:23 -06:00 committed by Chris Mason
parent 44c44af2f4
commit 23291a044c
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
fs/btrfs/relocation.c
View File

@ -1239,10 +1239,11 @@ static int __must_check __add_reloc_root(struct btrfs_root *root)
node->bytenr, &node->rb_node);
spin_unlock(&rc->reloc_root_tree.lock);
if (rb_node) {
kfree(node);
btrfs_panic(root->fs_info, -EEXIST, "Duplicate root found "
"for start=%llu while inserting into relocation "
"tree\n");
kfree(node);
return -EEXIST;
}
list_add_tail(&root->root_list, &rc->reloc_roots);