dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

arch/arm/plat-omap: Drop an unnecessary NULL test 

map_iovm_area is only called from a context where its second argument is
known not to be NULL, so drop the unnecessary test.  If new could be NULL,
the initialization of da should be moved below the test.

A simplified version of the semantic match that detects this problem is as
follows (http://coccinelle.lip6.fr/):

// <smpl>
@match exists@
expression x, E;
identifier fld;
@@

* x->fld
  ... when != \(x = E\|&x\)
* x == NULL
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Russell King <linux@arm.linux.org.uk>
Cc: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Julia Lawall 2009-11-22 10:11:16 -08:00 committed by Tony Lindgren
parent 13a0322957
commit 20e11c2d1c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
arch/arm/plat-omap/iovmm.c
View File

@ -446,7 +446,7 @@ static int map_iovm_area(struct iommu *obj, struct iovm_struct *new,
struct scatterlist *sg;
u32 da = new->da_start;
if (!obj || !new || !sgt)
if (!obj || !sgt)
return -EINVAL;
BUG_ON(!sgtable_ok(sgt));