dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

x86: fix early_ioremap() on 64-bit 

Fix early_ioremap() on x86-64

I had ACPI failures on several machines since a few days. Symptom
was NUMA nodes not getting detected or worse cores not getting detected.
They all came from ACPI not being able to read various of its tables. I finally
bisected it down to Jeremy's "put _PAGE_GLOBAL into PAGE_KERNEL" change.
With that the fix was fairly obvious. The problem was that early_ioremap()
didn't use a "_all" flush that would affect the global PTEs too. So
with global bits getting used everywhere now an early_ioremap would
not actually flush a mapping if something else was mapped previously
on that slot (which can happen with early_iounmap inbetween)

This patch changes all flushes in init_64.c to be __flush_tlb_all()
and fixes the problem here.

Signed-off-by: Andi Kleen <ak@suse.de>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
This commit is contained in:
Andi Kleen 2008-01-30 13:33:54 +01:00 committed by Ingo Molnar
parent 934d15854d
commit 1a2b441231
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
arch/x86/mm/init_64.c
View File

@ -228,7 +228,7 @@ __meminit void *early_ioremap(unsigned long addr, unsigned long size)
addr &= PMD_MASK;
for (i = 0; i < pmds; i++, addr += PMD_SIZE)
set_pmd(pmd+i, __pmd(addr | __PAGE_KERNEL_LARGE_EXEC));
__flush_tlb();
__flush_tlb_all();
return (void *)vaddr;
next:
;
@ -249,7 +249,7 @@ __meminit void early_iounmap(void *addr, unsigned long size)
pmd = level2_kernel_pgt + pmd_index(vaddr);
for (i = 0; i < pmds; i++)
pmd_clear(pmd + i);
__flush_tlb();
__flush_tlb_all();
}
static void __meminit
@ -317,7 +317,7 @@ static void __meminit phys_pud_init(pud_t *pud_page, unsigned long addr, unsigne
spin_unlock(&init_mm.page_table_lock);
unmap_low_page(pmd);
}
__flush_tlb();
__flush_tlb_all();
}
static void __init find_early_table_space(unsigned long end)