dect/linux-2.6
Archived
14
0
Fork 0
Code Releases Activity

Staging: wlan-ng: p80211wext.c: problem with IW_ENCODE_ALG_WEP

Browse source 
The expression !(ext->alg & IW_ENCODE_ALG_WEP) appears to be incorrect,
because there are several possible values for ext->alg that give 1 when
bit-anded with IW_ENCODE_ALG_WEP.  Therefore Richard Kennedy suggested to
rewrite the code with !=

Added \n at the end of the debug string as well.

Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
Julia Lawall 2009-05-05 15:47:06 +02:00 committed by Greg Kroah-Hartman
parent f2b50b40d1
commit 1611a52c39
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/staging/wlan-ng/p80211wext.c
View file

@ -1487,8 +1487,8 @@ static int p80211wext_set_encodeext(struct net_device *dev,
}
if (ext->ext_flags & IW_ENCODE_EXT_SET_TX_KEY) {
if (!(ext->alg & IW_ENCODE_ALG_WEP)) {
pr_debug("asked to set a non wep key :(");
if (ext->alg != IW_ENCODE_ALG_WEP) {
pr_debug("asked to set a non wep key :(\n");
return -EINVAL;
}
if (idx) {