dect
/
linux-2.6
Archived
13
0
Fork 0
Code Releases Activity

[media] saa7164: make buffer smaller 

This isn't a runtime bug, it's just to make static checkers happy.

In vidioc_querycap() we copy a saa7164_dev ->name driver array into a
v4l2_capability -> driver array.  The ->driver array is only 16 chars
long so ->name also can't be more than 16 characters.

The ->name gets set in v4l2_capability() and it always is less than 16
characters so we can easily make the buffer smaller.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
This commit is contained in:
Dan Carpenter 2010-11-02 00:22:23 -03:00 committed by Mauro Carvalho Chehab
parent 76e4a9a716
commit 0e72cc8b8d
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/media/video/saa7164/saa7164-core.c
View File

@ -1001,7 +1001,7 @@ static int saa7164_dev_setup(struct saa7164_dev *dev)
atomic_inc(&dev->refcount);
dev->nr = saa7164_devcount++;
sprintf(dev->name, "saa7164[%d]", dev->nr);
snprintf(dev->name, sizeof(dev->name), "saa7164[%d]", dev->nr);
mutex_lock(&devlist);
list_add_tail(&dev->devlist, &saa7164_devlist);

2
drivers/media/video/saa7164/saa7164.h
View File

@ -447,7 +447,7 @@ struct saa7164_dev {
int nr;
int hwrevision;
u32 board;
char name[32];
char name[16];
/* firmware status */
struct saa7164_fw_status fw_status;