2009-11-02 23:53:02 +00:00
|
|
|
/*
|
|
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
|
|
* to deal in the Software without restriction, including without limitation
|
|
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
|
|
*
|
|
|
|
* The above copyright notice and this permission notice shall be included in
|
|
|
|
* all copies or substantial portions of the Software.
|
|
|
|
*
|
|
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
|
|
* THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
|
|
|
|
* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
|
|
|
|
* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
*
|
|
|
|
* Authors: Rafał Miłecki <zajec5@gmail.com>
|
2009-12-28 18:58:44 +00:00
|
|
|
* Alex Deucher <alexdeucher@gmail.com>
|
2009-11-02 23:53:02 +00:00
|
|
|
*/
|
|
|
|
#include "drmP.h"
|
|
|
|
#include "radeon.h"
|
2010-02-18 05:58:36 +00:00
|
|
|
#include "avivod.h"
|
2010-05-07 19:10:16 +00:00
|
|
|
#ifdef CONFIG_ACPI
|
|
|
|
#include <linux/acpi.h>
|
|
|
|
#endif
|
|
|
|
#include <linux/power_supply.h>
|
2010-07-02 16:58:16 +00:00
|
|
|
#include <linux/hwmon.h>
|
|
|
|
#include <linux/hwmon-sysfs.h>
|
2009-11-02 23:53:02 +00:00
|
|
|
|
2009-12-22 22:02:16 +00:00
|
|
|
#define RADEON_IDLE_LOOP_MS 100
|
|
|
|
#define RADEON_RECLOCK_DELAY_MS 200
|
2010-01-07 23:22:47 +00:00
|
|
|
#define RADEON_WAIT_VBLANK_TIMEOUT 200
|
2010-04-22 16:52:11 +00:00
|
|
|
#define RADEON_WAIT_IDLE_TIMEOUT 200
|
2009-12-22 22:02:16 +00:00
|
|
|
|
2010-06-07 22:29:44 +00:00
|
|
|
static const char *radeon_pm_state_type_name[5] = {
|
|
|
|
"Default",
|
|
|
|
"Powersave",
|
|
|
|
"Battery",
|
|
|
|
"Balanced",
|
|
|
|
"Performance",
|
|
|
|
};
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
static void radeon_dynpm_idle_work_handler(struct work_struct *work);
|
2009-12-22 22:02:16 +00:00
|
|
|
static int radeon_debugfs_pm_init(struct radeon_device *rdev);
|
2010-05-07 19:10:16 +00:00
|
|
|
static bool radeon_pm_in_vbl(struct radeon_device *rdev);
|
|
|
|
static bool radeon_pm_debug_check_in_vbl(struct radeon_device *rdev, bool finish);
|
|
|
|
static void radeon_pm_update_profile(struct radeon_device *rdev);
|
|
|
|
static void radeon_pm_set_clocks(struct radeon_device *rdev);
|
|
|
|
|
|
|
|
#define ACPI_AC_CLASS "ac_adapter"
|
|
|
|
|
|
|
|
#ifdef CONFIG_ACPI
|
|
|
|
static int radeon_acpi_event(struct notifier_block *nb,
|
|
|
|
unsigned long val,
|
|
|
|
void *data)
|
|
|
|
{
|
|
|
|
struct radeon_device *rdev = container_of(nb, struct radeon_device, acpi_nb);
|
|
|
|
struct acpi_bus_event *entry = (struct acpi_bus_event *)data;
|
|
|
|
|
|
|
|
if (strcmp(entry->device_class, ACPI_AC_CLASS) == 0) {
|
|
|
|
if (power_supply_is_system_supplied() > 0)
|
2010-08-02 00:42:55 +00:00
|
|
|
DRM_DEBUG_DRIVER("pm: AC\n");
|
2010-05-07 19:10:16 +00:00
|
|
|
else
|
2010-08-02 00:42:55 +00:00
|
|
|
DRM_DEBUG_DRIVER("pm: DC\n");
|
2010-05-07 19:10:16 +00:00
|
|
|
|
|
|
|
if (rdev->pm.pm_method == PM_METHOD_PROFILE) {
|
|
|
|
if (rdev->pm.profile == PM_PROFILE_AUTO) {
|
|
|
|
mutex_lock(&rdev->pm.mutex);
|
|
|
|
radeon_pm_update_profile(rdev);
|
|
|
|
radeon_pm_set_clocks(rdev);
|
|
|
|
mutex_unlock(&rdev->pm.mutex);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return NOTIFY_OK;
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
static void radeon_pm_update_profile(struct radeon_device *rdev)
|
|
|
|
{
|
|
|
|
switch (rdev->pm.profile) {
|
|
|
|
case PM_PROFILE_DEFAULT:
|
|
|
|
rdev->pm.profile_index = PM_PROFILE_DEFAULT_IDX;
|
|
|
|
break;
|
|
|
|
case PM_PROFILE_AUTO:
|
|
|
|
if (power_supply_is_system_supplied() > 0) {
|
|
|
|
if (rdev->pm.active_crtc_count > 1)
|
|
|
|
rdev->pm.profile_index = PM_PROFILE_HIGH_MH_IDX;
|
|
|
|
else
|
|
|
|
rdev->pm.profile_index = PM_PROFILE_HIGH_SH_IDX;
|
|
|
|
} else {
|
|
|
|
if (rdev->pm.active_crtc_count > 1)
|
2010-06-02 21:56:01 +00:00
|
|
|
rdev->pm.profile_index = PM_PROFILE_MID_MH_IDX;
|
2010-05-07 19:10:16 +00:00
|
|
|
else
|
2010-06-02 21:56:01 +00:00
|
|
|
rdev->pm.profile_index = PM_PROFILE_MID_SH_IDX;
|
2010-05-07 19:10:16 +00:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
case PM_PROFILE_LOW:
|
|
|
|
if (rdev->pm.active_crtc_count > 1)
|
|
|
|
rdev->pm.profile_index = PM_PROFILE_LOW_MH_IDX;
|
|
|
|
else
|
|
|
|
rdev->pm.profile_index = PM_PROFILE_LOW_SH_IDX;
|
|
|
|
break;
|
2010-06-02 21:56:01 +00:00
|
|
|
case PM_PROFILE_MID:
|
|
|
|
if (rdev->pm.active_crtc_count > 1)
|
|
|
|
rdev->pm.profile_index = PM_PROFILE_MID_MH_IDX;
|
|
|
|
else
|
|
|
|
rdev->pm.profile_index = PM_PROFILE_MID_SH_IDX;
|
|
|
|
break;
|
2010-05-07 19:10:16 +00:00
|
|
|
case PM_PROFILE_HIGH:
|
|
|
|
if (rdev->pm.active_crtc_count > 1)
|
|
|
|
rdev->pm.profile_index = PM_PROFILE_HIGH_MH_IDX;
|
|
|
|
else
|
|
|
|
rdev->pm.profile_index = PM_PROFILE_HIGH_SH_IDX;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (rdev->pm.active_crtc_count == 0) {
|
|
|
|
rdev->pm.requested_power_state_index =
|
|
|
|
rdev->pm.profiles[rdev->pm.profile_index].dpms_off_ps_idx;
|
|
|
|
rdev->pm.requested_clock_mode_index =
|
|
|
|
rdev->pm.profiles[rdev->pm.profile_index].dpms_off_cm_idx;
|
|
|
|
} else {
|
|
|
|
rdev->pm.requested_power_state_index =
|
|
|
|
rdev->pm.profiles[rdev->pm.profile_index].dpms_on_ps_idx;
|
|
|
|
rdev->pm.requested_clock_mode_index =
|
|
|
|
rdev->pm.profiles[rdev->pm.profile_index].dpms_on_cm_idx;
|
|
|
|
}
|
|
|
|
}
|
2009-12-22 22:02:16 +00:00
|
|
|
|
2010-04-26 19:52:20 +00:00
|
|
|
static void radeon_unmap_vram_bos(struct radeon_device *rdev)
|
|
|
|
{
|
|
|
|
struct radeon_bo *bo, *n;
|
|
|
|
|
|
|
|
if (list_empty(&rdev->gem.objects))
|
|
|
|
return;
|
|
|
|
|
|
|
|
list_for_each_entry_safe(bo, n, &rdev->gem.objects, list) {
|
|
|
|
if (bo->tbo.mem.mem_type == TTM_PL_VRAM)
|
|
|
|
ttm_bo_unmap_virtual(&bo->tbo);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
static void radeon_sync_with_vblank(struct radeon_device *rdev)
|
2010-04-24 18:50:23 +00:00
|
|
|
{
|
2010-05-07 19:10:16 +00:00
|
|
|
if (rdev->pm.active_crtcs) {
|
|
|
|
rdev->pm.vblank_sync = false;
|
|
|
|
wait_event_timeout(
|
|
|
|
rdev->irq.vblank_queue, rdev->pm.vblank_sync,
|
|
|
|
msecs_to_jiffies(RADEON_WAIT_VBLANK_TIMEOUT));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void radeon_set_power_state(struct radeon_device *rdev)
|
|
|
|
{
|
|
|
|
u32 sclk, mclk;
|
2010-05-27 21:01:41 +00:00
|
|
|
bool misc_after = false;
|
2010-05-07 19:10:16 +00:00
|
|
|
|
|
|
|
if ((rdev->pm.requested_clock_mode_index == rdev->pm.current_clock_mode_index) &&
|
|
|
|
(rdev->pm.requested_power_state_index == rdev->pm.current_power_state_index))
|
|
|
|
return;
|
|
|
|
|
|
|
|
if (radeon_gui_idle(rdev)) {
|
|
|
|
sclk = rdev->pm.power_state[rdev->pm.requested_power_state_index].
|
|
|
|
clock_info[rdev->pm.requested_clock_mode_index].sclk;
|
|
|
|
if (sclk > rdev->clock.default_sclk)
|
|
|
|
sclk = rdev->clock.default_sclk;
|
|
|
|
|
|
|
|
mclk = rdev->pm.power_state[rdev->pm.requested_power_state_index].
|
|
|
|
clock_info[rdev->pm.requested_clock_mode_index].mclk;
|
|
|
|
if (mclk > rdev->clock.default_mclk)
|
|
|
|
mclk = rdev->clock.default_mclk;
|
|
|
|
|
2010-05-27 21:01:41 +00:00
|
|
|
/* upvolt before raising clocks, downvolt after lowering clocks */
|
|
|
|
if (sclk < rdev->pm.current_sclk)
|
|
|
|
misc_after = true;
|
2010-05-07 19:10:16 +00:00
|
|
|
|
2010-05-27 21:01:41 +00:00
|
|
|
radeon_sync_with_vblank(rdev);
|
2010-05-07 19:10:16 +00:00
|
|
|
|
2010-05-27 21:01:41 +00:00
|
|
|
if (rdev->pm.pm_method == PM_METHOD_DYNPM) {
|
2010-05-07 19:10:16 +00:00
|
|
|
if (!radeon_pm_in_vbl(rdev))
|
|
|
|
return;
|
2010-05-27 21:01:41 +00:00
|
|
|
}
|
2010-05-07 19:10:16 +00:00
|
|
|
|
2010-05-27 21:01:41 +00:00
|
|
|
radeon_pm_prepare(rdev);
|
2010-05-07 19:10:16 +00:00
|
|
|
|
2010-05-27 21:01:41 +00:00
|
|
|
if (!misc_after)
|
|
|
|
/* voltage, pcie lanes, etc.*/
|
|
|
|
radeon_pm_misc(rdev);
|
|
|
|
|
|
|
|
/* set engine clock */
|
|
|
|
if (sclk != rdev->pm.current_sclk) {
|
|
|
|
radeon_pm_debug_check_in_vbl(rdev, false);
|
|
|
|
radeon_set_engine_clock(rdev, sclk);
|
|
|
|
radeon_pm_debug_check_in_vbl(rdev, true);
|
|
|
|
rdev->pm.current_sclk = sclk;
|
2010-08-02 00:42:55 +00:00
|
|
|
DRM_DEBUG_DRIVER("Setting: e: %d\n", sclk);
|
2010-05-27 21:01:41 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/* set memory clock */
|
|
|
|
if (rdev->asic->set_memory_clock && (mclk != rdev->pm.current_mclk)) {
|
|
|
|
radeon_pm_debug_check_in_vbl(rdev, false);
|
|
|
|
radeon_set_memory_clock(rdev, mclk);
|
|
|
|
radeon_pm_debug_check_in_vbl(rdev, true);
|
|
|
|
rdev->pm.current_mclk = mclk;
|
2010-08-02 00:42:55 +00:00
|
|
|
DRM_DEBUG_DRIVER("Setting: m: %d\n", mclk);
|
2010-05-07 19:10:16 +00:00
|
|
|
}
|
2010-04-26 19:45:23 +00:00
|
|
|
|
2010-05-27 21:01:41 +00:00
|
|
|
if (misc_after)
|
|
|
|
/* voltage, pcie lanes, etc.*/
|
|
|
|
radeon_pm_misc(rdev);
|
|
|
|
|
|
|
|
radeon_pm_finish(rdev);
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
rdev->pm.current_power_state_index = rdev->pm.requested_power_state_index;
|
|
|
|
rdev->pm.current_clock_mode_index = rdev->pm.requested_clock_mode_index;
|
|
|
|
} else
|
2010-08-02 00:42:55 +00:00
|
|
|
DRM_DEBUG_DRIVER("pm: GUI not idle!!!\n");
|
2010-05-07 19:10:16 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void radeon_pm_set_clocks(struct radeon_device *rdev)
|
|
|
|
{
|
|
|
|
int i;
|
2010-04-27 17:58:46 +00:00
|
|
|
|
2010-04-27 21:16:58 +00:00
|
|
|
mutex_lock(&rdev->ddev->struct_mutex);
|
|
|
|
mutex_lock(&rdev->vram_mutex);
|
2010-04-24 18:50:23 +00:00
|
|
|
mutex_lock(&rdev->cp.mutex);
|
2010-04-29 20:14:02 +00:00
|
|
|
|
|
|
|
/* gui idle int has issues on older chips it seems */
|
|
|
|
if (rdev->family >= CHIP_R600) {
|
2010-05-07 19:10:16 +00:00
|
|
|
if (rdev->irq.installed) {
|
|
|
|
/* wait for GPU idle */
|
|
|
|
rdev->pm.gui_idle = false;
|
|
|
|
rdev->irq.gui_idle = true;
|
|
|
|
radeon_irq_set(rdev);
|
|
|
|
wait_event_interruptible_timeout(
|
|
|
|
rdev->irq.idle_queue, rdev->pm.gui_idle,
|
|
|
|
msecs_to_jiffies(RADEON_WAIT_IDLE_TIMEOUT));
|
|
|
|
rdev->irq.gui_idle = false;
|
|
|
|
radeon_irq_set(rdev);
|
|
|
|
}
|
2010-04-30 19:48:23 +00:00
|
|
|
} else {
|
2010-05-07 19:10:16 +00:00
|
|
|
if (rdev->cp.ready) {
|
|
|
|
struct radeon_fence *fence;
|
|
|
|
radeon_ring_alloc(rdev, 64);
|
|
|
|
radeon_fence_create(rdev, &fence);
|
|
|
|
radeon_fence_emit(rdev, fence);
|
|
|
|
radeon_ring_commit(rdev);
|
|
|
|
radeon_fence_wait(fence, false);
|
|
|
|
radeon_fence_unref(&fence);
|
|
|
|
}
|
2010-04-29 20:14:02 +00:00
|
|
|
}
|
2010-04-26 19:52:20 +00:00
|
|
|
radeon_unmap_vram_bos(rdev);
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
if (rdev->irq.installed) {
|
2010-04-26 19:45:23 +00:00
|
|
|
for (i = 0; i < rdev->num_crtc; i++) {
|
|
|
|
if (rdev->pm.active_crtcs & (1 << i)) {
|
|
|
|
rdev->pm.req_vblank |= (1 << i);
|
|
|
|
drm_vblank_get(rdev->ddev, i);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2010-04-29 04:22:43 +00:00
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
radeon_set_power_state(rdev);
|
2010-04-26 19:45:23 +00:00
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
if (rdev->irq.installed) {
|
2010-04-26 19:45:23 +00:00
|
|
|
for (i = 0; i < rdev->num_crtc; i++) {
|
|
|
|
if (rdev->pm.req_vblank & (1 << i)) {
|
|
|
|
rdev->pm.req_vblank &= ~(1 << i);
|
|
|
|
drm_vblank_put(rdev->ddev, i);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2010-04-26 19:52:20 +00:00
|
|
|
|
2010-04-24 18:50:23 +00:00
|
|
|
/* update display watermarks based on new power state */
|
|
|
|
radeon_update_bandwidth_info(rdev);
|
|
|
|
if (rdev->pm.active_crtc_count)
|
|
|
|
radeon_bandwidth_update(rdev);
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
rdev->pm.dynpm_planned_action = DYNPM_ACTION_NONE;
|
2010-04-26 19:45:23 +00:00
|
|
|
|
2010-04-24 18:50:23 +00:00
|
|
|
mutex_unlock(&rdev->cp.mutex);
|
2010-04-27 21:16:58 +00:00
|
|
|
mutex_unlock(&rdev->vram_mutex);
|
|
|
|
mutex_unlock(&rdev->ddev->struct_mutex);
|
2010-04-24 18:50:23 +00:00
|
|
|
}
|
|
|
|
|
2010-06-07 22:29:44 +00:00
|
|
|
static void radeon_pm_print_states(struct radeon_device *rdev)
|
|
|
|
{
|
|
|
|
int i, j;
|
|
|
|
struct radeon_power_state *power_state;
|
|
|
|
struct radeon_pm_clock_info *clock_info;
|
|
|
|
|
2010-08-02 00:42:55 +00:00
|
|
|
DRM_DEBUG_DRIVER("%d Power State(s)\n", rdev->pm.num_power_states);
|
2010-06-07 22:29:44 +00:00
|
|
|
for (i = 0; i < rdev->pm.num_power_states; i++) {
|
|
|
|
power_state = &rdev->pm.power_state[i];
|
2010-08-02 00:42:55 +00:00
|
|
|
DRM_DEBUG_DRIVER("State %d: %s\n", i,
|
2010-06-07 22:29:44 +00:00
|
|
|
radeon_pm_state_type_name[power_state->type]);
|
|
|
|
if (i == rdev->pm.default_power_state_index)
|
2010-08-02 00:42:55 +00:00
|
|
|
DRM_DEBUG_DRIVER("\tDefault");
|
2010-06-07 22:29:44 +00:00
|
|
|
if ((rdev->flags & RADEON_IS_PCIE) && !(rdev->flags & RADEON_IS_IGP))
|
2010-08-02 00:42:55 +00:00
|
|
|
DRM_DEBUG_DRIVER("\t%d PCIE Lanes\n", power_state->pcie_lanes);
|
2010-06-07 22:29:44 +00:00
|
|
|
if (power_state->flags & RADEON_PM_STATE_SINGLE_DISPLAY_ONLY)
|
2010-08-02 00:42:55 +00:00
|
|
|
DRM_DEBUG_DRIVER("\tSingle display only\n");
|
|
|
|
DRM_DEBUG_DRIVER("\t%d Clock Mode(s)\n", power_state->num_clock_modes);
|
2010-06-07 22:29:44 +00:00
|
|
|
for (j = 0; j < power_state->num_clock_modes; j++) {
|
|
|
|
clock_info = &(power_state->clock_info[j]);
|
|
|
|
if (rdev->flags & RADEON_IS_IGP)
|
2010-08-02 00:42:55 +00:00
|
|
|
DRM_DEBUG_DRIVER("\t\t%d e: %d%s\n",
|
2010-06-07 22:29:44 +00:00
|
|
|
j,
|
|
|
|
clock_info->sclk * 10,
|
|
|
|
clock_info->flags & RADEON_PM_MODE_NO_DISPLAY ? "\tNo display only" : "");
|
|
|
|
else
|
2010-08-02 00:42:55 +00:00
|
|
|
DRM_DEBUG_DRIVER("\t\t%d e: %d\tm: %d\tv: %d%s\n",
|
2010-06-07 22:29:44 +00:00
|
|
|
j,
|
|
|
|
clock_info->sclk * 10,
|
|
|
|
clock_info->mclk * 10,
|
|
|
|
clock_info->voltage.voltage,
|
|
|
|
clock_info->flags & RADEON_PM_MODE_NO_DISPLAY ? "\tNo display only" : "");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
static ssize_t radeon_get_pm_profile(struct device *dev,
|
|
|
|
struct device_attribute *attr,
|
|
|
|
char *buf)
|
2010-04-24 18:50:23 +00:00
|
|
|
{
|
|
|
|
struct drm_device *ddev = pci_get_drvdata(to_pci_dev(dev));
|
|
|
|
struct radeon_device *rdev = ddev->dev_private;
|
2010-05-07 19:10:16 +00:00
|
|
|
int cp = rdev->pm.profile;
|
2010-04-24 18:50:23 +00:00
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
return snprintf(buf, PAGE_SIZE, "%s\n",
|
|
|
|
(cp == PM_PROFILE_AUTO) ? "auto" :
|
|
|
|
(cp == PM_PROFILE_LOW) ? "low" :
|
2010-07-28 11:25:58 +00:00
|
|
|
(cp == PM_PROFILE_MID) ? "mid" :
|
2010-05-07 19:10:16 +00:00
|
|
|
(cp == PM_PROFILE_HIGH) ? "high" : "default");
|
2010-04-24 18:50:23 +00:00
|
|
|
}
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
static ssize_t radeon_set_pm_profile(struct device *dev,
|
|
|
|
struct device_attribute *attr,
|
|
|
|
const char *buf,
|
|
|
|
size_t count)
|
2010-04-24 18:50:23 +00:00
|
|
|
{
|
|
|
|
struct drm_device *ddev = pci_get_drvdata(to_pci_dev(dev));
|
|
|
|
struct radeon_device *rdev = ddev->dev_private;
|
|
|
|
|
|
|
|
mutex_lock(&rdev->pm.mutex);
|
2010-05-07 19:10:16 +00:00
|
|
|
if (rdev->pm.pm_method == PM_METHOD_PROFILE) {
|
|
|
|
if (strncmp("default", buf, strlen("default")) == 0)
|
|
|
|
rdev->pm.profile = PM_PROFILE_DEFAULT;
|
|
|
|
else if (strncmp("auto", buf, strlen("auto")) == 0)
|
|
|
|
rdev->pm.profile = PM_PROFILE_AUTO;
|
|
|
|
else if (strncmp("low", buf, strlen("low")) == 0)
|
|
|
|
rdev->pm.profile = PM_PROFILE_LOW;
|
2010-06-02 21:56:01 +00:00
|
|
|
else if (strncmp("mid", buf, strlen("mid")) == 0)
|
|
|
|
rdev->pm.profile = PM_PROFILE_MID;
|
2010-05-07 19:10:16 +00:00
|
|
|
else if (strncmp("high", buf, strlen("high")) == 0)
|
|
|
|
rdev->pm.profile = PM_PROFILE_HIGH;
|
|
|
|
else {
|
|
|
|
DRM_ERROR("invalid power profile!\n");
|
|
|
|
goto fail;
|
2010-04-24 18:50:23 +00:00
|
|
|
}
|
2010-05-07 19:10:16 +00:00
|
|
|
radeon_pm_update_profile(rdev);
|
|
|
|
radeon_pm_set_clocks(rdev);
|
|
|
|
}
|
|
|
|
fail:
|
2010-04-24 18:50:23 +00:00
|
|
|
mutex_unlock(&rdev->pm.mutex);
|
|
|
|
|
|
|
|
return count;
|
|
|
|
}
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
static ssize_t radeon_get_pm_method(struct device *dev,
|
|
|
|
struct device_attribute *attr,
|
|
|
|
char *buf)
|
2010-04-24 18:50:23 +00:00
|
|
|
{
|
|
|
|
struct drm_device *ddev = pci_get_drvdata(to_pci_dev(dev));
|
|
|
|
struct radeon_device *rdev = ddev->dev_private;
|
2010-05-07 19:10:16 +00:00
|
|
|
int pm = rdev->pm.pm_method;
|
2010-04-24 18:50:23 +00:00
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%s\n",
|
2010-05-07 19:10:16 +00:00
|
|
|
(pm == PM_METHOD_DYNPM) ? "dynpm" : "profile");
|
2010-04-24 18:50:23 +00:00
|
|
|
}
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
static ssize_t radeon_set_pm_method(struct device *dev,
|
|
|
|
struct device_attribute *attr,
|
|
|
|
const char *buf,
|
|
|
|
size_t count)
|
2010-04-24 18:50:23 +00:00
|
|
|
{
|
|
|
|
struct drm_device *ddev = pci_get_drvdata(to_pci_dev(dev));
|
|
|
|
struct radeon_device *rdev = ddev->dev_private;
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
|
|
|
|
if (strncmp("dynpm", buf, strlen("dynpm")) == 0) {
|
2010-04-24 18:50:23 +00:00
|
|
|
mutex_lock(&rdev->pm.mutex);
|
2010-05-07 19:10:16 +00:00
|
|
|
rdev->pm.pm_method = PM_METHOD_DYNPM;
|
|
|
|
rdev->pm.dynpm_state = DYNPM_STATE_PAUSED;
|
|
|
|
rdev->pm.dynpm_planned_action = DYNPM_ACTION_DEFAULT;
|
2010-04-24 18:50:23 +00:00
|
|
|
mutex_unlock(&rdev->pm.mutex);
|
2010-05-07 19:10:16 +00:00
|
|
|
} else if (strncmp("profile", buf, strlen("profile")) == 0) {
|
DRM / radeon / KMS: Fix hibernation regression related to radeon PM (was: Re: [Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300)
There is a regression from 2.6.34 related to the recent radeon power
management changes, caused by attempting to cancel a delayed work
item that's never been scheduled. However, the code as is has some
other issues potentially leading to visible problems.
First, the mutex around cancel_delayed_work() in radeon_pm_suspend()
doesn't really serve any purpose, because cancel_delayed_work() only
tries to delete the work's timer. Moreover, it doesn't prevent the
work handler from running, so the handler can do some wrong things if
it wins the race and in that case it will rearm itself to do some
more wrong things going forward. So, I think it's better to wait for
the handler to return in case it's already been queued up for
execution. Also, it should be prevented from rearming itself in that
case.
Second, in radeon_set_pm_method() the cancel_delayed_work() is not
sufficient to prevent the work handler from running and queing up
itself for the next run (the failure scenario is that
cancel_delayed_work() returns 0, so the handler is run, it waits on
the mutex and then rearms itself after the mutex has been released),
so again the work handler should be prevented from rearming itself in
that case..
Finally, there's a potential deadlock in radeon_pm_fini(), because
cancel_delayed_work_sync() is called under rdev->pm.mutex, but the
work handler tries to acquire the same mutex (if it wins the race).
Fix the issues described above.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Reviewed-by: Alex Deucher <alexdeucher@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2010-06-17 23:02:27 +00:00
|
|
|
bool flush_wq = false;
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
mutex_lock(&rdev->pm.mutex);
|
DRM / radeon / KMS: Fix hibernation regression related to radeon PM (was: Re: [Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300)
There is a regression from 2.6.34 related to the recent radeon power
management changes, caused by attempting to cancel a delayed work
item that's never been scheduled. However, the code as is has some
other issues potentially leading to visible problems.
First, the mutex around cancel_delayed_work() in radeon_pm_suspend()
doesn't really serve any purpose, because cancel_delayed_work() only
tries to delete the work's timer. Moreover, it doesn't prevent the
work handler from running, so the handler can do some wrong things if
it wins the race and in that case it will rearm itself to do some
more wrong things going forward. So, I think it's better to wait for
the handler to return in case it's already been queued up for
execution. Also, it should be prevented from rearming itself in that
case.
Second, in radeon_set_pm_method() the cancel_delayed_work() is not
sufficient to prevent the work handler from running and queing up
itself for the next run (the failure scenario is that
cancel_delayed_work() returns 0, so the handler is run, it waits on
the mutex and then rearms itself after the mutex has been released),
so again the work handler should be prevented from rearming itself in
that case..
Finally, there's a potential deadlock in radeon_pm_fini(), because
cancel_delayed_work_sync() is called under rdev->pm.mutex, but the
work handler tries to acquire the same mutex (if it wins the race).
Fix the issues described above.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Reviewed-by: Alex Deucher <alexdeucher@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2010-06-17 23:02:27 +00:00
|
|
|
if (rdev->pm.pm_method == PM_METHOD_DYNPM) {
|
|
|
|
cancel_delayed_work(&rdev->pm.dynpm_idle_work);
|
|
|
|
flush_wq = true;
|
|
|
|
}
|
2010-05-07 19:10:16 +00:00
|
|
|
/* disable dynpm */
|
|
|
|
rdev->pm.dynpm_state = DYNPM_STATE_DISABLED;
|
|
|
|
rdev->pm.dynpm_planned_action = DYNPM_ACTION_NONE;
|
DRM / radeon / KMS: Fix hibernation regression related to radeon PM (was: Re: [Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300)
There is a regression from 2.6.34 related to the recent radeon power
management changes, caused by attempting to cancel a delayed work
item that's never been scheduled. However, the code as is has some
other issues potentially leading to visible problems.
First, the mutex around cancel_delayed_work() in radeon_pm_suspend()
doesn't really serve any purpose, because cancel_delayed_work() only
tries to delete the work's timer. Moreover, it doesn't prevent the
work handler from running, so the handler can do some wrong things if
it wins the race and in that case it will rearm itself to do some
more wrong things going forward. So, I think it's better to wait for
the handler to return in case it's already been queued up for
execution. Also, it should be prevented from rearming itself in that
case.
Second, in radeon_set_pm_method() the cancel_delayed_work() is not
sufficient to prevent the work handler from running and queing up
itself for the next run (the failure scenario is that
cancel_delayed_work() returns 0, so the handler is run, it waits on
the mutex and then rearms itself after the mutex has been released),
so again the work handler should be prevented from rearming itself in
that case..
Finally, there's a potential deadlock in radeon_pm_fini(), because
cancel_delayed_work_sync() is called under rdev->pm.mutex, but the
work handler tries to acquire the same mutex (if it wins the race).
Fix the issues described above.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Reviewed-by: Alex Deucher <alexdeucher@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2010-06-17 23:02:27 +00:00
|
|
|
rdev->pm.pm_method = PM_METHOD_PROFILE;
|
2010-05-07 19:10:16 +00:00
|
|
|
mutex_unlock(&rdev->pm.mutex);
|
DRM / radeon / KMS: Fix hibernation regression related to radeon PM (was: Re: [Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300)
There is a regression from 2.6.34 related to the recent radeon power
management changes, caused by attempting to cancel a delayed work
item that's never been scheduled. However, the code as is has some
other issues potentially leading to visible problems.
First, the mutex around cancel_delayed_work() in radeon_pm_suspend()
doesn't really serve any purpose, because cancel_delayed_work() only
tries to delete the work's timer. Moreover, it doesn't prevent the
work handler from running, so the handler can do some wrong things if
it wins the race and in that case it will rearm itself to do some
more wrong things going forward. So, I think it's better to wait for
the handler to return in case it's already been queued up for
execution. Also, it should be prevented from rearming itself in that
case.
Second, in radeon_set_pm_method() the cancel_delayed_work() is not
sufficient to prevent the work handler from running and queing up
itself for the next run (the failure scenario is that
cancel_delayed_work() returns 0, so the handler is run, it waits on
the mutex and then rearms itself after the mutex has been released),
so again the work handler should be prevented from rearming itself in
that case..
Finally, there's a potential deadlock in radeon_pm_fini(), because
cancel_delayed_work_sync() is called under rdev->pm.mutex, but the
work handler tries to acquire the same mutex (if it wins the race).
Fix the issues described above.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Reviewed-by: Alex Deucher <alexdeucher@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2010-06-17 23:02:27 +00:00
|
|
|
if (flush_wq)
|
|
|
|
flush_workqueue(rdev->wq);
|
2010-05-07 19:10:16 +00:00
|
|
|
} else {
|
|
|
|
DRM_ERROR("invalid power method!\n");
|
|
|
|
goto fail;
|
|
|
|
}
|
|
|
|
radeon_pm_compute_clocks(rdev);
|
|
|
|
fail:
|
2010-04-24 18:50:23 +00:00
|
|
|
return count;
|
|
|
|
}
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
static DEVICE_ATTR(power_profile, S_IRUGO | S_IWUSR, radeon_get_pm_profile, radeon_set_pm_profile);
|
|
|
|
static DEVICE_ATTR(power_method, S_IRUGO | S_IWUSR, radeon_get_pm_method, radeon_set_pm_method);
|
2010-04-24 18:50:23 +00:00
|
|
|
|
2010-07-02 16:58:16 +00:00
|
|
|
static ssize_t radeon_hwmon_show_temp(struct device *dev,
|
|
|
|
struct device_attribute *attr,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
struct drm_device *ddev = pci_get_drvdata(to_pci_dev(dev));
|
|
|
|
struct radeon_device *rdev = ddev->dev_private;
|
|
|
|
u32 temp;
|
|
|
|
|
|
|
|
switch (rdev->pm.int_thermal_type) {
|
|
|
|
case THERMAL_TYPE_RV6XX:
|
|
|
|
temp = rv6xx_get_temp(rdev);
|
|
|
|
break;
|
|
|
|
case THERMAL_TYPE_RV770:
|
|
|
|
temp = rv770_get_temp(rdev);
|
|
|
|
break;
|
|
|
|
case THERMAL_TYPE_EVERGREEN:
|
|
|
|
temp = evergreen_get_temp(rdev);
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
temp = 0;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return snprintf(buf, PAGE_SIZE, "%d\n", temp);
|
|
|
|
}
|
|
|
|
|
|
|
|
static ssize_t radeon_hwmon_show_name(struct device *dev,
|
|
|
|
struct device_attribute *attr,
|
|
|
|
char *buf)
|
|
|
|
{
|
|
|
|
return sprintf(buf, "radeon\n");
|
|
|
|
}
|
|
|
|
|
|
|
|
static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, radeon_hwmon_show_temp, NULL, 0);
|
|
|
|
static SENSOR_DEVICE_ATTR(name, S_IRUGO, radeon_hwmon_show_name, NULL, 0);
|
|
|
|
|
|
|
|
static struct attribute *hwmon_attributes[] = {
|
|
|
|
&sensor_dev_attr_temp1_input.dev_attr.attr,
|
|
|
|
&sensor_dev_attr_name.dev_attr.attr,
|
|
|
|
NULL
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct attribute_group hwmon_attrgroup = {
|
|
|
|
.attrs = hwmon_attributes,
|
|
|
|
};
|
|
|
|
|
2010-08-09 19:59:42 +00:00
|
|
|
static int radeon_hwmon_init(struct radeon_device *rdev)
|
2010-07-02 16:58:16 +00:00
|
|
|
{
|
2010-08-09 19:59:42 +00:00
|
|
|
int err = 0;
|
2010-07-02 16:58:16 +00:00
|
|
|
|
|
|
|
rdev->pm.int_hwmon_dev = NULL;
|
|
|
|
|
|
|
|
switch (rdev->pm.int_thermal_type) {
|
|
|
|
case THERMAL_TYPE_RV6XX:
|
|
|
|
case THERMAL_TYPE_RV770:
|
|
|
|
case THERMAL_TYPE_EVERGREEN:
|
|
|
|
rdev->pm.int_hwmon_dev = hwmon_device_register(rdev->dev);
|
2010-08-09 19:59:42 +00:00
|
|
|
if (IS_ERR(rdev->pm.int_hwmon_dev)) {
|
|
|
|
err = PTR_ERR(rdev->pm.int_hwmon_dev);
|
|
|
|
dev_err(rdev->dev,
|
|
|
|
"Unable to register hwmon device: %d\n", err);
|
|
|
|
break;
|
|
|
|
}
|
2010-07-02 16:58:16 +00:00
|
|
|
dev_set_drvdata(rdev->pm.int_hwmon_dev, rdev->ddev);
|
|
|
|
err = sysfs_create_group(&rdev->pm.int_hwmon_dev->kobj,
|
|
|
|
&hwmon_attrgroup);
|
2010-08-09 19:59:42 +00:00
|
|
|
if (err) {
|
|
|
|
dev_err(rdev->dev,
|
|
|
|
"Unable to create hwmon sysfs file: %d\n", err);
|
|
|
|
hwmon_device_unregister(rdev->dev);
|
|
|
|
}
|
2010-07-02 16:58:16 +00:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
2010-08-09 19:59:42 +00:00
|
|
|
|
|
|
|
return err;
|
2010-07-02 16:58:16 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void radeon_hwmon_fini(struct radeon_device *rdev)
|
|
|
|
{
|
|
|
|
if (rdev->pm.int_hwmon_dev) {
|
|
|
|
sysfs_remove_group(&rdev->pm.int_hwmon_dev->kobj, &hwmon_attrgroup);
|
|
|
|
hwmon_device_unregister(rdev->pm.int_hwmon_dev);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
void radeon_pm_suspend(struct radeon_device *rdev)
|
2009-12-28 18:58:44 +00:00
|
|
|
{
|
DRM / radeon / KMS: Fix hibernation regression related to radeon PM (was: Re: [Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300)
There is a regression from 2.6.34 related to the recent radeon power
management changes, caused by attempting to cancel a delayed work
item that's never been scheduled. However, the code as is has some
other issues potentially leading to visible problems.
First, the mutex around cancel_delayed_work() in radeon_pm_suspend()
doesn't really serve any purpose, because cancel_delayed_work() only
tries to delete the work's timer. Moreover, it doesn't prevent the
work handler from running, so the handler can do some wrong things if
it wins the race and in that case it will rearm itself to do some
more wrong things going forward. So, I think it's better to wait for
the handler to return in case it's already been queued up for
execution. Also, it should be prevented from rearming itself in that
case.
Second, in radeon_set_pm_method() the cancel_delayed_work() is not
sufficient to prevent the work handler from running and queing up
itself for the next run (the failure scenario is that
cancel_delayed_work() returns 0, so the handler is run, it waits on
the mutex and then rearms itself after the mutex has been released),
so again the work handler should be prevented from rearming itself in
that case..
Finally, there's a potential deadlock in radeon_pm_fini(), because
cancel_delayed_work_sync() is called under rdev->pm.mutex, but the
work handler tries to acquire the same mutex (if it wins the race).
Fix the issues described above.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Reviewed-by: Alex Deucher <alexdeucher@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2010-06-17 23:02:27 +00:00
|
|
|
bool flush_wq = false;
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
mutex_lock(&rdev->pm.mutex);
|
DRM / radeon / KMS: Fix hibernation regression related to radeon PM (was: Re: [Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300)
There is a regression from 2.6.34 related to the recent radeon power
management changes, caused by attempting to cancel a delayed work
item that's never been scheduled. However, the code as is has some
other issues potentially leading to visible problems.
First, the mutex around cancel_delayed_work() in radeon_pm_suspend()
doesn't really serve any purpose, because cancel_delayed_work() only
tries to delete the work's timer. Moreover, it doesn't prevent the
work handler from running, so the handler can do some wrong things if
it wins the race and in that case it will rearm itself to do some
more wrong things going forward. So, I think it's better to wait for
the handler to return in case it's already been queued up for
execution. Also, it should be prevented from rearming itself in that
case.
Second, in radeon_set_pm_method() the cancel_delayed_work() is not
sufficient to prevent the work handler from running and queing up
itself for the next run (the failure scenario is that
cancel_delayed_work() returns 0, so the handler is run, it waits on
the mutex and then rearms itself after the mutex has been released),
so again the work handler should be prevented from rearming itself in
that case..
Finally, there's a potential deadlock in radeon_pm_fini(), because
cancel_delayed_work_sync() is called under rdev->pm.mutex, but the
work handler tries to acquire the same mutex (if it wins the race).
Fix the issues described above.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Reviewed-by: Alex Deucher <alexdeucher@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2010-06-17 23:02:27 +00:00
|
|
|
if (rdev->pm.pm_method == PM_METHOD_DYNPM) {
|
|
|
|
cancel_delayed_work(&rdev->pm.dynpm_idle_work);
|
|
|
|
if (rdev->pm.dynpm_state == DYNPM_STATE_ACTIVE)
|
|
|
|
rdev->pm.dynpm_state = DYNPM_STATE_SUSPENDED;
|
|
|
|
flush_wq = true;
|
|
|
|
}
|
2010-05-07 19:10:16 +00:00
|
|
|
mutex_unlock(&rdev->pm.mutex);
|
DRM / radeon / KMS: Fix hibernation regression related to radeon PM (was: Re: [Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300)
There is a regression from 2.6.34 related to the recent radeon power
management changes, caused by attempting to cancel a delayed work
item that's never been scheduled. However, the code as is has some
other issues potentially leading to visible problems.
First, the mutex around cancel_delayed_work() in radeon_pm_suspend()
doesn't really serve any purpose, because cancel_delayed_work() only
tries to delete the work's timer. Moreover, it doesn't prevent the
work handler from running, so the handler can do some wrong things if
it wins the race and in that case it will rearm itself to do some
more wrong things going forward. So, I think it's better to wait for
the handler to return in case it's already been queued up for
execution. Also, it should be prevented from rearming itself in that
case.
Second, in radeon_set_pm_method() the cancel_delayed_work() is not
sufficient to prevent the work handler from running and queing up
itself for the next run (the failure scenario is that
cancel_delayed_work() returns 0, so the handler is run, it waits on
the mutex and then rearms itself after the mutex has been released),
so again the work handler should be prevented from rearming itself in
that case..
Finally, there's a potential deadlock in radeon_pm_fini(), because
cancel_delayed_work_sync() is called under rdev->pm.mutex, but the
work handler tries to acquire the same mutex (if it wins the race).
Fix the issues described above.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Reviewed-by: Alex Deucher <alexdeucher@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2010-06-17 23:02:27 +00:00
|
|
|
if (flush_wq)
|
|
|
|
flush_workqueue(rdev->wq);
|
2009-12-28 18:58:44 +00:00
|
|
|
}
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
void radeon_pm_resume(struct radeon_device *rdev)
|
2010-03-02 21:06:52 +00:00
|
|
|
{
|
2010-06-07 21:49:51 +00:00
|
|
|
/* asic init will reset the default power state */
|
|
|
|
mutex_lock(&rdev->pm.mutex);
|
|
|
|
rdev->pm.current_power_state_index = rdev->pm.default_power_state_index;
|
|
|
|
rdev->pm.current_clock_mode_index = 0;
|
|
|
|
rdev->pm.current_sclk = rdev->clock.default_sclk;
|
|
|
|
rdev->pm.current_mclk = rdev->clock.default_mclk;
|
2010-06-07 22:15:18 +00:00
|
|
|
rdev->pm.current_vddc = rdev->pm.power_state[rdev->pm.default_power_state_index].clock_info[0].voltage.voltage;
|
DRM / radeon / KMS: Fix hibernation regression related to radeon PM (was: Re: [Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300)
There is a regression from 2.6.34 related to the recent radeon power
management changes, caused by attempting to cancel a delayed work
item that's never been scheduled. However, the code as is has some
other issues potentially leading to visible problems.
First, the mutex around cancel_delayed_work() in radeon_pm_suspend()
doesn't really serve any purpose, because cancel_delayed_work() only
tries to delete the work's timer. Moreover, it doesn't prevent the
work handler from running, so the handler can do some wrong things if
it wins the race and in that case it will rearm itself to do some
more wrong things going forward. So, I think it's better to wait for
the handler to return in case it's already been queued up for
execution. Also, it should be prevented from rearming itself in that
case.
Second, in radeon_set_pm_method() the cancel_delayed_work() is not
sufficient to prevent the work handler from running and queing up
itself for the next run (the failure scenario is that
cancel_delayed_work() returns 0, so the handler is run, it waits on
the mutex and then rearms itself after the mutex has been released),
so again the work handler should be prevented from rearming itself in
that case..
Finally, there's a potential deadlock in radeon_pm_fini(), because
cancel_delayed_work_sync() is called under rdev->pm.mutex, but the
work handler tries to acquire the same mutex (if it wins the race).
Fix the issues described above.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Reviewed-by: Alex Deucher <alexdeucher@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2010-06-17 23:02:27 +00:00
|
|
|
if (rdev->pm.pm_method == PM_METHOD_DYNPM
|
|
|
|
&& rdev->pm.dynpm_state == DYNPM_STATE_SUSPENDED) {
|
|
|
|
rdev->pm.dynpm_state = DYNPM_STATE_ACTIVE;
|
|
|
|
queue_delayed_work(rdev->wq, &rdev->pm.dynpm_idle_work,
|
|
|
|
msecs_to_jiffies(RADEON_IDLE_LOOP_MS));
|
|
|
|
}
|
2010-06-07 21:49:51 +00:00
|
|
|
mutex_unlock(&rdev->pm.mutex);
|
2010-05-07 19:10:16 +00:00
|
|
|
radeon_pm_compute_clocks(rdev);
|
2010-03-02 21:06:52 +00:00
|
|
|
}
|
|
|
|
|
2009-11-02 23:53:02 +00:00
|
|
|
int radeon_pm_init(struct radeon_device *rdev)
|
|
|
|
{
|
2010-05-18 09:00:14 +00:00
|
|
|
int ret;
|
2010-08-09 19:59:42 +00:00
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
/* default to profile method */
|
|
|
|
rdev->pm.pm_method = PM_METHOD_PROFILE;
|
2010-06-07 21:49:51 +00:00
|
|
|
rdev->pm.profile = PM_PROFILE_DEFAULT;
|
2010-05-07 19:10:16 +00:00
|
|
|
rdev->pm.dynpm_state = DYNPM_STATE_DISABLED;
|
|
|
|
rdev->pm.dynpm_planned_action = DYNPM_ACTION_NONE;
|
|
|
|
rdev->pm.dynpm_can_upclock = true;
|
|
|
|
rdev->pm.dynpm_can_downclock = true;
|
2010-06-07 21:49:51 +00:00
|
|
|
rdev->pm.current_sclk = rdev->clock.default_sclk;
|
|
|
|
rdev->pm.current_mclk = rdev->clock.default_mclk;
|
2010-07-02 16:58:16 +00:00
|
|
|
rdev->pm.int_thermal_type = THERMAL_TYPE_NONE;
|
2009-12-22 22:02:16 +00:00
|
|
|
|
2009-12-28 18:58:44 +00:00
|
|
|
if (rdev->bios) {
|
|
|
|
if (rdev->is_atom_bios)
|
|
|
|
radeon_atombios_get_power_modes(rdev);
|
|
|
|
else
|
|
|
|
radeon_combios_get_power_modes(rdev);
|
2010-06-07 22:29:44 +00:00
|
|
|
radeon_pm_print_states(rdev);
|
2010-05-07 19:10:16 +00:00
|
|
|
radeon_pm_init_profile(rdev);
|
2009-12-28 18:58:44 +00:00
|
|
|
}
|
|
|
|
|
2010-07-02 16:58:16 +00:00
|
|
|
/* set up the internal thermal sensor if applicable */
|
2010-08-09 19:59:42 +00:00
|
|
|
ret = radeon_hwmon_init(rdev);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
2010-05-07 19:10:16 +00:00
|
|
|
if (rdev->pm.num_power_states > 1) {
|
|
|
|
/* where's the best place to put these? */
|
2010-05-18 09:00:14 +00:00
|
|
|
ret = device_create_file(rdev->dev, &dev_attr_power_profile);
|
|
|
|
if (ret)
|
|
|
|
DRM_ERROR("failed to create device file for power profile\n");
|
|
|
|
ret = device_create_file(rdev->dev, &dev_attr_power_method);
|
|
|
|
if (ret)
|
|
|
|
DRM_ERROR("failed to create device file for power method\n");
|
2010-04-24 18:50:23 +00:00
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
#ifdef CONFIG_ACPI
|
|
|
|
rdev->acpi_nb.notifier_call = radeon_acpi_event;
|
|
|
|
register_acpi_notifier(&rdev->acpi_nb);
|
|
|
|
#endif
|
|
|
|
INIT_DELAYED_WORK(&rdev->pm.dynpm_idle_work, radeon_dynpm_idle_work_handler);
|
2009-12-22 22:02:16 +00:00
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
if (radeon_debugfs_pm_init(rdev)) {
|
|
|
|
DRM_ERROR("Failed to register debugfs file for PM!\n");
|
|
|
|
}
|
2009-12-22 22:02:16 +00:00
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
DRM_INFO("radeon: power management initialized\n");
|
|
|
|
}
|
2009-12-22 22:02:16 +00:00
|
|
|
|
2009-11-02 23:53:02 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-03-11 15:01:17 +00:00
|
|
|
void radeon_pm_fini(struct radeon_device *rdev)
|
|
|
|
{
|
2010-05-07 19:10:16 +00:00
|
|
|
if (rdev->pm.num_power_states > 1) {
|
DRM / radeon / KMS: Fix hibernation regression related to radeon PM (was: Re: [Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300)
There is a regression from 2.6.34 related to the recent radeon power
management changes, caused by attempting to cancel a delayed work
item that's never been scheduled. However, the code as is has some
other issues potentially leading to visible problems.
First, the mutex around cancel_delayed_work() in radeon_pm_suspend()
doesn't really serve any purpose, because cancel_delayed_work() only
tries to delete the work's timer. Moreover, it doesn't prevent the
work handler from running, so the handler can do some wrong things if
it wins the race and in that case it will rearm itself to do some
more wrong things going forward. So, I think it's better to wait for
the handler to return in case it's already been queued up for
execution. Also, it should be prevented from rearming itself in that
case.
Second, in radeon_set_pm_method() the cancel_delayed_work() is not
sufficient to prevent the work handler from running and queing up
itself for the next run (the failure scenario is that
cancel_delayed_work() returns 0, so the handler is run, it waits on
the mutex and then rearms itself after the mutex has been released),
so again the work handler should be prevented from rearming itself in
that case..
Finally, there's a potential deadlock in radeon_pm_fini(), because
cancel_delayed_work_sync() is called under rdev->pm.mutex, but the
work handler tries to acquire the same mutex (if it wins the race).
Fix the issues described above.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Reviewed-by: Alex Deucher <alexdeucher@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2010-06-17 23:02:27 +00:00
|
|
|
bool flush_wq = false;
|
|
|
|
|
2010-04-24 18:50:23 +00:00
|
|
|
mutex_lock(&rdev->pm.mutex);
|
2010-05-07 19:10:16 +00:00
|
|
|
if (rdev->pm.pm_method == PM_METHOD_PROFILE) {
|
|
|
|
rdev->pm.profile = PM_PROFILE_DEFAULT;
|
|
|
|
radeon_pm_update_profile(rdev);
|
|
|
|
radeon_pm_set_clocks(rdev);
|
|
|
|
} else if (rdev->pm.pm_method == PM_METHOD_DYNPM) {
|
|
|
|
/* cancel work */
|
DRM / radeon / KMS: Fix hibernation regression related to radeon PM (was: Re: [Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300)
There is a regression from 2.6.34 related to the recent radeon power
management changes, caused by attempting to cancel a delayed work
item that's never been scheduled. However, the code as is has some
other issues potentially leading to visible problems.
First, the mutex around cancel_delayed_work() in radeon_pm_suspend()
doesn't really serve any purpose, because cancel_delayed_work() only
tries to delete the work's timer. Moreover, it doesn't prevent the
work handler from running, so the handler can do some wrong things if
it wins the race and in that case it will rearm itself to do some
more wrong things going forward. So, I think it's better to wait for
the handler to return in case it's already been queued up for
execution. Also, it should be prevented from rearming itself in that
case.
Second, in radeon_set_pm_method() the cancel_delayed_work() is not
sufficient to prevent the work handler from running and queing up
itself for the next run (the failure scenario is that
cancel_delayed_work() returns 0, so the handler is run, it waits on
the mutex and then rearms itself after the mutex has been released),
so again the work handler should be prevented from rearming itself in
that case..
Finally, there's a potential deadlock in radeon_pm_fini(), because
cancel_delayed_work_sync() is called under rdev->pm.mutex, but the
work handler tries to acquire the same mutex (if it wins the race).
Fix the issues described above.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Reviewed-by: Alex Deucher <alexdeucher@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2010-06-17 23:02:27 +00:00
|
|
|
cancel_delayed_work(&rdev->pm.dynpm_idle_work);
|
|
|
|
flush_wq = true;
|
2010-05-07 19:10:16 +00:00
|
|
|
/* reset default clocks */
|
|
|
|
rdev->pm.dynpm_state = DYNPM_STATE_DISABLED;
|
|
|
|
rdev->pm.dynpm_planned_action = DYNPM_ACTION_DEFAULT;
|
|
|
|
radeon_pm_set_clocks(rdev);
|
|
|
|
}
|
2010-04-24 18:50:23 +00:00
|
|
|
mutex_unlock(&rdev->pm.mutex);
|
DRM / radeon / KMS: Fix hibernation regression related to radeon PM (was: Re: [Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300)
There is a regression from 2.6.34 related to the recent radeon power
management changes, caused by attempting to cancel a delayed work
item that's never been scheduled. However, the code as is has some
other issues potentially leading to visible problems.
First, the mutex around cancel_delayed_work() in radeon_pm_suspend()
doesn't really serve any purpose, because cancel_delayed_work() only
tries to delete the work's timer. Moreover, it doesn't prevent the
work handler from running, so the handler can do some wrong things if
it wins the race and in that case it will rearm itself to do some
more wrong things going forward. So, I think it's better to wait for
the handler to return in case it's already been queued up for
execution. Also, it should be prevented from rearming itself in that
case.
Second, in radeon_set_pm_method() the cancel_delayed_work() is not
sufficient to prevent the work handler from running and queing up
itself for the next run (the failure scenario is that
cancel_delayed_work() returns 0, so the handler is run, it waits on
the mutex and then rearms itself after the mutex has been released),
so again the work handler should be prevented from rearming itself in
that case..
Finally, there's a potential deadlock in radeon_pm_fini(), because
cancel_delayed_work_sync() is called under rdev->pm.mutex, but the
work handler tries to acquire the same mutex (if it wins the race).
Fix the issues described above.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Reviewed-by: Alex Deucher <alexdeucher@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2010-06-17 23:02:27 +00:00
|
|
|
if (flush_wq)
|
|
|
|
flush_workqueue(rdev->wq);
|
2010-03-22 17:31:08 +00:00
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
device_remove_file(rdev->dev, &dev_attr_power_profile);
|
|
|
|
device_remove_file(rdev->dev, &dev_attr_power_method);
|
|
|
|
#ifdef CONFIG_ACPI
|
|
|
|
unregister_acpi_notifier(&rdev->acpi_nb);
|
|
|
|
#endif
|
|
|
|
}
|
2010-04-24 18:50:23 +00:00
|
|
|
|
2010-07-02 16:58:16 +00:00
|
|
|
radeon_hwmon_fini(rdev);
|
2010-03-11 15:01:17 +00:00
|
|
|
if (rdev->pm.i2c_bus)
|
|
|
|
radeon_i2c_destroy(rdev->pm.i2c_bus);
|
|
|
|
}
|
|
|
|
|
2009-12-22 22:02:16 +00:00
|
|
|
void radeon_pm_compute_clocks(struct radeon_device *rdev)
|
|
|
|
{
|
|
|
|
struct drm_device *ddev = rdev->ddev;
|
2010-04-22 18:03:55 +00:00
|
|
|
struct drm_crtc *crtc;
|
2009-12-22 22:02:16 +00:00
|
|
|
struct radeon_crtc *radeon_crtc;
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
if (rdev->pm.num_power_states < 2)
|
|
|
|
return;
|
|
|
|
|
2009-12-22 22:02:16 +00:00
|
|
|
mutex_lock(&rdev->pm.mutex);
|
|
|
|
|
|
|
|
rdev->pm.active_crtcs = 0;
|
2010-04-22 18:03:55 +00:00
|
|
|
rdev->pm.active_crtc_count = 0;
|
|
|
|
list_for_each_entry(crtc,
|
|
|
|
&ddev->mode_config.crtc_list, head) {
|
|
|
|
radeon_crtc = to_radeon_crtc(crtc);
|
|
|
|
if (radeon_crtc->enabled) {
|
2009-12-22 22:02:16 +00:00
|
|
|
rdev->pm.active_crtcs |= (1 << radeon_crtc->crtc_id);
|
2010-04-22 18:03:55 +00:00
|
|
|
rdev->pm.active_crtc_count++;
|
2009-12-22 22:02:16 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
if (rdev->pm.pm_method == PM_METHOD_PROFILE) {
|
|
|
|
radeon_pm_update_profile(rdev);
|
|
|
|
radeon_pm_set_clocks(rdev);
|
|
|
|
} else if (rdev->pm.pm_method == PM_METHOD_DYNPM) {
|
|
|
|
if (rdev->pm.dynpm_state != DYNPM_STATE_DISABLED) {
|
|
|
|
if (rdev->pm.active_crtc_count > 1) {
|
|
|
|
if (rdev->pm.dynpm_state == DYNPM_STATE_ACTIVE) {
|
|
|
|
cancel_delayed_work(&rdev->pm.dynpm_idle_work);
|
|
|
|
|
|
|
|
rdev->pm.dynpm_state = DYNPM_STATE_PAUSED;
|
|
|
|
rdev->pm.dynpm_planned_action = DYNPM_ACTION_DEFAULT;
|
|
|
|
radeon_pm_get_dynpm_state(rdev);
|
|
|
|
radeon_pm_set_clocks(rdev);
|
|
|
|
|
2010-08-02 00:42:55 +00:00
|
|
|
DRM_DEBUG_DRIVER("radeon: dynamic power management deactivated\n");
|
2010-05-07 19:10:16 +00:00
|
|
|
}
|
|
|
|
} else if (rdev->pm.active_crtc_count == 1) {
|
|
|
|
/* TODO: Increase clocks if needed for current mode */
|
|
|
|
|
|
|
|
if (rdev->pm.dynpm_state == DYNPM_STATE_MINIMUM) {
|
|
|
|
rdev->pm.dynpm_state = DYNPM_STATE_ACTIVE;
|
|
|
|
rdev->pm.dynpm_planned_action = DYNPM_ACTION_UPCLOCK;
|
|
|
|
radeon_pm_get_dynpm_state(rdev);
|
|
|
|
radeon_pm_set_clocks(rdev);
|
|
|
|
|
|
|
|
queue_delayed_work(rdev->wq, &rdev->pm.dynpm_idle_work,
|
|
|
|
msecs_to_jiffies(RADEON_IDLE_LOOP_MS));
|
|
|
|
} else if (rdev->pm.dynpm_state == DYNPM_STATE_PAUSED) {
|
|
|
|
rdev->pm.dynpm_state = DYNPM_STATE_ACTIVE;
|
|
|
|
queue_delayed_work(rdev->wq, &rdev->pm.dynpm_idle_work,
|
|
|
|
msecs_to_jiffies(RADEON_IDLE_LOOP_MS));
|
2010-08-02 00:42:55 +00:00
|
|
|
DRM_DEBUG_DRIVER("radeon: dynamic power management activated\n");
|
2010-05-07 19:10:16 +00:00
|
|
|
}
|
|
|
|
} else { /* count == 0 */
|
|
|
|
if (rdev->pm.dynpm_state != DYNPM_STATE_MINIMUM) {
|
|
|
|
cancel_delayed_work(&rdev->pm.dynpm_idle_work);
|
|
|
|
|
|
|
|
rdev->pm.dynpm_state = DYNPM_STATE_MINIMUM;
|
|
|
|
rdev->pm.dynpm_planned_action = DYNPM_ACTION_MINIMUM;
|
|
|
|
radeon_pm_get_dynpm_state(rdev);
|
|
|
|
radeon_pm_set_clocks(rdev);
|
|
|
|
}
|
|
|
|
}
|
2009-12-22 22:02:16 +00:00
|
|
|
}
|
|
|
|
}
|
2010-01-07 23:22:47 +00:00
|
|
|
|
|
|
|
mutex_unlock(&rdev->pm.mutex);
|
2009-12-22 22:02:16 +00:00
|
|
|
}
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
static bool radeon_pm_in_vbl(struct radeon_device *rdev)
|
2010-02-18 05:58:36 +00:00
|
|
|
{
|
2010-04-29 04:22:43 +00:00
|
|
|
u32 stat_crtc = 0, vbl = 0, position = 0;
|
2010-02-18 05:58:36 +00:00
|
|
|
bool in_vbl = true;
|
|
|
|
|
2010-04-22 17:38:05 +00:00
|
|
|
if (ASIC_IS_DCE4(rdev)) {
|
|
|
|
if (rdev->pm.active_crtcs & (1 << 0)) {
|
2010-04-29 04:22:43 +00:00
|
|
|
vbl = RREG32(EVERGREEN_CRTC_V_BLANK_START_END +
|
|
|
|
EVERGREEN_CRTC0_REGISTER_OFFSET) & 0xfff;
|
|
|
|
position = RREG32(EVERGREEN_CRTC_STATUS_POSITION +
|
|
|
|
EVERGREEN_CRTC0_REGISTER_OFFSET) & 0xfff;
|
2010-04-22 17:38:05 +00:00
|
|
|
}
|
|
|
|
if (rdev->pm.active_crtcs & (1 << 1)) {
|
2010-04-29 04:22:43 +00:00
|
|
|
vbl = RREG32(EVERGREEN_CRTC_V_BLANK_START_END +
|
|
|
|
EVERGREEN_CRTC1_REGISTER_OFFSET) & 0xfff;
|
|
|
|
position = RREG32(EVERGREEN_CRTC_STATUS_POSITION +
|
|
|
|
EVERGREEN_CRTC1_REGISTER_OFFSET) & 0xfff;
|
2010-04-22 17:38:05 +00:00
|
|
|
}
|
|
|
|
if (rdev->pm.active_crtcs & (1 << 2)) {
|
2010-04-29 04:22:43 +00:00
|
|
|
vbl = RREG32(EVERGREEN_CRTC_V_BLANK_START_END +
|
|
|
|
EVERGREEN_CRTC2_REGISTER_OFFSET) & 0xfff;
|
|
|
|
position = RREG32(EVERGREEN_CRTC_STATUS_POSITION +
|
|
|
|
EVERGREEN_CRTC2_REGISTER_OFFSET) & 0xfff;
|
2010-04-22 17:38:05 +00:00
|
|
|
}
|
|
|
|
if (rdev->pm.active_crtcs & (1 << 3)) {
|
2010-04-29 04:22:43 +00:00
|
|
|
vbl = RREG32(EVERGREEN_CRTC_V_BLANK_START_END +
|
|
|
|
EVERGREEN_CRTC3_REGISTER_OFFSET) & 0xfff;
|
|
|
|
position = RREG32(EVERGREEN_CRTC_STATUS_POSITION +
|
|
|
|
EVERGREEN_CRTC3_REGISTER_OFFSET) & 0xfff;
|
2010-04-22 17:38:05 +00:00
|
|
|
}
|
|
|
|
if (rdev->pm.active_crtcs & (1 << 4)) {
|
2010-04-29 04:22:43 +00:00
|
|
|
vbl = RREG32(EVERGREEN_CRTC_V_BLANK_START_END +
|
|
|
|
EVERGREEN_CRTC4_REGISTER_OFFSET) & 0xfff;
|
|
|
|
position = RREG32(EVERGREEN_CRTC_STATUS_POSITION +
|
|
|
|
EVERGREEN_CRTC4_REGISTER_OFFSET) & 0xfff;
|
2010-04-22 17:38:05 +00:00
|
|
|
}
|
|
|
|
if (rdev->pm.active_crtcs & (1 << 5)) {
|
2010-04-29 04:22:43 +00:00
|
|
|
vbl = RREG32(EVERGREEN_CRTC_V_BLANK_START_END +
|
|
|
|
EVERGREEN_CRTC5_REGISTER_OFFSET) & 0xfff;
|
|
|
|
position = RREG32(EVERGREEN_CRTC_STATUS_POSITION +
|
|
|
|
EVERGREEN_CRTC5_REGISTER_OFFSET) & 0xfff;
|
2010-04-22 17:38:05 +00:00
|
|
|
}
|
|
|
|
} else if (ASIC_IS_AVIVO(rdev)) {
|
|
|
|
if (rdev->pm.active_crtcs & (1 << 0)) {
|
2010-04-29 04:22:43 +00:00
|
|
|
vbl = RREG32(AVIVO_D1CRTC_V_BLANK_START_END) & 0xfff;
|
|
|
|
position = RREG32(AVIVO_D1CRTC_STATUS_POSITION) & 0xfff;
|
2010-04-22 17:38:05 +00:00
|
|
|
}
|
|
|
|
if (rdev->pm.active_crtcs & (1 << 1)) {
|
2010-04-29 04:22:43 +00:00
|
|
|
vbl = RREG32(AVIVO_D2CRTC_V_BLANK_START_END) & 0xfff;
|
|
|
|
position = RREG32(AVIVO_D2CRTC_STATUS_POSITION) & 0xfff;
|
2010-04-22 17:38:05 +00:00
|
|
|
}
|
2010-04-29 04:22:43 +00:00
|
|
|
if (position < vbl && position > 1)
|
|
|
|
in_vbl = false;
|
2010-04-22 17:38:05 +00:00
|
|
|
} else {
|
2010-02-18 05:58:36 +00:00
|
|
|
if (rdev->pm.active_crtcs & (1 << 0)) {
|
2010-04-22 17:38:05 +00:00
|
|
|
stat_crtc = RREG32(RADEON_CRTC_STATUS);
|
|
|
|
if (!(stat_crtc & 1))
|
2010-02-18 05:58:36 +00:00
|
|
|
in_vbl = false;
|
|
|
|
}
|
|
|
|
if (rdev->pm.active_crtcs & (1 << 1)) {
|
2010-04-22 17:38:05 +00:00
|
|
|
stat_crtc = RREG32(RADEON_CRTC2_STATUS);
|
|
|
|
if (!(stat_crtc & 1))
|
2010-02-18 05:58:36 +00:00
|
|
|
in_vbl = false;
|
|
|
|
}
|
|
|
|
}
|
2010-04-28 16:13:06 +00:00
|
|
|
|
2010-04-29 04:22:43 +00:00
|
|
|
if (position < vbl && position > 1)
|
|
|
|
in_vbl = false;
|
|
|
|
|
2010-04-28 16:13:06 +00:00
|
|
|
return in_vbl;
|
|
|
|
}
|
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
static bool radeon_pm_debug_check_in_vbl(struct radeon_device *rdev, bool finish)
|
2010-04-28 16:13:06 +00:00
|
|
|
{
|
|
|
|
u32 stat_crtc = 0;
|
|
|
|
bool in_vbl = radeon_pm_in_vbl(rdev);
|
|
|
|
|
2010-02-18 05:58:36 +00:00
|
|
|
if (in_vbl == false)
|
2010-08-02 00:42:55 +00:00
|
|
|
DRM_DEBUG_DRIVER("not in vbl for pm change %08x at %s\n", stat_crtc,
|
2010-04-22 17:38:05 +00:00
|
|
|
finish ? "exit" : "entry");
|
2010-02-18 05:58:36 +00:00
|
|
|
return in_vbl;
|
|
|
|
}
|
2009-12-22 22:02:16 +00:00
|
|
|
|
2010-05-07 19:10:16 +00:00
|
|
|
static void radeon_dynpm_idle_work_handler(struct work_struct *work)
|
2009-12-22 22:02:16 +00:00
|
|
|
{
|
|
|
|
struct radeon_device *rdev;
|
2010-04-26 20:02:26 +00:00
|
|
|
int resched;
|
2009-12-22 22:02:16 +00:00
|
|
|
rdev = container_of(work, struct radeon_device,
|
2010-05-07 19:10:16 +00:00
|
|
|
pm.dynpm_idle_work.work);
|
2009-12-22 22:02:16 +00:00
|
|
|
|
2010-04-26 20:02:26 +00:00
|
|
|
resched = ttm_bo_lock_delayed_workqueue(&rdev->mman.bdev);
|
2009-12-22 22:02:16 +00:00
|
|
|
mutex_lock(&rdev->pm.mutex);
|
2010-05-07 19:10:16 +00:00
|
|
|
if (rdev->pm.dynpm_state == DYNPM_STATE_ACTIVE) {
|
2009-12-22 22:02:16 +00:00
|
|
|
unsigned long irq_flags;
|
|
|
|
int not_processed = 0;
|
|
|
|
|
|
|
|
read_lock_irqsave(&rdev->fence_drv.lock, irq_flags);
|
|
|
|
if (!list_empty(&rdev->fence_drv.emited)) {
|
|
|
|
struct list_head *ptr;
|
|
|
|
list_for_each(ptr, &rdev->fence_drv.emited) {
|
|
|
|
/* count up to 3, that's enought info */
|
|
|
|
if (++not_processed >= 3)
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
read_unlock_irqrestore(&rdev->fence_drv.lock, irq_flags);
|
|
|
|
|
|
|
|
if (not_processed >= 3) { /* should upclock */
|
2010-05-07 19:10:16 +00:00
|
|
|
if (rdev->pm.dynpm_planned_action == DYNPM_ACTION_DOWNCLOCK) {
|
|
|
|
rdev->pm.dynpm_planned_action = DYNPM_ACTION_NONE;
|
|
|
|
} else if (rdev->pm.dynpm_planned_action == DYNPM_ACTION_NONE &&
|
|
|
|
rdev->pm.dynpm_can_upclock) {
|
|
|
|
rdev->pm.dynpm_planned_action =
|
|
|
|
DYNPM_ACTION_UPCLOCK;
|
|
|
|
rdev->pm.dynpm_action_timeout = jiffies +
|
2009-12-22 22:02:16 +00:00
|
|
|
msecs_to_jiffies(RADEON_RECLOCK_DELAY_MS);
|
|
|
|
}
|
|
|
|
} else if (not_processed == 0) { /* should downclock */
|
2010-05-07 19:10:16 +00:00
|
|
|
if (rdev->pm.dynpm_planned_action == DYNPM_ACTION_UPCLOCK) {
|
|
|
|
rdev->pm.dynpm_planned_action = DYNPM_ACTION_NONE;
|
|
|
|
} else if (rdev->pm.dynpm_planned_action == DYNPM_ACTION_NONE &&
|
|
|
|
rdev->pm.dynpm_can_downclock) {
|
|
|
|
rdev->pm.dynpm_planned_action =
|
|
|
|
DYNPM_ACTION_DOWNCLOCK;
|
|
|
|
rdev->pm.dynpm_action_timeout = jiffies +
|
2009-12-22 22:02:16 +00:00
|
|
|
msecs_to_jiffies(RADEON_RECLOCK_DELAY_MS);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2010-05-03 05:13:14 +00:00
|
|
|
/* Note, radeon_pm_set_clocks is called with static_switch set
|
|
|
|
* to false since we want to wait for vbl to avoid flicker.
|
|
|
|
*/
|
2010-05-07 19:10:16 +00:00
|
|
|
if (rdev->pm.dynpm_planned_action != DYNPM_ACTION_NONE &&
|
|
|
|
jiffies > rdev->pm.dynpm_action_timeout) {
|
|
|
|
radeon_pm_get_dynpm_state(rdev);
|
|
|
|
radeon_pm_set_clocks(rdev);
|
2009-12-22 22:02:16 +00:00
|
|
|
}
|
DRM / radeon / KMS: Fix hibernation regression related to radeon PM (was: Re: [Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300)
There is a regression from 2.6.34 related to the recent radeon power
management changes, caused by attempting to cancel a delayed work
item that's never been scheduled. However, the code as is has some
other issues potentially leading to visible problems.
First, the mutex around cancel_delayed_work() in radeon_pm_suspend()
doesn't really serve any purpose, because cancel_delayed_work() only
tries to delete the work's timer. Moreover, it doesn't prevent the
work handler from running, so the handler can do some wrong things if
it wins the race and in that case it will rearm itself to do some
more wrong things going forward. So, I think it's better to wait for
the handler to return in case it's already been queued up for
execution. Also, it should be prevented from rearming itself in that
case.
Second, in radeon_set_pm_method() the cancel_delayed_work() is not
sufficient to prevent the work handler from running and queing up
itself for the next run (the failure scenario is that
cancel_delayed_work() returns 0, so the handler is run, it waits on
the mutex and then rearms itself after the mutex has been released),
so again the work handler should be prevented from rearming itself in
that case..
Finally, there's a potential deadlock in radeon_pm_fini(), because
cancel_delayed_work_sync() is called under rdev->pm.mutex, but the
work handler tries to acquire the same mutex (if it wins the race).
Fix the issues described above.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Reviewed-by: Alex Deucher <alexdeucher@gmail.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
2010-06-17 23:02:27 +00:00
|
|
|
|
|
|
|
queue_delayed_work(rdev->wq, &rdev->pm.dynpm_idle_work,
|
|
|
|
msecs_to_jiffies(RADEON_IDLE_LOOP_MS));
|
2009-12-22 22:02:16 +00:00
|
|
|
}
|
|
|
|
mutex_unlock(&rdev->pm.mutex);
|
2010-04-26 20:02:26 +00:00
|
|
|
ttm_bo_unlock_delayed_workqueue(&rdev->mman.bdev, resched);
|
2009-12-22 22:02:16 +00:00
|
|
|
}
|
|
|
|
|
2009-11-02 23:53:02 +00:00
|
|
|
/*
|
|
|
|
* Debugfs info
|
|
|
|
*/
|
|
|
|
#if defined(CONFIG_DEBUG_FS)
|
|
|
|
|
|
|
|
static int radeon_debugfs_pm_info(struct seq_file *m, void *data)
|
|
|
|
{
|
|
|
|
struct drm_info_node *node = (struct drm_info_node *) m->private;
|
|
|
|
struct drm_device *dev = node->minor->dev;
|
|
|
|
struct radeon_device *rdev = dev->dev_private;
|
|
|
|
|
2009-12-15 20:46:58 +00:00
|
|
|
seq_printf(m, "default engine clock: %u0 kHz\n", rdev->clock.default_sclk);
|
|
|
|
seq_printf(m, "current engine clock: %u0 kHz\n", radeon_get_engine_clock(rdev));
|
|
|
|
seq_printf(m, "default memory clock: %u0 kHz\n", rdev->clock.default_mclk);
|
|
|
|
if (rdev->asic->get_memory_clock)
|
|
|
|
seq_printf(m, "current memory clock: %u0 kHz\n", radeon_get_memory_clock(rdev));
|
2010-06-07 22:25:21 +00:00
|
|
|
if (rdev->pm.current_vddc)
|
|
|
|
seq_printf(m, "voltage: %u mV\n", rdev->pm.current_vddc);
|
2010-02-18 20:24:28 +00:00
|
|
|
if (rdev->asic->get_pcie_lanes)
|
|
|
|
seq_printf(m, "PCIE lanes: %d\n", radeon_get_pcie_lanes(rdev));
|
2009-11-02 23:53:02 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct drm_info_list radeon_pm_info_list[] = {
|
|
|
|
{"radeon_pm_info", radeon_debugfs_pm_info, 0, NULL},
|
|
|
|
};
|
|
|
|
#endif
|
|
|
|
|
2009-12-22 22:02:16 +00:00
|
|
|
static int radeon_debugfs_pm_init(struct radeon_device *rdev)
|
2009-11-02 23:53:02 +00:00
|
|
|
{
|
|
|
|
#if defined(CONFIG_DEBUG_FS)
|
|
|
|
return radeon_debugfs_add_files(rdev, radeon_pm_info_list, ARRAY_SIZE(radeon_pm_info_list));
|
|
|
|
#else
|
|
|
|
return 0;
|
|
|
|
#endif
|
|
|
|
}
|