2005-04-16 22:20:36 +00:00
|
|
|
/*
|
2008-06-10 16:20:58 +00:00
|
|
|
* zfcp device driver
|
2005-04-16 22:20:36 +00:00
|
|
|
*
|
2008-06-10 16:20:58 +00:00
|
|
|
* Implementation of FSF commands.
|
2005-04-16 22:20:36 +00:00
|
|
|
*
|
2010-02-17 10:18:56 +00:00
|
|
|
* Copyright IBM Corporation 2002, 2010
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
|
|
|
|
2008-12-25 12:39:53 +00:00
|
|
|
#define KMSG_COMPONENT "zfcp"
|
|
|
|
#define pr_fmt(fmt) KMSG_COMPONENT ": " fmt
|
|
|
|
|
2008-10-16 06:23:39 +00:00
|
|
|
#include <linux/blktrace_api.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 08:04:11 +00:00
|
|
|
#include <linux/slab.h>
|
2009-11-24 15:54:09 +00:00
|
|
|
#include <scsi/fc/fc_els.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include "zfcp_ext.h"
|
2009-11-24 15:54:08 +00:00
|
|
|
#include "zfcp_fc.h"
|
2009-08-18 13:43:08 +00:00
|
|
|
#include "zfcp_dbf.h"
|
2010-02-17 10:18:59 +00:00
|
|
|
#include "zfcp_qdio.h"
|
2010-02-17 10:18:50 +00:00
|
|
|
#include "zfcp_reqlist.h"
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:40 +00:00
|
|
|
static void zfcp_fsf_request_timeout_handler(unsigned long data)
|
|
|
|
{
|
|
|
|
struct zfcp_adapter *adapter = (struct zfcp_adapter *) data;
|
2010-07-16 13:37:43 +00:00
|
|
|
zfcp_qdio_siosl(adapter);
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_reopen(adapter, ZFCP_STATUS_COMMON_ERP_FAILED,
|
|
|
|
"fsrth_1", NULL);
|
2008-07-02 08:56:40 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void zfcp_fsf_start_timer(struct zfcp_fsf_req *fsf_req,
|
|
|
|
unsigned long timeout)
|
|
|
|
{
|
|
|
|
fsf_req->timer.function = zfcp_fsf_request_timeout_handler;
|
|
|
|
fsf_req->timer.data = (unsigned long) fsf_req->adapter;
|
|
|
|
fsf_req->timer.expires = jiffies + timeout;
|
|
|
|
add_timer(&fsf_req->timer);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void zfcp_fsf_start_erp_timer(struct zfcp_fsf_req *fsf_req)
|
|
|
|
{
|
|
|
|
BUG_ON(!fsf_req->erp_action);
|
|
|
|
fsf_req->timer.function = zfcp_erp_timeout_handler;
|
|
|
|
fsf_req->timer.data = (unsigned long) fsf_req->erp_action;
|
|
|
|
fsf_req->timer.expires = jiffies + 30 * HZ;
|
|
|
|
add_timer(&fsf_req->timer);
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/* association between FSF command and FSF QTCB type */
|
|
|
|
static u32 fsf_qtcb_type[] = {
|
|
|
|
[FSF_QTCB_FCP_CMND] = FSF_IO_COMMAND,
|
|
|
|
[FSF_QTCB_ABORT_FCP_CMND] = FSF_SUPPORT_COMMAND,
|
|
|
|
[FSF_QTCB_OPEN_PORT_WITH_DID] = FSF_SUPPORT_COMMAND,
|
|
|
|
[FSF_QTCB_OPEN_LUN] = FSF_SUPPORT_COMMAND,
|
|
|
|
[FSF_QTCB_CLOSE_LUN] = FSF_SUPPORT_COMMAND,
|
|
|
|
[FSF_QTCB_CLOSE_PORT] = FSF_SUPPORT_COMMAND,
|
|
|
|
[FSF_QTCB_CLOSE_PHYSICAL_PORT] = FSF_SUPPORT_COMMAND,
|
|
|
|
[FSF_QTCB_SEND_ELS] = FSF_SUPPORT_COMMAND,
|
|
|
|
[FSF_QTCB_SEND_GENERIC] = FSF_SUPPORT_COMMAND,
|
|
|
|
[FSF_QTCB_EXCHANGE_CONFIG_DATA] = FSF_CONFIG_COMMAND,
|
|
|
|
[FSF_QTCB_EXCHANGE_PORT_DATA] = FSF_PORT_COMMAND,
|
|
|
|
[FSF_QTCB_DOWNLOAD_CONTROL_FILE] = FSF_SUPPORT_COMMAND,
|
|
|
|
[FSF_QTCB_UPLOAD_CONTROL_FILE] = FSF_SUPPORT_COMMAND
|
|
|
|
};
|
|
|
|
|
2008-06-10 16:20:58 +00:00
|
|
|
static void zfcp_fsf_class_not_supp(struct zfcp_fsf_req *req)
|
|
|
|
{
|
2008-10-01 10:42:15 +00:00
|
|
|
dev_err(&req->adapter->ccw_device->dev, "FCP device not "
|
|
|
|
"operational because of an unsupported FC class\n");
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_shutdown(req->adapter, 0, "fscns_1", req);
|
2008-06-10 16:20:58 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
/**
|
|
|
|
* zfcp_fsf_req_free - free memory used by fsf request
|
|
|
|
* @fsf_req: pointer to struct zfcp_fsf_req
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2008-07-02 08:56:39 +00:00
|
|
|
void zfcp_fsf_req_free(struct zfcp_fsf_req *req)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-07-02 08:56:39 +00:00
|
|
|
if (likely(req->pool)) {
|
2009-08-18 13:43:15 +00:00
|
|
|
if (likely(req->qtcb))
|
|
|
|
mempool_free(req->qtcb, req->adapter->pool.qtcb_pool);
|
2008-07-02 08:56:39 +00:00
|
|
|
mempool_free(req, req->pool);
|
2006-09-18 20:28:49 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2009-08-18 13:43:15 +00:00
|
|
|
if (likely(req->qtcb))
|
|
|
|
kmem_cache_free(zfcp_data.qtcb_cache, req->qtcb);
|
|
|
|
kfree(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
static void zfcp_fsf_status_read_port_closed(struct zfcp_fsf_req *req)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2009-11-24 15:53:58 +00:00
|
|
|
unsigned long flags;
|
2008-07-02 08:56:39 +00:00
|
|
|
struct fsf_status_read_buffer *sr_buf = req->data;
|
|
|
|
struct zfcp_adapter *adapter = req->adapter;
|
|
|
|
struct zfcp_port *port;
|
2009-11-24 15:54:12 +00:00
|
|
|
int d_id = ntoh24(sr_buf->d_id);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-11-24 15:53:58 +00:00
|
|
|
read_lock_irqsave(&adapter->port_list_lock, flags);
|
|
|
|
list_for_each_entry(port, &adapter->port_list, list)
|
2008-07-02 08:56:39 +00:00
|
|
|
if (port->d_id == d_id) {
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_port_reopen(port, 0, "fssrpc1", req);
|
2009-11-24 15:53:58 +00:00
|
|
|
break;
|
2008-07-02 08:56:39 +00:00
|
|
|
}
|
2009-11-24 15:53:58 +00:00
|
|
|
read_unlock_irqrestore(&adapter->port_list_lock, flags);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2009-03-02 12:09:04 +00:00
|
|
|
static void zfcp_fsf_link_down_info_eval(struct zfcp_fsf_req *req, char *id,
|
2008-07-02 08:56:39 +00:00
|
|
|
struct fsf_link_down_info *link_down)
|
2005-09-13 19:51:16 +00:00
|
|
|
{
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_adapter *adapter = req->adapter;
|
2008-03-27 13:22:02 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (atomic_read(&adapter->status) & ZFCP_STATUS_ADAPTER_LINK_UNPLUGGED)
|
2005-12-01 01:48:41 +00:00
|
|
|
return;
|
|
|
|
|
|
|
|
atomic_set_mask(ZFCP_STATUS_ADAPTER_LINK_UNPLUGGED, &adapter->status);
|
2009-04-17 13:08:15 +00:00
|
|
|
|
2009-03-02 12:09:08 +00:00
|
|
|
zfcp_scsi_schedule_rports_block(adapter);
|
2005-12-01 01:48:41 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (!link_down)
|
2006-02-11 00:41:50 +00:00
|
|
|
goto out;
|
2005-12-01 01:48:41 +00:00
|
|
|
|
2005-09-13 19:51:16 +00:00
|
|
|
switch (link_down->error_code) {
|
|
|
|
case FSF_PSQ_LINK_NO_LIGHT:
|
2008-07-02 08:56:39 +00:00
|
|
|
dev_warn(&req->adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"There is no light signal from the local "
|
|
|
|
"fibre channel cable\n");
|
2005-09-13 19:51:16 +00:00
|
|
|
break;
|
|
|
|
case FSF_PSQ_LINK_WRAP_PLUG:
|
2008-07-02 08:56:39 +00:00
|
|
|
dev_warn(&req->adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"There is a wrap plug instead of a fibre "
|
|
|
|
"channel cable\n");
|
2005-09-13 19:51:16 +00:00
|
|
|
break;
|
|
|
|
case FSF_PSQ_LINK_NO_FCP:
|
2008-07-02 08:56:39 +00:00
|
|
|
dev_warn(&req->adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"The adjacent fibre channel node does not "
|
|
|
|
"support FCP\n");
|
2005-09-13 19:51:16 +00:00
|
|
|
break;
|
|
|
|
case FSF_PSQ_LINK_FIRMWARE_UPDATE:
|
2008-07-02 08:56:39 +00:00
|
|
|
dev_warn(&req->adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"The FCP device is suspended because of a "
|
|
|
|
"firmware update\n");
|
2008-06-10 16:20:58 +00:00
|
|
|
break;
|
2005-09-13 19:51:16 +00:00
|
|
|
case FSF_PSQ_LINK_INVALID_WWPN:
|
2008-07-02 08:56:39 +00:00
|
|
|
dev_warn(&req->adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"The FCP device detected a WWPN that is "
|
|
|
|
"duplicate or not valid\n");
|
2005-09-13 19:51:16 +00:00
|
|
|
break;
|
|
|
|
case FSF_PSQ_LINK_NO_NPIV_SUPPORT:
|
2008-07-02 08:56:39 +00:00
|
|
|
dev_warn(&req->adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"The fibre channel fabric does not support NPIV\n");
|
2005-09-13 19:51:16 +00:00
|
|
|
break;
|
|
|
|
case FSF_PSQ_LINK_NO_FCP_RESOURCES:
|
2008-07-02 08:56:39 +00:00
|
|
|
dev_warn(&req->adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"The FCP adapter cannot support more NPIV ports\n");
|
2005-09-13 19:51:16 +00:00
|
|
|
break;
|
|
|
|
case FSF_PSQ_LINK_NO_FABRIC_RESOURCES:
|
2008-07-02 08:56:39 +00:00
|
|
|
dev_warn(&req->adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"The adjacent switch cannot support "
|
|
|
|
"more NPIV ports\n");
|
2005-09-13 19:51:16 +00:00
|
|
|
break;
|
|
|
|
case FSF_PSQ_LINK_FABRIC_LOGIN_UNABLE:
|
2008-07-02 08:56:39 +00:00
|
|
|
dev_warn(&req->adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"The FCP adapter could not log in to the "
|
|
|
|
"fibre channel fabric\n");
|
2005-09-13 19:51:16 +00:00
|
|
|
break;
|
|
|
|
case FSF_PSQ_LINK_WWPN_ASSIGNMENT_CORRUPTED:
|
2008-07-02 08:56:39 +00:00
|
|
|
dev_warn(&req->adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"The WWPN assignment file on the FCP adapter "
|
|
|
|
"has been damaged\n");
|
2005-09-13 19:51:16 +00:00
|
|
|
break;
|
|
|
|
case FSF_PSQ_LINK_MODE_TABLE_CURRUPTED:
|
2008-07-02 08:56:39 +00:00
|
|
|
dev_warn(&req->adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"The mode table on the FCP adapter "
|
|
|
|
"has been damaged\n");
|
2005-09-13 19:51:16 +00:00
|
|
|
break;
|
|
|
|
case FSF_PSQ_LINK_NO_WWPN_ASSIGNMENT:
|
2008-07-02 08:56:39 +00:00
|
|
|
dev_warn(&req->adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"All NPIV ports on the FCP adapter have "
|
|
|
|
"been assigned\n");
|
2005-09-13 19:51:16 +00:00
|
|
|
break;
|
|
|
|
default:
|
2008-07-02 08:56:39 +00:00
|
|
|
dev_warn(&req->adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"The link between the FCP adapter and "
|
|
|
|
"the FC fabric is down\n");
|
2005-09-13 19:51:16 +00:00
|
|
|
}
|
2008-07-02 08:56:39 +00:00
|
|
|
out:
|
|
|
|
zfcp_erp_adapter_failed(adapter, id, req);
|
2005-09-13 19:51:16 +00:00
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
static void zfcp_fsf_status_read_link_down(struct zfcp_fsf_req *req)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-07-02 08:56:39 +00:00
|
|
|
struct fsf_status_read_buffer *sr_buf = req->data;
|
|
|
|
struct fsf_link_down_info *ldi =
|
|
|
|
(struct fsf_link_down_info *) &sr_buf->payload;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
switch (sr_buf->status_subtype) {
|
|
|
|
case FSF_STATUS_READ_SUB_NO_PHYSICAL_LINK:
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_fsf_link_down_info_eval(req, "fssrld1", ldi);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2008-07-02 08:56:39 +00:00
|
|
|
case FSF_STATUS_READ_SUB_FDISC_FAILED:
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_fsf_link_down_info_eval(req, "fssrld2", ldi);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2008-07-02 08:56:39 +00:00
|
|
|
case FSF_STATUS_READ_SUB_FIRMWARE_UPDATE:
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_fsf_link_down_info_eval(req, "fssrld3", NULL);
|
2008-07-02 08:56:39 +00:00
|
|
|
};
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
static void zfcp_fsf_status_read_handler(struct zfcp_fsf_req *req)
|
|
|
|
{
|
|
|
|
struct zfcp_adapter *adapter = req->adapter;
|
|
|
|
struct fsf_status_read_buffer *sr_buf = req->data;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (req->status & ZFCP_STATUS_FSFREQ_DISMISSED) {
|
2009-08-18 13:43:21 +00:00
|
|
|
zfcp_dbf_hba_fsf_unsol("dism", adapter->dbf, sr_buf);
|
2009-08-18 13:43:15 +00:00
|
|
|
mempool_free(sr_buf, adapter->pool.status_read_data);
|
2008-07-02 08:56:39 +00:00
|
|
|
zfcp_fsf_req_free(req);
|
|
|
|
return;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-08-18 13:43:21 +00:00
|
|
|
zfcp_dbf_hba_fsf_unsol("read", adapter->dbf, sr_buf);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
switch (sr_buf->status_type) {
|
|
|
|
case FSF_STATUS_READ_PORT_CLOSED:
|
|
|
|
zfcp_fsf_status_read_port_closed(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2008-07-02 08:56:39 +00:00
|
|
|
case FSF_STATUS_READ_INCOMING_ELS:
|
|
|
|
zfcp_fc_incoming_els(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2008-07-02 08:56:39 +00:00
|
|
|
case FSF_STATUS_READ_SENSE_DATA_AVAIL:
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2008-07-02 08:56:39 +00:00
|
|
|
case FSF_STATUS_READ_BIT_ERROR_THRESHOLD:
|
2008-10-01 10:42:15 +00:00
|
|
|
dev_warn(&adapter->ccw_device->dev,
|
|
|
|
"The error threshold for checksum statistics "
|
|
|
|
"has been exceeded\n");
|
2009-08-18 13:43:21 +00:00
|
|
|
zfcp_dbf_hba_berr(adapter->dbf, req);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2008-07-02 08:56:39 +00:00
|
|
|
case FSF_STATUS_READ_LINK_DOWN:
|
|
|
|
zfcp_fsf_status_read_link_down(req);
|
2010-07-16 13:37:39 +00:00
|
|
|
zfcp_fc_enqueue_event(adapter, FCH_EVT_LINKDOWN, 0);
|
2008-07-02 08:56:39 +00:00
|
|
|
break;
|
|
|
|
case FSF_STATUS_READ_LINK_UP:
|
|
|
|
dev_info(&adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"The local link has been restored\n");
|
2008-07-02 08:56:39 +00:00
|
|
|
/* All ports should be marked as ready to run again */
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_modify_adapter_status(adapter, "fssrh_1", NULL,
|
2008-07-02 08:56:39 +00:00
|
|
|
ZFCP_STATUS_COMMON_RUNNING,
|
|
|
|
ZFCP_SET);
|
|
|
|
zfcp_erp_adapter_reopen(adapter,
|
|
|
|
ZFCP_STATUS_ADAPTER_LINK_UNPLUGGED |
|
|
|
|
ZFCP_STATUS_COMMON_ERP_FAILED,
|
2009-03-02 12:09:04 +00:00
|
|
|
"fssrh_2", req);
|
2010-07-16 13:37:39 +00:00
|
|
|
zfcp_fc_enqueue_event(adapter, FCH_EVT_LINKUP, 0);
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
break;
|
|
|
|
case FSF_STATUS_READ_NOTIFICATION_LOST:
|
|
|
|
if (sr_buf->status_subtype & FSF_STATUS_READ_SUB_ACT_UPDATED)
|
2010-09-08 12:39:59 +00:00
|
|
|
zfcp_cfdc_adapter_access_changed(adapter);
|
2008-07-02 08:56:39 +00:00
|
|
|
if (sr_buf->status_subtype & FSF_STATUS_READ_SUB_INCOMING_ELS)
|
2009-11-24 15:54:06 +00:00
|
|
|
queue_work(adapter->work_queue, &adapter->scan_work);
|
2008-07-02 08:56:39 +00:00
|
|
|
break;
|
|
|
|
case FSF_STATUS_READ_CFDC_UPDATED:
|
2010-09-08 12:39:59 +00:00
|
|
|
zfcp_cfdc_adapter_access_changed(adapter);
|
2008-07-02 08:56:39 +00:00
|
|
|
break;
|
|
|
|
case FSF_STATUS_READ_FEATURE_UPDATE_ALERT:
|
|
|
|
adapter->adapter_features = sr_buf->payload.word[0];
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2009-08-18 13:43:15 +00:00
|
|
|
mempool_free(sr_buf, adapter->pool.status_read_data);
|
2008-07-02 08:56:39 +00:00
|
|
|
zfcp_fsf_req_free(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
atomic_inc(&adapter->stat_miss);
|
2009-08-18 13:43:17 +00:00
|
|
|
queue_work(adapter->work_queue, &adapter->stat_work);
|
2008-07-02 08:56:39 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
static void zfcp_fsf_fsfstatus_qual_eval(struct zfcp_fsf_req *req)
|
|
|
|
{
|
|
|
|
switch (req->qtcb->header.fsf_status_qual.word[0]) {
|
|
|
|
case FSF_SQ_FCP_RSP_AVAILABLE:
|
|
|
|
case FSF_SQ_INVOKE_LINK_TEST_PROCEDURE:
|
|
|
|
case FSF_SQ_NO_RETRY_POSSIBLE:
|
|
|
|
case FSF_SQ_ULP_DEPENDENT_ERP_REQUIRED:
|
|
|
|
return;
|
|
|
|
case FSF_SQ_COMMAND_ABORTED:
|
|
|
|
break;
|
|
|
|
case FSF_SQ_NO_RECOM:
|
|
|
|
dev_err(&req->adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"The FCP adapter reported a problem "
|
|
|
|
"that cannot be recovered\n");
|
2010-07-16 13:37:43 +00:00
|
|
|
zfcp_qdio_siosl(req->adapter);
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_shutdown(req->adapter, 0, "fsfsqe1", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
/* all non-return stats set FSFREQ_ERROR*/
|
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
static void zfcp_fsf_fsfstatus_eval(struct zfcp_fsf_req *req)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-07-02 08:56:39 +00:00
|
|
|
if (unlikely(req->status & ZFCP_STATUS_FSFREQ_ERROR))
|
|
|
|
return;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
switch (req->qtcb->header.fsf_status) {
|
|
|
|
case FSF_UNKNOWN_COMMAND:
|
|
|
|
dev_err(&req->adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"The FCP adapter does not recognize the command 0x%x\n",
|
2008-07-02 08:56:39 +00:00
|
|
|
req->qtcb->header.fsf_command);
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_shutdown(req->adapter, 0, "fsfse_1", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
|
|
|
break;
|
|
|
|
case FSF_ADAPTER_STATUS_AVAILABLE:
|
|
|
|
zfcp_fsf_fsfstatus_qual_eval(req);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
static void zfcp_fsf_protstatus_eval(struct zfcp_fsf_req *req)
|
|
|
|
{
|
|
|
|
struct zfcp_adapter *adapter = req->adapter;
|
|
|
|
struct fsf_qtcb *qtcb = req->qtcb;
|
|
|
|
union fsf_prot_status_qual *psq = &qtcb->prefix.prot_status_qual;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-08-18 13:43:21 +00:00
|
|
|
zfcp_dbf_hba_fsf_response(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (req->status & ZFCP_STATUS_FSFREQ_DISMISSED) {
|
2009-11-24 15:54:15 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2008-07-02 08:56:39 +00:00
|
|
|
return;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
switch (qtcb->prefix.prot_status) {
|
|
|
|
case FSF_PROT_GOOD:
|
|
|
|
case FSF_PROT_FSF_STATUS_PRESENTED:
|
|
|
|
return;
|
|
|
|
case FSF_PROT_QTCB_VERSION_ERROR:
|
|
|
|
dev_err(&adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"QTCB version 0x%x not supported by FCP adapter "
|
|
|
|
"(0x%x to 0x%x)\n", FSF_QTCB_CURRENT_VERSION,
|
|
|
|
psq->word[0], psq->word[1]);
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_shutdown(adapter, 0, "fspse_1", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
break;
|
|
|
|
case FSF_PROT_ERROR_STATE:
|
|
|
|
case FSF_PROT_SEQ_NUMB_ERROR:
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_reopen(adapter, 0, "fspse_2", req);
|
2009-11-24 15:54:15 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2008-07-02 08:56:39 +00:00
|
|
|
break;
|
|
|
|
case FSF_PROT_UNSUPP_QTCB_TYPE:
|
|
|
|
dev_err(&adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"The QTCB type is not supported by the FCP adapter\n");
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_shutdown(adapter, 0, "fspse_3", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
break;
|
|
|
|
case FSF_PROT_HOST_CONNECTION_INITIALIZING:
|
|
|
|
atomic_set_mask(ZFCP_STATUS_ADAPTER_HOST_CON_INIT,
|
|
|
|
&adapter->status);
|
|
|
|
break;
|
|
|
|
case FSF_PROT_DUPLICATE_REQUEST_ID:
|
|
|
|
dev_err(&adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"0x%Lx is an ambiguous request identifier\n",
|
2008-07-02 08:56:39 +00:00
|
|
|
(unsigned long long)qtcb->bottom.support.req_handle);
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_shutdown(adapter, 0, "fspse_4", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
break;
|
|
|
|
case FSF_PROT_LINK_DOWN:
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_fsf_link_down_info_eval(req, "fspse_5",
|
|
|
|
&psq->link_down_info);
|
2010-02-17 10:18:51 +00:00
|
|
|
/* go through reopen to flush pending requests */
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_reopen(adapter, 0, "fspse_6", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
break;
|
|
|
|
case FSF_PROT_REEST_QUEUE:
|
|
|
|
/* All ports should be marked as ready to run again */
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_modify_adapter_status(adapter, "fspse_7", NULL,
|
2008-07-02 08:56:39 +00:00
|
|
|
ZFCP_STATUS_COMMON_RUNNING,
|
|
|
|
ZFCP_SET);
|
|
|
|
zfcp_erp_adapter_reopen(adapter,
|
|
|
|
ZFCP_STATUS_ADAPTER_LINK_UNPLUGGED |
|
2009-03-02 12:09:04 +00:00
|
|
|
ZFCP_STATUS_COMMON_ERP_FAILED,
|
|
|
|
"fspse_8", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
break;
|
|
|
|
default:
|
|
|
|
dev_err(&adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"0x%x is not a valid transfer protocol status\n",
|
2008-07-02 08:56:39 +00:00
|
|
|
qtcb->prefix.prot_status);
|
2010-07-16 13:37:43 +00:00
|
|
|
zfcp_qdio_siosl(adapter);
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_shutdown(adapter, 0, "fspse_9", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
}
|
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
/**
|
|
|
|
* zfcp_fsf_req_complete - process completion of a FSF request
|
|
|
|
* @fsf_req: The FSF request that has been completed.
|
|
|
|
*
|
|
|
|
* When a request has been completed either from the FCP adapter,
|
|
|
|
* or it has been dismissed due to a queue shutdown, this function
|
|
|
|
* is called to process the completion status and trigger further
|
|
|
|
* events related to the FSF request.
|
|
|
|
*/
|
2009-08-18 13:43:13 +00:00
|
|
|
static void zfcp_fsf_req_complete(struct zfcp_fsf_req *req)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-07-02 08:56:39 +00:00
|
|
|
if (unlikely(req->fsf_command == FSF_QTCB_UNSOLICITED_STATUS)) {
|
|
|
|
zfcp_fsf_status_read_handler(req);
|
|
|
|
return;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
del_timer(&req->timer);
|
|
|
|
zfcp_fsf_protstatus_eval(req);
|
|
|
|
zfcp_fsf_fsfstatus_eval(req);
|
|
|
|
req->handler(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (req->erp_action)
|
2008-07-02 08:56:40 +00:00
|
|
|
zfcp_erp_notify(req->erp_action, 0);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (likely(req->status & ZFCP_STATUS_FSFREQ_CLEANUP))
|
|
|
|
zfcp_fsf_req_free(req);
|
|
|
|
else
|
2009-08-18 13:43:14 +00:00
|
|
|
complete(&req->completion);
|
2008-07-02 08:56:39 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-08-18 13:43:13 +00:00
|
|
|
/**
|
|
|
|
* zfcp_fsf_req_dismiss_all - dismiss all fsf requests
|
|
|
|
* @adapter: pointer to struct zfcp_adapter
|
|
|
|
*
|
|
|
|
* Never ever call this without shutting down the adapter first.
|
|
|
|
* Otherwise the adapter would continue using and corrupting s390 storage.
|
|
|
|
* Included BUG_ON() call to ensure this is done.
|
|
|
|
* ERP is supposed to be the only user of this function.
|
|
|
|
*/
|
|
|
|
void zfcp_fsf_req_dismiss_all(struct zfcp_adapter *adapter)
|
|
|
|
{
|
|
|
|
struct zfcp_fsf_req *req, *tmp;
|
|
|
|
LIST_HEAD(remove_queue);
|
|
|
|
|
|
|
|
BUG_ON(atomic_read(&adapter->status) & ZFCP_STATUS_ADAPTER_QDIOUP);
|
2010-02-17 10:18:50 +00:00
|
|
|
zfcp_reqlist_move(adapter->req_list, &remove_queue);
|
2009-08-18 13:43:13 +00:00
|
|
|
|
|
|
|
list_for_each_entry_safe(req, tmp, &remove_queue, list) {
|
|
|
|
list_del(&req->list);
|
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_DISMISSED;
|
|
|
|
zfcp_fsf_req_complete(req);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
static int zfcp_fsf_exchange_config_evaluate(struct zfcp_fsf_req *req)
|
|
|
|
{
|
2009-11-24 15:54:09 +00:00
|
|
|
struct fsf_qtcb_bottom_config *bottom = &req->qtcb->bottom.config;
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_adapter *adapter = req->adapter;
|
|
|
|
struct Scsi_Host *shost = adapter->scsi_host;
|
2009-11-24 15:54:09 +00:00
|
|
|
struct fc_els_flogi *nsp, *plogi;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-11-24 15:54:09 +00:00
|
|
|
/* adjust pointers for missing command code */
|
|
|
|
nsp = (struct fc_els_flogi *) ((u8 *)&bottom->nport_serv_param
|
|
|
|
- sizeof(u32));
|
|
|
|
plogi = (struct fc_els_flogi *) ((u8 *)&bottom->plogi_payload
|
|
|
|
- sizeof(u32));
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (req->data)
|
|
|
|
memcpy(req->data, bottom, sizeof(*bottom));
|
|
|
|
|
2009-11-24 15:54:09 +00:00
|
|
|
fc_host_port_name(shost) = nsp->fl_wwpn;
|
|
|
|
fc_host_node_name(shost) = nsp->fl_wwnn;
|
2009-11-24 15:54:12 +00:00
|
|
|
fc_host_port_id(shost) = ntoh24(bottom->s_id);
|
2008-07-02 08:56:39 +00:00
|
|
|
fc_host_speed(shost) = bottom->fc_link_speed;
|
|
|
|
fc_host_supported_classes(shost) = FC_COS_CLASS2 | FC_COS_CLASS3;
|
|
|
|
|
|
|
|
adapter->hydra_version = bottom->adapter_type;
|
2010-07-16 13:37:36 +00:00
|
|
|
adapter->timer_ticks = bottom->timer_interval & ZFCP_FSF_TIMER_INT_MASK;
|
2010-06-21 08:11:33 +00:00
|
|
|
adapter->stat_read_buf_num = max(bottom->status_read_buf_num,
|
|
|
|
(u16)FSF_STATUS_READS_RECOM);
|
2008-07-02 08:56:39 +00:00
|
|
|
|
|
|
|
if (fc_host_permanent_port_name(shost) == -1)
|
|
|
|
fc_host_permanent_port_name(shost) = fc_host_port_name(shost);
|
|
|
|
|
|
|
|
switch (bottom->fc_topology) {
|
|
|
|
case FSF_TOPO_P2P:
|
2009-11-24 15:54:12 +00:00
|
|
|
adapter->peer_d_id = ntoh24(bottom->peer_d_id);
|
2009-11-24 15:54:09 +00:00
|
|
|
adapter->peer_wwpn = plogi->fl_wwpn;
|
|
|
|
adapter->peer_wwnn = plogi->fl_wwnn;
|
2008-07-02 08:56:39 +00:00
|
|
|
fc_host_port_type(shost) = FC_PORTTYPE_PTP;
|
|
|
|
break;
|
|
|
|
case FSF_TOPO_FABRIC:
|
|
|
|
fc_host_port_type(shost) = FC_PORTTYPE_NPORT;
|
|
|
|
break;
|
|
|
|
case FSF_TOPO_AL:
|
|
|
|
fc_host_port_type(shost) = FC_PORTTYPE_NLPORT;
|
2009-05-15 11:18:18 +00:00
|
|
|
/* fall through */
|
2008-07-02 08:56:39 +00:00
|
|
|
default:
|
|
|
|
dev_err(&adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"Unknown or unsupported arbitrated loop "
|
|
|
|
"fibre channel topology detected\n");
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_shutdown(adapter, 0, "fsece_1", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
return -EIO;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2008-07-02 08:56:39 +00:00
|
|
|
|
2010-07-16 13:37:42 +00:00
|
|
|
zfcp_scsi_set_prot(adapter);
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
static void zfcp_fsf_exchange_config_data_handler(struct zfcp_fsf_req *req)
|
2008-06-10 16:20:58 +00:00
|
|
|
{
|
|
|
|
struct zfcp_adapter *adapter = req->adapter;
|
2008-07-02 08:56:39 +00:00
|
|
|
struct fsf_qtcb *qtcb = req->qtcb;
|
|
|
|
struct fsf_qtcb_bottom_config *bottom = &qtcb->bottom.config;
|
|
|
|
struct Scsi_Host *shost = adapter->scsi_host;
|
2008-06-10 16:20:58 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (req->status & ZFCP_STATUS_FSFREQ_ERROR)
|
|
|
|
return;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
adapter->fsf_lic_version = bottom->lic_version;
|
|
|
|
adapter->adapter_features = bottom->adapter_features;
|
|
|
|
adapter->connection_features = bottom->connection_features;
|
|
|
|
adapter->peer_wwpn = 0;
|
|
|
|
adapter->peer_wwnn = 0;
|
|
|
|
adapter->peer_d_id = 0;
|
2005-09-13 19:50:38 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
switch (qtcb->header.fsf_status) {
|
|
|
|
case FSF_GOOD:
|
|
|
|
if (zfcp_fsf_exchange_config_evaluate(req))
|
|
|
|
return;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (bottom->max_qtcb_size < sizeof(struct fsf_qtcb)) {
|
|
|
|
dev_err(&adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"FCP adapter maximum QTCB size (%d bytes) "
|
|
|
|
"is too small\n",
|
|
|
|
bottom->max_qtcb_size);
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_shutdown(adapter, 0, "fsecdh1", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
atomic_set_mask(ZFCP_STATUS_ADAPTER_XCONFIG_OK,
|
|
|
|
&adapter->status);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2008-07-02 08:56:39 +00:00
|
|
|
case FSF_EXCHANGE_CONFIG_DATA_INCOMPLETE:
|
|
|
|
fc_host_node_name(shost) = 0;
|
|
|
|
fc_host_port_name(shost) = 0;
|
|
|
|
fc_host_port_id(shost) = 0;
|
|
|
|
fc_host_speed(shost) = FC_PORTSPEED_UNKNOWN;
|
|
|
|
fc_host_port_type(shost) = FC_PORTTYPE_UNKNOWN;
|
|
|
|
adapter->hydra_version = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
atomic_set_mask(ZFCP_STATUS_ADAPTER_XCONFIG_OK,
|
|
|
|
&adapter->status);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_fsf_link_down_info_eval(req, "fsecdh2",
|
2008-07-02 08:56:39 +00:00
|
|
|
&qtcb->header.fsf_status_qual.link_down_info);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2008-07-02 08:56:39 +00:00
|
|
|
default:
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_shutdown(adapter, 0, "fsecdh3", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
return;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (adapter->adapter_features & FSF_FEATURE_HBAAPI_MANAGEMENT) {
|
|
|
|
adapter->hardware_version = bottom->hardware_version;
|
|
|
|
memcpy(fc_host_serial_number(shost), bottom->serial_number,
|
|
|
|
min(FC_SERIAL_NUMBER_SIZE, 17));
|
|
|
|
EBCASC(fc_host_serial_number(shost),
|
|
|
|
min(FC_SERIAL_NUMBER_SIZE, 17));
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (FSF_QTCB_CURRENT_VERSION < bottom->low_qtcb_version) {
|
|
|
|
dev_err(&adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"The FCP adapter only supports newer "
|
|
|
|
"control block versions\n");
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_shutdown(adapter, 0, "fsecdh4", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
if (FSF_QTCB_CURRENT_VERSION > bottom->high_qtcb_version) {
|
|
|
|
dev_err(&adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"The FCP adapter only supports older "
|
|
|
|
"control block versions\n");
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_shutdown(adapter, 0, "fsecdh5", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
}
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
static void zfcp_fsf_exchange_port_evaluate(struct zfcp_fsf_req *req)
|
|
|
|
{
|
|
|
|
struct zfcp_adapter *adapter = req->adapter;
|
|
|
|
struct fsf_qtcb_bottom_port *bottom = &req->qtcb->bottom.port;
|
|
|
|
struct Scsi_Host *shost = adapter->scsi_host;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (req->data)
|
|
|
|
memcpy(req->data, bottom, sizeof(*bottom));
|
2006-01-05 08:56:47 +00:00
|
|
|
|
2009-03-02 12:09:06 +00:00
|
|
|
if (adapter->connection_features & FSF_FEATURE_NPIV_MODE) {
|
2008-07-02 08:56:39 +00:00
|
|
|
fc_host_permanent_port_name(shost) = bottom->wwpn;
|
2009-03-02 12:09:06 +00:00
|
|
|
fc_host_port_type(shost) = FC_PORTTYPE_NPIV;
|
|
|
|
} else
|
2008-07-02 08:56:39 +00:00
|
|
|
fc_host_permanent_port_name(shost) = fc_host_port_name(shost);
|
|
|
|
fc_host_maxframe_size(shost) = bottom->maximum_frame_size;
|
|
|
|
fc_host_supported_speeds(shost) = bottom->supported_speed;
|
2010-02-17 10:18:58 +00:00
|
|
|
memcpy(fc_host_supported_fc4s(shost), bottom->supported_fc4_types,
|
|
|
|
FC_FC4_LIST_SIZE);
|
|
|
|
memcpy(fc_host_active_fc4s(shost), bottom->active_fc4_types,
|
|
|
|
FC_FC4_LIST_SIZE);
|
2008-07-02 08:56:39 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
static void zfcp_fsf_exchange_port_data_handler(struct zfcp_fsf_req *req)
|
|
|
|
{
|
|
|
|
struct fsf_qtcb *qtcb = req->qtcb;
|
|
|
|
|
|
|
|
if (req->status & ZFCP_STATUS_FSFREQ_ERROR)
|
|
|
|
return;
|
|
|
|
|
|
|
|
switch (qtcb->header.fsf_status) {
|
|
|
|
case FSF_GOOD:
|
|
|
|
zfcp_fsf_exchange_port_evaluate(req);
|
|
|
|
break;
|
|
|
|
case FSF_EXCHANGE_CONFIG_DATA_INCOMPLETE:
|
|
|
|
zfcp_fsf_exchange_port_evaluate(req);
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_fsf_link_down_info_eval(req, "fsepdh1",
|
2008-07-02 08:56:39 +00:00
|
|
|
&qtcb->header.fsf_status_qual.link_down_info);
|
2005-09-13 19:51:16 +00:00
|
|
|
break;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2008-07-02 08:56:39 +00:00
|
|
|
}
|
2008-05-19 10:17:37 +00:00
|
|
|
|
2009-08-18 13:43:15 +00:00
|
|
|
static struct zfcp_fsf_req *zfcp_fsf_alloc(mempool_t *pool)
|
2008-07-02 08:56:39 +00:00
|
|
|
{
|
|
|
|
struct zfcp_fsf_req *req;
|
2009-08-18 13:43:15 +00:00
|
|
|
|
|
|
|
if (likely(pool))
|
|
|
|
req = mempool_alloc(pool, GFP_ATOMIC);
|
|
|
|
else
|
|
|
|
req = kmalloc(sizeof(*req), GFP_ATOMIC);
|
|
|
|
|
|
|
|
if (unlikely(!req))
|
2008-07-02 08:56:39 +00:00
|
|
|
return NULL;
|
2009-08-18 13:43:15 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
memset(req, 0, sizeof(*req));
|
2008-11-04 15:35:07 +00:00
|
|
|
req->pool = pool;
|
2008-07-02 08:56:39 +00:00
|
|
|
return req;
|
|
|
|
}
|
|
|
|
|
2009-08-18 13:43:15 +00:00
|
|
|
static struct fsf_qtcb *zfcp_qtcb_alloc(mempool_t *pool)
|
2008-07-02 08:56:39 +00:00
|
|
|
{
|
2009-08-18 13:43:15 +00:00
|
|
|
struct fsf_qtcb *qtcb;
|
2008-07-02 08:56:39 +00:00
|
|
|
|
|
|
|
if (likely(pool))
|
|
|
|
qtcb = mempool_alloc(pool, GFP_ATOMIC);
|
|
|
|
else
|
2009-08-18 13:43:15 +00:00
|
|
|
qtcb = kmem_cache_alloc(zfcp_data.qtcb_cache, GFP_ATOMIC);
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (unlikely(!qtcb))
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
memset(qtcb, 0, sizeof(*qtcb));
|
2009-08-18 13:43:15 +00:00
|
|
|
return qtcb;
|
2008-07-02 08:56:39 +00:00
|
|
|
}
|
|
|
|
|
2009-08-18 13:43:19 +00:00
|
|
|
static struct zfcp_fsf_req *zfcp_fsf_req_create(struct zfcp_qdio *qdio,
|
2010-04-30 16:09:34 +00:00
|
|
|
u32 fsf_cmd, u32 sbtype,
|
|
|
|
mempool_t *pool)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2009-08-18 13:43:19 +00:00
|
|
|
struct zfcp_adapter *adapter = qdio->adapter;
|
2009-08-18 13:43:15 +00:00
|
|
|
struct zfcp_fsf_req *req = zfcp_fsf_alloc(pool);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (unlikely(!req))
|
2009-07-13 13:06:04 +00:00
|
|
|
return ERR_PTR(-ENOMEM);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (adapter->req_no == 0)
|
|
|
|
adapter->req_no++;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
INIT_LIST_HEAD(&req->list);
|
|
|
|
init_timer(&req->timer);
|
2009-08-18 13:43:14 +00:00
|
|
|
init_completion(&req->completion);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
req->adapter = adapter;
|
|
|
|
req->fsf_command = fsf_cmd;
|
2009-03-02 12:08:58 +00:00
|
|
|
req->req_id = adapter->req_no;
|
2008-07-02 08:56:39 +00:00
|
|
|
|
2009-08-18 13:43:15 +00:00
|
|
|
if (likely(fsf_cmd != FSF_QTCB_UNSOLICITED_STATUS)) {
|
|
|
|
if (likely(pool))
|
|
|
|
req->qtcb = zfcp_qtcb_alloc(adapter->pool.qtcb_pool);
|
|
|
|
else
|
|
|
|
req->qtcb = zfcp_qtcb_alloc(NULL);
|
|
|
|
|
|
|
|
if (unlikely(!req->qtcb)) {
|
|
|
|
zfcp_fsf_req_free(req);
|
|
|
|
return ERR_PTR(-ENOMEM);
|
|
|
|
}
|
|
|
|
|
2010-02-17 10:18:55 +00:00
|
|
|
req->seq_no = adapter->fsf_req_seq_no;
|
2009-08-18 13:43:19 +00:00
|
|
|
req->qtcb->prefix.req_seq_no = adapter->fsf_req_seq_no;
|
2008-07-02 08:56:39 +00:00
|
|
|
req->qtcb->prefix.req_id = req->req_id;
|
|
|
|
req->qtcb->prefix.ulp_info = 26;
|
|
|
|
req->qtcb->prefix.qtcb_type = fsf_qtcb_type[req->fsf_command];
|
|
|
|
req->qtcb->prefix.qtcb_version = FSF_QTCB_CURRENT_VERSION;
|
|
|
|
req->qtcb->header.req_handle = req->req_id;
|
|
|
|
req->qtcb->header.fsf_command = req->fsf_command;
|
|
|
|
}
|
|
|
|
|
2010-04-30 16:09:34 +00:00
|
|
|
zfcp_qdio_req_init(adapter->qdio, &req->qdio_req, req->req_id, sbtype,
|
|
|
|
req->qtcb, sizeof(struct fsf_qtcb));
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
return req;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
static int zfcp_fsf_req_send(struct zfcp_fsf_req *req)
|
|
|
|
{
|
|
|
|
struct zfcp_adapter *adapter = req->adapter;
|
2009-08-18 13:43:19 +00:00
|
|
|
struct zfcp_qdio *qdio = adapter->qdio;
|
2010-02-17 10:18:50 +00:00
|
|
|
int with_qtcb = (req->qtcb != NULL);
|
2010-02-17 10:18:49 +00:00
|
|
|
int req_id = req->req_id;
|
2008-07-02 08:56:39 +00:00
|
|
|
|
2010-02-17 10:18:50 +00:00
|
|
|
zfcp_reqlist_add(adapter->req_list, req);
|
2008-07-02 08:56:39 +00:00
|
|
|
|
2010-07-16 13:37:38 +00:00
|
|
|
req->qdio_req.qdio_outb_usage = atomic_read(&qdio->req_q_free);
|
2008-07-02 08:56:39 +00:00
|
|
|
req->issued = get_clock();
|
2010-02-17 10:18:59 +00:00
|
|
|
if (zfcp_qdio_send(qdio, &req->qdio_req)) {
|
2008-07-02 08:56:39 +00:00
|
|
|
del_timer(&req->timer);
|
2008-11-04 15:35:08 +00:00
|
|
|
/* lookup request again, list might have changed */
|
2010-02-17 10:18:50 +00:00
|
|
|
zfcp_reqlist_find_rm(adapter->req_list, req_id);
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_reopen(adapter, 0, "fsrs__1", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
return -EIO;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Don't increase for unsolicited status */
|
2009-04-17 13:08:01 +00:00
|
|
|
if (with_qtcb)
|
2008-07-02 08:56:39 +00:00
|
|
|
adapter->fsf_req_seq_no++;
|
2009-03-02 12:08:58 +00:00
|
|
|
adapter->req_no++;
|
2008-07-02 08:56:39 +00:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* zfcp_fsf_status_read - send status read request
|
|
|
|
* @adapter: pointer to struct zfcp_adapter
|
|
|
|
* @req_flags: request flags
|
|
|
|
* Returns: 0 on success, ERROR otherwise
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2009-08-18 13:43:19 +00:00
|
|
|
int zfcp_fsf_status_read(struct zfcp_qdio *qdio)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2009-08-18 13:43:19 +00:00
|
|
|
struct zfcp_adapter *adapter = qdio->adapter;
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_fsf_req *req;
|
|
|
|
struct fsf_status_read_buffer *sr_buf;
|
|
|
|
int retval = -EIO;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_lock_irq(&qdio->req_q_lock);
|
2010-04-30 16:09:35 +00:00
|
|
|
if (zfcp_qdio_sbal_get(qdio))
|
2008-07-02 08:56:39 +00:00
|
|
|
goto out;
|
|
|
|
|
2010-04-30 16:09:34 +00:00
|
|
|
req = zfcp_fsf_req_create(qdio, FSF_QTCB_UNSOLICITED_STATUS, 0,
|
2009-08-18 13:43:15 +00:00
|
|
|
adapter->pool.status_read_req);
|
2008-08-21 11:43:37 +00:00
|
|
|
if (IS_ERR(req)) {
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = PTR_ERR(req);
|
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2009-08-18 13:43:15 +00:00
|
|
|
sr_buf = mempool_alloc(adapter->pool.status_read_data, GFP_ATOMIC);
|
2008-07-02 08:56:39 +00:00
|
|
|
if (!sr_buf) {
|
|
|
|
retval = -ENOMEM;
|
|
|
|
goto failed_buf;
|
|
|
|
}
|
|
|
|
memset(sr_buf, 0, sizeof(*sr_buf));
|
|
|
|
req->data = sr_buf;
|
2010-04-30 16:09:34 +00:00
|
|
|
|
|
|
|
zfcp_qdio_fill_next(qdio, &req->qdio_req, sr_buf, sizeof(*sr_buf));
|
|
|
|
zfcp_qdio_set_sbale_last(qdio, &req->qdio_req);
|
2005-09-13 19:47:52 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = zfcp_fsf_req_send(req);
|
|
|
|
if (retval)
|
|
|
|
goto failed_req_send;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
goto out;
|
|
|
|
|
|
|
|
failed_req_send:
|
2009-08-18 13:43:15 +00:00
|
|
|
mempool_free(sr_buf, adapter->pool.status_read_data);
|
2008-07-02 08:56:39 +00:00
|
|
|
failed_buf:
|
|
|
|
zfcp_fsf_req_free(req);
|
2009-08-18 13:43:21 +00:00
|
|
|
zfcp_dbf_hba_fsf_unsol("fail", adapter->dbf, NULL);
|
2008-07-02 08:56:39 +00:00
|
|
|
out:
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2008-07-02 08:56:39 +00:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void zfcp_fsf_abort_fcp_command_handler(struct zfcp_fsf_req *req)
|
|
|
|
{
|
2010-09-08 12:39:55 +00:00
|
|
|
struct scsi_device *sdev = req->data;
|
|
|
|
struct zfcp_scsi_dev *zfcp_sdev = sdev_to_zfcp(sdev);
|
2008-07-02 08:56:39 +00:00
|
|
|
union fsf_status_qual *fsq = &req->qtcb->header.fsf_status_qual;
|
|
|
|
|
|
|
|
if (req->status & ZFCP_STATUS_FSFREQ_ERROR)
|
|
|
|
return;
|
|
|
|
|
|
|
|
switch (req->qtcb->header.fsf_status) {
|
2005-04-16 22:20:36 +00:00
|
|
|
case FSF_PORT_HANDLE_NOT_VALID:
|
2008-07-02 08:56:39 +00:00
|
|
|
if (fsq->word[0] == fsq->word[1]) {
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_erp_adapter_reopen(zfcp_sdev->port->adapter, 0,
|
2009-03-02 12:09:04 +00:00
|
|
|
"fsafch1", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
case FSF_LUN_HANDLE_NOT_VALID:
|
2008-07-02 08:56:39 +00:00
|
|
|
if (fsq->word[0] == fsq->word[1]) {
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_erp_port_reopen(zfcp_sdev->port, 0, "fsafch2",
|
|
|
|
req);
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
break;
|
|
|
|
case FSF_FCP_COMMAND_DOES_NOT_EXIST:
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ABORTNOTNEEDED;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_PORT_BOXED:
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_erp_port_boxed(zfcp_sdev->port, "fsafch3", req);
|
2009-11-24 15:54:15 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_LUN_BOXED:
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_erp_lun_boxed(sdev, "fsafch4", req);
|
2009-11-24 15:54:15 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_ADAPTER_STATUS_AVAILABLE:
|
2008-07-02 08:56:39 +00:00
|
|
|
switch (fsq->word[0]) {
|
2005-04-16 22:20:36 +00:00
|
|
|
case FSF_SQ_INVOKE_LINK_TEST_PROCEDURE:
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_fc_test_link(zfcp_sdev->port);
|
2009-05-15 11:18:18 +00:00
|
|
|
/* fall through */
|
2005-04-16 22:20:36 +00:00
|
|
|
case FSF_SQ_ULP_DEPENDENT_ERP_REQUIRED:
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case FSF_GOOD:
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ABORTSUCCEEDED;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2010-09-08 12:39:55 +00:00
|
|
|
* zfcp_fsf_abort_fcp_cmnd - abort running SCSI command
|
|
|
|
* @scmnd: The SCSI command to abort
|
2008-07-02 08:56:39 +00:00
|
|
|
* Returns: pointer to struct zfcp_fsf_req
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
|
|
|
|
2010-09-08 12:39:55 +00:00
|
|
|
struct zfcp_fsf_req *zfcp_fsf_abort_fcp_cmnd(struct scsi_cmnd *scmnd)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_fsf_req *req = NULL;
|
2010-09-08 12:39:55 +00:00
|
|
|
struct scsi_device *sdev = scmnd->device;
|
|
|
|
struct zfcp_scsi_dev *zfcp_sdev = sdev_to_zfcp(sdev);
|
|
|
|
struct zfcp_qdio *qdio = zfcp_sdev->port->adapter->qdio;
|
|
|
|
unsigned long old_req_id = (unsigned long) scmnd->host_scribble;
|
2005-09-13 19:50:38 +00:00
|
|
|
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_lock_irq(&qdio->req_q_lock);
|
2010-04-30 16:09:35 +00:00
|
|
|
if (zfcp_qdio_sbal_get(qdio))
|
2008-07-02 08:56:39 +00:00
|
|
|
goto out;
|
2009-08-18 13:43:19 +00:00
|
|
|
req = zfcp_fsf_req_create(qdio, FSF_QTCB_ABORT_FCP_CMND,
|
2010-04-30 16:09:34 +00:00
|
|
|
SBAL_FLAGS0_TYPE_READ,
|
2009-08-18 13:43:19 +00:00
|
|
|
qdio->adapter->pool.scsi_abort);
|
2008-11-26 17:07:37 +00:00
|
|
|
if (IS_ERR(req)) {
|
|
|
|
req = NULL;
|
2008-07-02 08:56:39 +00:00
|
|
|
goto out;
|
2008-11-26 17:07:37 +00:00
|
|
|
}
|
2006-09-18 20:29:56 +00:00
|
|
|
|
2010-09-08 12:39:55 +00:00
|
|
|
if (unlikely(!(atomic_read(&zfcp_sdev->status) &
|
2008-07-02 08:56:39 +00:00
|
|
|
ZFCP_STATUS_COMMON_UNBLOCKED)))
|
|
|
|
goto out_error_free;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-04-30 16:09:34 +00:00
|
|
|
zfcp_qdio_set_sbale_last(qdio, &req->qdio_req);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-09-08 12:39:55 +00:00
|
|
|
req->data = zfcp_sdev;
|
2008-07-02 08:56:39 +00:00
|
|
|
req->handler = zfcp_fsf_abort_fcp_command_handler;
|
2010-09-08 12:39:55 +00:00
|
|
|
req->qtcb->header.lun_handle = zfcp_sdev->lun_handle;
|
|
|
|
req->qtcb->header.port_handle = zfcp_sdev->port->handle;
|
2008-07-02 08:56:39 +00:00
|
|
|
req->qtcb->bottom.support.req_handle = (u64) old_req_id;
|
|
|
|
|
|
|
|
zfcp_fsf_start_timer(req, ZFCP_SCSI_ER_TIMEOUT);
|
|
|
|
if (!zfcp_fsf_req_send(req))
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
out_error_free:
|
|
|
|
zfcp_fsf_req_free(req);
|
|
|
|
req = NULL;
|
|
|
|
out:
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2008-07-02 08:56:39 +00:00
|
|
|
return req;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
static void zfcp_fsf_send_ct_handler(struct zfcp_fsf_req *req)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_adapter *adapter = req->adapter;
|
2009-11-24 15:54:13 +00:00
|
|
|
struct zfcp_fsf_ct_els *ct = req->data;
|
2008-07-02 08:56:39 +00:00
|
|
|
struct fsf_qtcb_header *header = &req->qtcb->header;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-11-24 15:54:13 +00:00
|
|
|
ct->status = -EINVAL;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (req->status & ZFCP_STATUS_FSFREQ_ERROR)
|
2005-04-16 22:20:36 +00:00
|
|
|
goto skip_fsfstatus;
|
|
|
|
|
|
|
|
switch (header->fsf_status) {
|
|
|
|
case FSF_GOOD:
|
2009-08-18 13:43:21 +00:00
|
|
|
zfcp_dbf_san_ct_response(req);
|
2009-11-24 15:54:13 +00:00
|
|
|
ct->status = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_SERVICE_CLASS_NOT_SUPPORTED:
|
2008-07-02 08:56:39 +00:00
|
|
|
zfcp_fsf_class_not_supp(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_ADAPTER_STATUS_AVAILABLE:
|
|
|
|
switch (header->fsf_status_qual.word[0]){
|
|
|
|
case FSF_SQ_INVOKE_LINK_TEST_PROCEDURE:
|
|
|
|
case FSF_SQ_ULP_DEPENDENT_ERP_REQUIRED:
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case FSF_ACCESS_DENIED:
|
|
|
|
break;
|
|
|
|
case FSF_PORT_BOXED:
|
2009-11-24 15:54:15 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2008-07-02 08:56:39 +00:00
|
|
|
case FSF_PORT_HANDLE_NOT_VALID:
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_reopen(adapter, 0, "fsscth1", req);
|
2009-05-15 11:18:18 +00:00
|
|
|
/* fall through */
|
2008-07-02 08:56:39 +00:00
|
|
|
case FSF_GENERIC_COMMAND_REJECTED:
|
2005-04-16 22:20:36 +00:00
|
|
|
case FSF_PAYLOAD_SIZE_MISMATCH:
|
|
|
|
case FSF_REQUEST_SIZE_TOO_LARGE:
|
|
|
|
case FSF_RESPONSE_SIZE_TOO_LARGE:
|
|
|
|
case FSF_SBAL_MISMATCH:
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
skip_fsfstatus:
|
2009-11-24 15:54:13 +00:00
|
|
|
if (ct->handler)
|
|
|
|
ct->handler(ct->handler_data);
|
2008-07-02 08:56:39 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-04-30 16:09:34 +00:00
|
|
|
static void zfcp_fsf_setup_ct_els_unchained(struct zfcp_qdio *qdio,
|
|
|
|
struct zfcp_qdio_req *q_req,
|
2009-07-13 13:06:06 +00:00
|
|
|
struct scatterlist *sg_req,
|
|
|
|
struct scatterlist *sg_resp)
|
|
|
|
{
|
2010-04-30 16:09:34 +00:00
|
|
|
zfcp_qdio_fill_next(qdio, q_req, sg_virt(sg_req), sg_req->length);
|
|
|
|
zfcp_qdio_fill_next(qdio, q_req, sg_virt(sg_resp), sg_resp->length);
|
|
|
|
zfcp_qdio_set_sbale_last(qdio, q_req);
|
2009-07-13 13:06:06 +00:00
|
|
|
}
|
|
|
|
|
2008-12-19 15:57:01 +00:00
|
|
|
static int zfcp_fsf_setup_ct_els_sbals(struct zfcp_fsf_req *req,
|
|
|
|
struct scatterlist *sg_req,
|
2010-07-16 13:37:37 +00:00
|
|
|
struct scatterlist *sg_resp)
|
2008-07-02 08:56:39 +00:00
|
|
|
{
|
2009-08-18 13:43:18 +00:00
|
|
|
struct zfcp_adapter *adapter = req->adapter;
|
|
|
|
u32 feat = adapter->adapter_features;
|
2008-07-02 08:56:39 +00:00
|
|
|
int bytes;
|
|
|
|
|
2008-12-19 15:57:01 +00:00
|
|
|
if (!(feat & FSF_FEATURE_ELS_CT_CHAINED_SBALS)) {
|
2010-04-30 16:09:34 +00:00
|
|
|
if (!zfcp_qdio_sg_one_sbale(sg_req) ||
|
|
|
|
!zfcp_qdio_sg_one_sbale(sg_resp))
|
2008-12-19 15:57:01 +00:00
|
|
|
return -EOPNOTSUPP;
|
|
|
|
|
2010-04-30 16:09:34 +00:00
|
|
|
zfcp_fsf_setup_ct_els_unchained(adapter->qdio, &req->qdio_req,
|
|
|
|
sg_req, sg_resp);
|
2009-07-13 13:06:06 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* use single, unchained SBAL if it can hold the request */
|
2010-06-21 08:11:31 +00:00
|
|
|
if (zfcp_qdio_sg_one_sbale(sg_req) && zfcp_qdio_sg_one_sbale(sg_resp)) {
|
2010-04-30 16:09:34 +00:00
|
|
|
zfcp_fsf_setup_ct_els_unchained(adapter->qdio, &req->qdio_req,
|
|
|
|
sg_req, sg_resp);
|
2008-12-19 15:57:01 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-07-16 13:37:37 +00:00
|
|
|
bytes = zfcp_qdio_sbals_from_sg(adapter->qdio, &req->qdio_req, sg_req);
|
2008-07-02 08:56:39 +00:00
|
|
|
if (bytes <= 0)
|
2009-07-13 13:06:07 +00:00
|
|
|
return -EIO;
|
2010-07-16 13:37:42 +00:00
|
|
|
zfcp_qdio_set_sbale_last(adapter->qdio, &req->qdio_req);
|
2008-07-02 08:56:39 +00:00
|
|
|
req->qtcb->bottom.support.req_buf_length = bytes;
|
2010-04-30 16:09:34 +00:00
|
|
|
zfcp_qdio_skip_to_last_sbale(&req->qdio_req);
|
2008-07-02 08:56:39 +00:00
|
|
|
|
2010-02-17 10:18:59 +00:00
|
|
|
bytes = zfcp_qdio_sbals_from_sg(adapter->qdio, &req->qdio_req,
|
2010-07-16 13:37:37 +00:00
|
|
|
sg_resp);
|
2009-09-24 08:23:21 +00:00
|
|
|
req->qtcb->bottom.support.resp_buf_length = bytes;
|
2008-07-02 08:56:39 +00:00
|
|
|
if (bytes <= 0)
|
2009-07-13 13:06:07 +00:00
|
|
|
return -EIO;
|
2010-07-16 13:37:42 +00:00
|
|
|
zfcp_qdio_set_sbale_last(adapter->qdio, &req->qdio_req);
|
2009-08-18 13:43:26 +00:00
|
|
|
|
2009-09-24 08:23:21 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int zfcp_fsf_setup_ct_els(struct zfcp_fsf_req *req,
|
|
|
|
struct scatterlist *sg_req,
|
|
|
|
struct scatterlist *sg_resp,
|
2010-07-16 13:37:37 +00:00
|
|
|
unsigned int timeout)
|
2009-09-24 08:23:21 +00:00
|
|
|
{
|
|
|
|
int ret;
|
|
|
|
|
2010-07-16 13:37:37 +00:00
|
|
|
ret = zfcp_fsf_setup_ct_els_sbals(req, sg_req, sg_resp);
|
2009-09-24 08:23:21 +00:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2009-08-18 13:43:26 +00:00
|
|
|
/* common settings for ct/gs and els requests */
|
2010-01-14 16:19:02 +00:00
|
|
|
if (timeout > 255)
|
|
|
|
timeout = 255; /* max value accepted by hardware */
|
2009-08-18 13:43:26 +00:00
|
|
|
req->qtcb->bottom.support.service_class = FSF_CLASS_3;
|
2010-01-14 16:19:02 +00:00
|
|
|
req->qtcb->bottom.support.timeout = timeout;
|
|
|
|
zfcp_fsf_start_timer(req, (timeout + 10) * HZ);
|
2008-07-02 08:56:39 +00:00
|
|
|
|
|
|
|
return 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2008-07-02 08:56:39 +00:00
|
|
|
* zfcp_fsf_send_ct - initiate a Generic Service request (FC-GS)
|
|
|
|
* @ct: pointer to struct zfcp_send_ct with data for request
|
|
|
|
* @pool: if non-null this mempool is used to allocate struct zfcp_fsf_req
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2009-11-24 15:54:13 +00:00
|
|
|
int zfcp_fsf_send_ct(struct zfcp_fc_wka_port *wka_port,
|
2010-01-14 16:19:02 +00:00
|
|
|
struct zfcp_fsf_ct_els *ct, mempool_t *pool,
|
|
|
|
unsigned int timeout)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2009-08-18 13:43:19 +00:00
|
|
|
struct zfcp_qdio *qdio = wka_port->adapter->qdio;
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_fsf_req *req;
|
|
|
|
int ret = -EIO;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_lock_irq(&qdio->req_q_lock);
|
2010-04-30 16:09:35 +00:00
|
|
|
if (zfcp_qdio_sbal_get(qdio))
|
2008-07-02 08:56:39 +00:00
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-04-30 16:09:34 +00:00
|
|
|
req = zfcp_fsf_req_create(qdio, FSF_QTCB_SEND_GENERIC,
|
|
|
|
SBAL_FLAGS0_TYPE_WRITE_READ, pool);
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2008-08-21 11:43:37 +00:00
|
|
|
if (IS_ERR(req)) {
|
2008-07-02 08:56:39 +00:00
|
|
|
ret = PTR_ERR(req);
|
|
|
|
goto out;
|
2007-12-20 11:30:25 +00:00
|
|
|
}
|
|
|
|
|
2009-08-18 13:43:16 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_CLEANUP;
|
2010-07-16 13:37:37 +00:00
|
|
|
ret = zfcp_fsf_setup_ct_els(req, ct->req, ct->resp, timeout);
|
2008-06-10 16:20:58 +00:00
|
|
|
if (ret)
|
2005-04-16 22:20:36 +00:00
|
|
|
goto failed_send;
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
req->handler = zfcp_fsf_send_ct_handler;
|
2008-10-01 10:42:17 +00:00
|
|
|
req->qtcb->header.port_handle = wka_port->handle;
|
2008-07-02 08:56:39 +00:00
|
|
|
req->data = ct;
|
|
|
|
|
2009-11-24 15:54:13 +00:00
|
|
|
zfcp_dbf_san_ct_request(req, wka_port->d_id);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
ret = zfcp_fsf_req_send(req);
|
|
|
|
if (ret)
|
|
|
|
goto failed_send;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
failed_send:
|
|
|
|
zfcp_fsf_req_free(req);
|
|
|
|
out:
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2008-07-02 08:56:39 +00:00
|
|
|
return ret;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
static void zfcp_fsf_send_els_handler(struct zfcp_fsf_req *req)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2009-11-24 15:54:13 +00:00
|
|
|
struct zfcp_fsf_ct_els *send_els = req->data;
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_port *port = send_els->port;
|
|
|
|
struct fsf_qtcb_header *header = &req->qtcb->header;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
send_els->status = -EINVAL;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (req->status & ZFCP_STATUS_FSFREQ_ERROR)
|
2005-04-16 22:20:36 +00:00
|
|
|
goto skip_fsfstatus;
|
|
|
|
|
|
|
|
switch (header->fsf_status) {
|
|
|
|
case FSF_GOOD:
|
2009-08-18 13:43:21 +00:00
|
|
|
zfcp_dbf_san_els_response(req);
|
2008-07-02 08:56:39 +00:00
|
|
|
send_els->status = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_SERVICE_CLASS_NOT_SUPPORTED:
|
2008-07-02 08:56:39 +00:00
|
|
|
zfcp_fsf_class_not_supp(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_ADAPTER_STATUS_AVAILABLE:
|
|
|
|
switch (header->fsf_status_qual.word[0]){
|
|
|
|
case FSF_SQ_INVOKE_LINK_TEST_PROCEDURE:
|
|
|
|
case FSF_SQ_ULP_DEPENDENT_ERP_REQUIRED:
|
|
|
|
case FSF_SQ_RETRY_IF_POSSIBLE:
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case FSF_ELS_COMMAND_REJECTED:
|
|
|
|
case FSF_PAYLOAD_SIZE_MISMATCH:
|
|
|
|
case FSF_REQUEST_SIZE_TOO_LARGE:
|
|
|
|
case FSF_RESPONSE_SIZE_TOO_LARGE:
|
|
|
|
break;
|
|
|
|
case FSF_ACCESS_DENIED:
|
2010-09-08 12:39:59 +00:00
|
|
|
if (port) {
|
|
|
|
zfcp_cfdc_port_denied(port, &header->fsf_status_qual);
|
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2008-07-02 08:56:39 +00:00
|
|
|
case FSF_SBAL_MISMATCH:
|
|
|
|
/* should never occure, avoided in zfcp_fsf_send_els */
|
|
|
|
/* fall through */
|
2005-04-16 22:20:36 +00:00
|
|
|
default:
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
skip_fsfstatus:
|
2007-07-18 08:55:10 +00:00
|
|
|
if (send_els->handler)
|
2005-04-16 22:20:36 +00:00
|
|
|
send_els->handler(send_els->handler_data);
|
2008-07-02 08:56:39 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
/**
|
|
|
|
* zfcp_fsf_send_els - initiate an ELS command (FC-FS)
|
|
|
|
* @els: pointer to struct zfcp_send_els with data for the command
|
|
|
|
*/
|
2009-11-24 15:54:13 +00:00
|
|
|
int zfcp_fsf_send_els(struct zfcp_adapter *adapter, u32 d_id,
|
2010-01-14 16:19:02 +00:00
|
|
|
struct zfcp_fsf_ct_els *els, unsigned int timeout)
|
2008-07-02 08:56:39 +00:00
|
|
|
{
|
|
|
|
struct zfcp_fsf_req *req;
|
2009-11-24 15:54:13 +00:00
|
|
|
struct zfcp_qdio *qdio = adapter->qdio;
|
2008-07-02 08:56:39 +00:00
|
|
|
int ret = -EIO;
|
|
|
|
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_lock_irq(&qdio->req_q_lock);
|
2010-04-30 16:09:35 +00:00
|
|
|
if (zfcp_qdio_sbal_get(qdio))
|
2008-07-02 08:56:39 +00:00
|
|
|
goto out;
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2010-04-30 16:09:34 +00:00
|
|
|
req = zfcp_fsf_req_create(qdio, FSF_QTCB_SEND_ELS,
|
|
|
|
SBAL_FLAGS0_TYPE_WRITE_READ, NULL);
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2008-08-21 11:43:37 +00:00
|
|
|
if (IS_ERR(req)) {
|
2008-07-02 08:56:39 +00:00
|
|
|
ret = PTR_ERR(req);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2009-08-18 13:43:16 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_CLEANUP;
|
2010-07-16 13:37:37 +00:00
|
|
|
|
|
|
|
zfcp_qdio_sbal_limit(qdio, &req->qdio_req, 2);
|
|
|
|
|
|
|
|
ret = zfcp_fsf_setup_ct_els(req, els->req, els->resp, timeout);
|
2008-10-01 10:42:16 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (ret)
|
|
|
|
goto failed_send;
|
|
|
|
|
2009-11-24 15:54:13 +00:00
|
|
|
hton24(req->qtcb->bottom.support.d_id, d_id);
|
2008-07-02 08:56:39 +00:00
|
|
|
req->handler = zfcp_fsf_send_els_handler;
|
|
|
|
req->data = els;
|
|
|
|
|
2009-08-18 13:43:21 +00:00
|
|
|
zfcp_dbf_san_els_request(req);
|
2008-07-02 08:56:39 +00:00
|
|
|
|
|
|
|
ret = zfcp_fsf_req_send(req);
|
|
|
|
if (ret)
|
|
|
|
goto failed_send;
|
|
|
|
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
failed_send:
|
|
|
|
zfcp_fsf_req_free(req);
|
|
|
|
out:
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2008-07-02 08:56:39 +00:00
|
|
|
return ret;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
int zfcp_fsf_exchange_config_data(struct zfcp_erp_action *erp_action)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_fsf_req *req;
|
2009-08-18 13:43:19 +00:00
|
|
|
struct zfcp_qdio *qdio = erp_action->adapter->qdio;
|
2008-07-02 08:56:39 +00:00
|
|
|
int retval = -EIO;
|
|
|
|
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_lock_irq(&qdio->req_q_lock);
|
2010-04-30 16:09:35 +00:00
|
|
|
if (zfcp_qdio_sbal_get(qdio))
|
2008-07-02 08:56:39 +00:00
|
|
|
goto out;
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2009-08-18 13:43:19 +00:00
|
|
|
req = zfcp_fsf_req_create(qdio, FSF_QTCB_EXCHANGE_CONFIG_DATA,
|
2010-04-30 16:09:34 +00:00
|
|
|
SBAL_FLAGS0_TYPE_READ,
|
2009-08-18 13:43:19 +00:00
|
|
|
qdio->adapter->pool.erp_req);
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2008-08-21 11:43:37 +00:00
|
|
|
if (IS_ERR(req)) {
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = PTR_ERR(req);
|
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2009-08-18 13:43:16 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_CLEANUP;
|
2010-04-30 16:09:34 +00:00
|
|
|
zfcp_qdio_set_sbale_last(qdio, &req->qdio_req);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
req->qtcb->bottom.config.feature_selection =
|
2005-09-13 19:51:16 +00:00
|
|
|
FSF_FEATURE_CFDC |
|
|
|
|
FSF_FEATURE_LUN_SHARING |
|
2006-01-05 08:56:47 +00:00
|
|
|
FSF_FEATURE_NOTIFICATION_LOST |
|
2005-09-13 19:51:16 +00:00
|
|
|
FSF_FEATURE_UPDATE_ALERT;
|
2008-07-02 08:56:39 +00:00
|
|
|
req->erp_action = erp_action;
|
|
|
|
req->handler = zfcp_fsf_exchange_config_data_handler;
|
2010-02-17 10:18:49 +00:00
|
|
|
erp_action->fsf_req_id = req->req_id;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:40 +00:00
|
|
|
zfcp_fsf_start_erp_timer(req);
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = zfcp_fsf_req_send(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (retval) {
|
2008-07-02 08:56:39 +00:00
|
|
|
zfcp_fsf_req_free(req);
|
2010-02-17 10:18:49 +00:00
|
|
|
erp_action->fsf_req_id = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2008-07-02 08:56:39 +00:00
|
|
|
out:
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2007-08-28 07:31:09 +00:00
|
|
|
return retval;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-08-18 13:43:19 +00:00
|
|
|
int zfcp_fsf_exchange_config_data_sync(struct zfcp_qdio *qdio,
|
2008-07-02 08:56:39 +00:00
|
|
|
struct fsf_qtcb_bottom_config *data)
|
2007-08-28 07:31:09 +00:00
|
|
|
{
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_fsf_req *req = NULL;
|
|
|
|
int retval = -EIO;
|
|
|
|
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_lock_irq(&qdio->req_q_lock);
|
2010-04-30 16:09:35 +00:00
|
|
|
if (zfcp_qdio_sbal_get(qdio))
|
2009-04-17 13:08:03 +00:00
|
|
|
goto out_unlock;
|
2008-07-02 08:56:39 +00:00
|
|
|
|
2010-04-30 16:09:34 +00:00
|
|
|
req = zfcp_fsf_req_create(qdio, FSF_QTCB_EXCHANGE_CONFIG_DATA,
|
|
|
|
SBAL_FLAGS0_TYPE_READ, NULL);
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2008-08-21 11:43:37 +00:00
|
|
|
if (IS_ERR(req)) {
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = PTR_ERR(req);
|
2009-04-17 13:08:03 +00:00
|
|
|
goto out_unlock;
|
2007-08-28 07:31:09 +00:00
|
|
|
}
|
|
|
|
|
2010-04-30 16:09:34 +00:00
|
|
|
zfcp_qdio_set_sbale_last(qdio, &req->qdio_req);
|
2008-07-02 08:56:39 +00:00
|
|
|
req->handler = zfcp_fsf_exchange_config_data_handler;
|
2007-08-28 07:31:09 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
req->qtcb->bottom.config.feature_selection =
|
2007-08-28 07:31:09 +00:00
|
|
|
FSF_FEATURE_CFDC |
|
|
|
|
FSF_FEATURE_LUN_SHARING |
|
|
|
|
FSF_FEATURE_NOTIFICATION_LOST |
|
|
|
|
FSF_FEATURE_UPDATE_ALERT;
|
|
|
|
|
|
|
|
if (data)
|
2008-07-02 08:56:39 +00:00
|
|
|
req->data = data;
|
2007-08-28 07:31:09 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
zfcp_fsf_start_timer(req, ZFCP_FSF_REQUEST_TIMEOUT);
|
|
|
|
retval = zfcp_fsf_req_send(req);
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2008-06-10 16:20:58 +00:00
|
|
|
if (!retval)
|
2009-08-18 13:43:14 +00:00
|
|
|
wait_for_completion(&req->completion);
|
2007-08-28 07:31:09 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
zfcp_fsf_req_free(req);
|
2009-04-17 13:08:03 +00:00
|
|
|
return retval;
|
2007-08-28 07:31:09 +00:00
|
|
|
|
2009-04-17 13:08:03 +00:00
|
|
|
out_unlock:
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2005-04-16 22:20:36 +00:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* zfcp_fsf_exchange_port_data - request information about local port
|
2005-09-13 19:51:16 +00:00
|
|
|
* @erp_action: ERP action for the adapter for which port data is requested
|
2008-07-02 08:56:39 +00:00
|
|
|
* Returns: 0 on success, error otherwise
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2008-07-02 08:56:39 +00:00
|
|
|
int zfcp_fsf_exchange_port_data(struct zfcp_erp_action *erp_action)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2009-08-18 13:43:19 +00:00
|
|
|
struct zfcp_qdio *qdio = erp_action->adapter->qdio;
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_fsf_req *req;
|
|
|
|
int retval = -EIO;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-08-18 13:43:19 +00:00
|
|
|
if (!(qdio->adapter->adapter_features & FSF_FEATURE_HBAAPI_MANAGEMENT))
|
2007-08-28 07:31:09 +00:00
|
|
|
return -EOPNOTSUPP;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_lock_irq(&qdio->req_q_lock);
|
2010-04-30 16:09:35 +00:00
|
|
|
if (zfcp_qdio_sbal_get(qdio))
|
2008-07-02 08:56:39 +00:00
|
|
|
goto out;
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2009-08-18 13:43:19 +00:00
|
|
|
req = zfcp_fsf_req_create(qdio, FSF_QTCB_EXCHANGE_PORT_DATA,
|
2010-04-30 16:09:34 +00:00
|
|
|
SBAL_FLAGS0_TYPE_READ,
|
2009-08-18 13:43:19 +00:00
|
|
|
qdio->adapter->pool.erp_req);
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2008-08-21 11:43:37 +00:00
|
|
|
if (IS_ERR(req)) {
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = PTR_ERR(req);
|
|
|
|
goto out;
|
2005-09-13 19:51:16 +00:00
|
|
|
}
|
|
|
|
|
2009-08-18 13:43:16 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_CLEANUP;
|
2010-04-30 16:09:34 +00:00
|
|
|
zfcp_qdio_set_sbale_last(qdio, &req->qdio_req);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
req->handler = zfcp_fsf_exchange_port_data_handler;
|
|
|
|
req->erp_action = erp_action;
|
2010-02-17 10:18:49 +00:00
|
|
|
erp_action->fsf_req_id = req->req_id;
|
2007-08-28 07:31:09 +00:00
|
|
|
|
2008-07-02 08:56:40 +00:00
|
|
|
zfcp_fsf_start_erp_timer(req);
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = zfcp_fsf_req_send(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (retval) {
|
2008-07-02 08:56:39 +00:00
|
|
|
zfcp_fsf_req_free(req);
|
2010-02-17 10:18:49 +00:00
|
|
|
erp_action->fsf_req_id = 0;
|
2007-08-28 07:31:09 +00:00
|
|
|
}
|
2008-07-02 08:56:39 +00:00
|
|
|
out:
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2007-08-28 07:31:09 +00:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* zfcp_fsf_exchange_port_data_sync - request information about local port
|
2009-08-18 13:43:19 +00:00
|
|
|
* @qdio: pointer to struct zfcp_qdio
|
2008-07-02 08:56:39 +00:00
|
|
|
* @data: pointer to struct fsf_qtcb_bottom_port
|
|
|
|
* Returns: 0 on success, error otherwise
|
2007-08-28 07:31:09 +00:00
|
|
|
*/
|
2009-08-18 13:43:19 +00:00
|
|
|
int zfcp_fsf_exchange_port_data_sync(struct zfcp_qdio *qdio,
|
2008-07-02 08:56:39 +00:00
|
|
|
struct fsf_qtcb_bottom_port *data)
|
2007-08-28 07:31:09 +00:00
|
|
|
{
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_fsf_req *req = NULL;
|
|
|
|
int retval = -EIO;
|
2007-08-28 07:31:09 +00:00
|
|
|
|
2009-08-18 13:43:19 +00:00
|
|
|
if (!(qdio->adapter->adapter_features & FSF_FEATURE_HBAAPI_MANAGEMENT))
|
2007-08-28 07:31:09 +00:00
|
|
|
return -EOPNOTSUPP;
|
|
|
|
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_lock_irq(&qdio->req_q_lock);
|
2010-04-30 16:09:35 +00:00
|
|
|
if (zfcp_qdio_sbal_get(qdio))
|
2009-04-17 13:08:03 +00:00
|
|
|
goto out_unlock;
|
2008-07-02 08:56:39 +00:00
|
|
|
|
2010-04-30 16:09:34 +00:00
|
|
|
req = zfcp_fsf_req_create(qdio, FSF_QTCB_EXCHANGE_PORT_DATA,
|
|
|
|
SBAL_FLAGS0_TYPE_READ, NULL);
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2008-08-21 11:43:37 +00:00
|
|
|
if (IS_ERR(req)) {
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = PTR_ERR(req);
|
2009-04-17 13:08:03 +00:00
|
|
|
goto out_unlock;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2007-08-28 07:31:09 +00:00
|
|
|
if (data)
|
2008-07-02 08:56:39 +00:00
|
|
|
req->data = data;
|
2007-08-28 07:31:09 +00:00
|
|
|
|
2010-04-30 16:09:34 +00:00
|
|
|
zfcp_qdio_set_sbale_last(qdio, &req->qdio_req);
|
2007-08-28 07:31:09 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
req->handler = zfcp_fsf_exchange_port_data_handler;
|
|
|
|
zfcp_fsf_start_timer(req, ZFCP_FSF_REQUEST_TIMEOUT);
|
|
|
|
retval = zfcp_fsf_req_send(req);
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2009-04-17 13:08:03 +00:00
|
|
|
|
2008-06-10 16:20:58 +00:00
|
|
|
if (!retval)
|
2009-08-18 13:43:14 +00:00
|
|
|
wait_for_completion(&req->completion);
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
zfcp_fsf_req_free(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
return retval;
|
2009-04-17 13:08:03 +00:00
|
|
|
|
|
|
|
out_unlock:
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2009-04-17 13:08:03 +00:00
|
|
|
return retval;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
static void zfcp_fsf_open_port_handler(struct zfcp_fsf_req *req)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_port *port = req->data;
|
|
|
|
struct fsf_qtcb_header *header = &req->qtcb->header;
|
2009-11-24 15:54:09 +00:00
|
|
|
struct fc_els_flogi *plogi;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (req->status & ZFCP_STATUS_FSFREQ_ERROR)
|
2009-05-15 11:18:19 +00:00
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
switch (header->fsf_status) {
|
|
|
|
case FSF_PORT_ALREADY_OPEN:
|
|
|
|
break;
|
|
|
|
case FSF_ACCESS_DENIED:
|
2010-09-08 12:39:59 +00:00
|
|
|
zfcp_cfdc_port_denied(port, &header->fsf_status_qual);
|
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_MAXIMUM_NUMBER_OF_PORTS_EXCEEDED:
|
2008-07-02 08:56:39 +00:00
|
|
|
dev_warn(&req->adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"Not enough FCP adapter resources to open "
|
2008-10-01 10:42:18 +00:00
|
|
|
"remote port 0x%016Lx\n",
|
|
|
|
(unsigned long long)port->wwpn);
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_port_failed(port, "fsoph_1", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_ADAPTER_STATUS_AVAILABLE:
|
|
|
|
switch (header->fsf_status_qual.word[0]) {
|
|
|
|
case FSF_SQ_INVOKE_LINK_TEST_PROCEDURE:
|
|
|
|
case FSF_SQ_ULP_DEPENDENT_ERP_REQUIRED:
|
|
|
|
case FSF_SQ_NO_RETRY_POSSIBLE:
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case FSF_GOOD:
|
|
|
|
port->handle = header->port_handle;
|
|
|
|
atomic_set_mask(ZFCP_STATUS_COMMON_OPEN |
|
|
|
|
ZFCP_STATUS_PORT_PHYS_OPEN, &port->status);
|
2005-06-13 11:23:57 +00:00
|
|
|
atomic_clear_mask(ZFCP_STATUS_COMMON_ACCESS_DENIED |
|
|
|
|
ZFCP_STATUS_COMMON_ACCESS_BOXED,
|
|
|
|
&port->status);
|
2005-04-16 22:20:36 +00:00
|
|
|
/* check whether D_ID has changed during open */
|
|
|
|
/*
|
|
|
|
* FIXME: This check is not airtight, as the FCP channel does
|
|
|
|
* not monitor closures of target port connections caused on
|
|
|
|
* the remote side. Thus, they might miss out on invalidating
|
|
|
|
* locally cached WWPNs (and other N_Port parameters) of gone
|
|
|
|
* target ports. So, our heroic attempt to make things safe
|
|
|
|
* could be undermined by 'open port' response data tagged with
|
|
|
|
* obsolete WWPNs. Another reason to monitor potential
|
|
|
|
* connection closures ourself at least (by interpreting
|
|
|
|
* incoming ELS' and unsolicited status). It just crosses my
|
|
|
|
* mind that one should be able to cross-check by means of
|
|
|
|
* another GID_PN straight after a port has been opened.
|
|
|
|
* Alternately, an ADISC/PDISC ELS should suffice, as well.
|
|
|
|
*/
|
2009-11-24 15:54:09 +00:00
|
|
|
plogi = (struct fc_els_flogi *) req->qtcb->bottom.support.els;
|
2008-12-19 15:57:01 +00:00
|
|
|
if (req->qtcb->bottom.support.els1_length >=
|
2009-11-24 15:54:09 +00:00
|
|
|
FSF_PLOGI_MIN_LEN)
|
2008-07-02 08:56:39 +00:00
|
|
|
zfcp_fc_plogi_evaluate(port, plogi);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_UNKNOWN_OP_SUBTYPE:
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
2009-05-15 11:18:19 +00:00
|
|
|
|
|
|
|
out:
|
2010-02-17 10:18:56 +00:00
|
|
|
put_device(&port->dev);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
/**
|
|
|
|
* zfcp_fsf_open_port - create and send open port request
|
|
|
|
* @erp_action: pointer to struct zfcp_erp_action
|
|
|
|
* Returns: 0 on success, error otherwise
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2008-07-02 08:56:39 +00:00
|
|
|
int zfcp_fsf_open_port(struct zfcp_erp_action *erp_action)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2009-08-18 13:43:19 +00:00
|
|
|
struct zfcp_qdio *qdio = erp_action->adapter->qdio;
|
2009-05-15 11:18:19 +00:00
|
|
|
struct zfcp_port *port = erp_action->port;
|
2009-08-18 13:43:19 +00:00
|
|
|
struct zfcp_fsf_req *req;
|
2008-07-02 08:56:39 +00:00
|
|
|
int retval = -EIO;
|
|
|
|
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_lock_irq(&qdio->req_q_lock);
|
2010-04-30 16:09:35 +00:00
|
|
|
if (zfcp_qdio_sbal_get(qdio))
|
2008-07-02 08:56:39 +00:00
|
|
|
goto out;
|
|
|
|
|
2009-08-18 13:43:19 +00:00
|
|
|
req = zfcp_fsf_req_create(qdio, FSF_QTCB_OPEN_PORT_WITH_DID,
|
2010-04-30 16:09:34 +00:00
|
|
|
SBAL_FLAGS0_TYPE_READ,
|
2009-08-18 13:43:19 +00:00
|
|
|
qdio->adapter->pool.erp_req);
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2008-08-21 11:43:37 +00:00
|
|
|
if (IS_ERR(req)) {
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = PTR_ERR(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
goto out;
|
2008-07-02 08:56:39 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-08-18 13:43:16 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_CLEANUP;
|
2010-04-30 16:09:34 +00:00
|
|
|
zfcp_qdio_set_sbale_last(qdio, &req->qdio_req);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
req->handler = zfcp_fsf_open_port_handler;
|
2009-11-24 15:54:12 +00:00
|
|
|
hton24(req->qtcb->bottom.support.d_id, port->d_id);
|
2009-05-15 11:18:19 +00:00
|
|
|
req->data = port;
|
2008-07-02 08:56:39 +00:00
|
|
|
req->erp_action = erp_action;
|
2010-02-17 10:18:49 +00:00
|
|
|
erp_action->fsf_req_id = req->req_id;
|
2010-02-17 10:18:56 +00:00
|
|
|
get_device(&port->dev);
|
2008-07-02 08:56:39 +00:00
|
|
|
|
2008-07-02 08:56:40 +00:00
|
|
|
zfcp_fsf_start_erp_timer(req);
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = zfcp_fsf_req_send(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (retval) {
|
2008-07-02 08:56:39 +00:00
|
|
|
zfcp_fsf_req_free(req);
|
2010-02-17 10:18:49 +00:00
|
|
|
erp_action->fsf_req_id = 0;
|
2010-02-17 10:18:56 +00:00
|
|
|
put_device(&port->dev);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2008-07-02 08:56:39 +00:00
|
|
|
out:
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2005-04-16 22:20:36 +00:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
static void zfcp_fsf_close_port_handler(struct zfcp_fsf_req *req)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_port *port = req->data;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (req->status & ZFCP_STATUS_FSFREQ_ERROR)
|
2008-10-01 10:42:16 +00:00
|
|
|
return;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
switch (req->qtcb->header.fsf_status) {
|
2005-04-16 22:20:36 +00:00
|
|
|
case FSF_PORT_HANDLE_NOT_VALID:
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_reopen(port->adapter, 0, "fscph_1", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_ADAPTER_STATUS_AVAILABLE:
|
|
|
|
break;
|
|
|
|
case FSF_GOOD:
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_modify_port_status(port, "fscph_2", req,
|
2005-04-16 22:20:36 +00:00
|
|
|
ZFCP_STATUS_COMMON_OPEN,
|
|
|
|
ZFCP_CLEAR);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
/**
|
|
|
|
* zfcp_fsf_close_port - create and send close port request
|
|
|
|
* @erp_action: pointer to struct zfcp_erp_action
|
|
|
|
* Returns: 0 on success, error otherwise
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2008-07-02 08:56:39 +00:00
|
|
|
int zfcp_fsf_close_port(struct zfcp_erp_action *erp_action)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2009-08-18 13:43:19 +00:00
|
|
|
struct zfcp_qdio *qdio = erp_action->adapter->qdio;
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_fsf_req *req;
|
|
|
|
int retval = -EIO;
|
|
|
|
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_lock_irq(&qdio->req_q_lock);
|
2010-04-30 16:09:35 +00:00
|
|
|
if (zfcp_qdio_sbal_get(qdio))
|
2008-07-02 08:56:39 +00:00
|
|
|
goto out;
|
|
|
|
|
2009-08-18 13:43:19 +00:00
|
|
|
req = zfcp_fsf_req_create(qdio, FSF_QTCB_CLOSE_PORT,
|
2010-04-30 16:09:34 +00:00
|
|
|
SBAL_FLAGS0_TYPE_READ,
|
2009-08-18 13:43:19 +00:00
|
|
|
qdio->adapter->pool.erp_req);
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2008-08-21 11:43:37 +00:00
|
|
|
if (IS_ERR(req)) {
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = PTR_ERR(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
goto out;
|
2008-07-02 08:56:39 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-08-18 13:43:16 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_CLEANUP;
|
2010-04-30 16:09:34 +00:00
|
|
|
zfcp_qdio_set_sbale_last(qdio, &req->qdio_req);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
req->handler = zfcp_fsf_close_port_handler;
|
|
|
|
req->data = erp_action->port;
|
|
|
|
req->erp_action = erp_action;
|
|
|
|
req->qtcb->header.port_handle = erp_action->port->handle;
|
2010-02-17 10:18:49 +00:00
|
|
|
erp_action->fsf_req_id = req->req_id;
|
2008-07-02 08:56:39 +00:00
|
|
|
|
2008-07-02 08:56:40 +00:00
|
|
|
zfcp_fsf_start_erp_timer(req);
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = zfcp_fsf_req_send(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (retval) {
|
2008-07-02 08:56:39 +00:00
|
|
|
zfcp_fsf_req_free(req);
|
2010-02-17 10:18:49 +00:00
|
|
|
erp_action->fsf_req_id = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2008-07-02 08:56:39 +00:00
|
|
|
out:
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2005-04-16 22:20:36 +00:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
2008-10-01 10:42:17 +00:00
|
|
|
static void zfcp_fsf_open_wka_port_handler(struct zfcp_fsf_req *req)
|
|
|
|
{
|
2009-11-24 15:54:11 +00:00
|
|
|
struct zfcp_fc_wka_port *wka_port = req->data;
|
2008-10-01 10:42:17 +00:00
|
|
|
struct fsf_qtcb_header *header = &req->qtcb->header;
|
|
|
|
|
|
|
|
if (req->status & ZFCP_STATUS_FSFREQ_ERROR) {
|
2009-11-24 15:54:11 +00:00
|
|
|
wka_port->status = ZFCP_FC_WKA_PORT_OFFLINE;
|
2008-10-01 10:42:17 +00:00
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (header->fsf_status) {
|
|
|
|
case FSF_MAXIMUM_NUMBER_OF_PORTS_EXCEEDED:
|
|
|
|
dev_warn(&req->adapter->ccw_device->dev,
|
|
|
|
"Opening WKA port 0x%x failed\n", wka_port->d_id);
|
2009-05-15 11:18:18 +00:00
|
|
|
/* fall through */
|
2008-10-01 10:42:17 +00:00
|
|
|
case FSF_ADAPTER_STATUS_AVAILABLE:
|
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2009-05-15 11:18:18 +00:00
|
|
|
/* fall through */
|
2008-10-01 10:42:17 +00:00
|
|
|
case FSF_ACCESS_DENIED:
|
2009-11-24 15:54:11 +00:00
|
|
|
wka_port->status = ZFCP_FC_WKA_PORT_OFFLINE;
|
2008-10-01 10:42:17 +00:00
|
|
|
break;
|
|
|
|
case FSF_GOOD:
|
|
|
|
wka_port->handle = header->port_handle;
|
2009-07-13 13:06:13 +00:00
|
|
|
/* fall through */
|
|
|
|
case FSF_PORT_ALREADY_OPEN:
|
2009-11-24 15:54:11 +00:00
|
|
|
wka_port->status = ZFCP_FC_WKA_PORT_ONLINE;
|
2008-10-01 10:42:17 +00:00
|
|
|
}
|
|
|
|
out:
|
|
|
|
wake_up(&wka_port->completion_wq);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* zfcp_fsf_open_wka_port - create and send open wka-port request
|
2009-11-24 15:54:11 +00:00
|
|
|
* @wka_port: pointer to struct zfcp_fc_wka_port
|
2008-10-01 10:42:17 +00:00
|
|
|
* Returns: 0 on success, error otherwise
|
|
|
|
*/
|
2009-11-24 15:54:11 +00:00
|
|
|
int zfcp_fsf_open_wka_port(struct zfcp_fc_wka_port *wka_port)
|
2008-10-01 10:42:17 +00:00
|
|
|
{
|
2009-08-18 13:43:19 +00:00
|
|
|
struct zfcp_qdio *qdio = wka_port->adapter->qdio;
|
2008-10-01 10:42:17 +00:00
|
|
|
struct zfcp_fsf_req *req;
|
|
|
|
int retval = -EIO;
|
|
|
|
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_lock_irq(&qdio->req_q_lock);
|
2010-04-30 16:09:35 +00:00
|
|
|
if (zfcp_qdio_sbal_get(qdio))
|
2008-10-01 10:42:17 +00:00
|
|
|
goto out;
|
|
|
|
|
2009-08-18 13:43:19 +00:00
|
|
|
req = zfcp_fsf_req_create(qdio, FSF_QTCB_OPEN_PORT_WITH_DID,
|
2010-04-30 16:09:34 +00:00
|
|
|
SBAL_FLAGS0_TYPE_READ,
|
2009-08-18 13:43:19 +00:00
|
|
|
qdio->adapter->pool.erp_req);
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2008-10-01 10:42:17 +00:00
|
|
|
if (unlikely(IS_ERR(req))) {
|
|
|
|
retval = PTR_ERR(req);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2009-08-18 13:43:16 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_CLEANUP;
|
2010-04-30 16:09:34 +00:00
|
|
|
zfcp_qdio_set_sbale_last(qdio, &req->qdio_req);
|
2008-10-01 10:42:17 +00:00
|
|
|
|
|
|
|
req->handler = zfcp_fsf_open_wka_port_handler;
|
2009-11-24 15:54:12 +00:00
|
|
|
hton24(req->qtcb->bottom.support.d_id, wka_port->d_id);
|
2008-10-01 10:42:17 +00:00
|
|
|
req->data = wka_port;
|
|
|
|
|
|
|
|
zfcp_fsf_start_timer(req, ZFCP_FSF_REQUEST_TIMEOUT);
|
|
|
|
retval = zfcp_fsf_req_send(req);
|
|
|
|
if (retval)
|
|
|
|
zfcp_fsf_req_free(req);
|
|
|
|
out:
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2008-10-01 10:42:17 +00:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void zfcp_fsf_close_wka_port_handler(struct zfcp_fsf_req *req)
|
|
|
|
{
|
2009-11-24 15:54:11 +00:00
|
|
|
struct zfcp_fc_wka_port *wka_port = req->data;
|
2008-10-01 10:42:17 +00:00
|
|
|
|
|
|
|
if (req->qtcb->header.fsf_status == FSF_PORT_HANDLE_NOT_VALID) {
|
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_reopen(wka_port->adapter, 0, "fscwph1", req);
|
2008-10-01 10:42:17 +00:00
|
|
|
}
|
|
|
|
|
2009-11-24 15:54:11 +00:00
|
|
|
wka_port->status = ZFCP_FC_WKA_PORT_OFFLINE;
|
2008-10-01 10:42:17 +00:00
|
|
|
wake_up(&wka_port->completion_wq);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* zfcp_fsf_close_wka_port - create and send close wka port request
|
2009-11-24 15:54:11 +00:00
|
|
|
* @wka_port: WKA port to open
|
2008-10-01 10:42:17 +00:00
|
|
|
* Returns: 0 on success, error otherwise
|
|
|
|
*/
|
2009-11-24 15:54:11 +00:00
|
|
|
int zfcp_fsf_close_wka_port(struct zfcp_fc_wka_port *wka_port)
|
2008-10-01 10:42:17 +00:00
|
|
|
{
|
2009-08-18 13:43:19 +00:00
|
|
|
struct zfcp_qdio *qdio = wka_port->adapter->qdio;
|
2008-10-01 10:42:17 +00:00
|
|
|
struct zfcp_fsf_req *req;
|
|
|
|
int retval = -EIO;
|
|
|
|
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_lock_irq(&qdio->req_q_lock);
|
2010-04-30 16:09:35 +00:00
|
|
|
if (zfcp_qdio_sbal_get(qdio))
|
2008-10-01 10:42:17 +00:00
|
|
|
goto out;
|
|
|
|
|
2009-08-18 13:43:19 +00:00
|
|
|
req = zfcp_fsf_req_create(qdio, FSF_QTCB_CLOSE_PORT,
|
2010-04-30 16:09:34 +00:00
|
|
|
SBAL_FLAGS0_TYPE_READ,
|
2009-08-18 13:43:19 +00:00
|
|
|
qdio->adapter->pool.erp_req);
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2008-10-01 10:42:17 +00:00
|
|
|
if (unlikely(IS_ERR(req))) {
|
|
|
|
retval = PTR_ERR(req);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2009-08-18 13:43:16 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_CLEANUP;
|
2010-04-30 16:09:34 +00:00
|
|
|
zfcp_qdio_set_sbale_last(qdio, &req->qdio_req);
|
2008-10-01 10:42:17 +00:00
|
|
|
|
|
|
|
req->handler = zfcp_fsf_close_wka_port_handler;
|
|
|
|
req->data = wka_port;
|
|
|
|
req->qtcb->header.port_handle = wka_port->handle;
|
|
|
|
|
|
|
|
zfcp_fsf_start_timer(req, ZFCP_FSF_REQUEST_TIMEOUT);
|
|
|
|
retval = zfcp_fsf_req_send(req);
|
|
|
|
if (retval)
|
|
|
|
zfcp_fsf_req_free(req);
|
|
|
|
out:
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2008-10-01 10:42:17 +00:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
static void zfcp_fsf_close_physical_port_handler(struct zfcp_fsf_req *req)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_port *port = req->data;
|
|
|
|
struct fsf_qtcb_header *header = &req->qtcb->header;
|
2010-09-08 12:39:55 +00:00
|
|
|
struct scsi_device *sdev;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (req->status & ZFCP_STATUS_FSFREQ_ERROR)
|
2009-03-02 12:08:54 +00:00
|
|
|
return;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
switch (header->fsf_status) {
|
|
|
|
case FSF_PORT_HANDLE_NOT_VALID:
|
2009-03-02 12:09:04 +00:00
|
|
|
zfcp_erp_adapter_reopen(port->adapter, 0, "fscpph1", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_ACCESS_DENIED:
|
2010-09-08 12:39:59 +00:00
|
|
|
zfcp_cfdc_port_denied(port, &header->fsf_status_qual);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_PORT_BOXED:
|
2008-03-10 15:18:54 +00:00
|
|
|
/* can't use generic zfcp_erp_modify_port_status because
|
|
|
|
* ZFCP_STATUS_COMMON_OPEN must not be reset for the port */
|
|
|
|
atomic_clear_mask(ZFCP_STATUS_PORT_PHYS_OPEN, &port->status);
|
2010-09-08 12:39:55 +00:00
|
|
|
shost_for_each_device(sdev, port->adapter->scsi_host)
|
|
|
|
if (sdev_to_zfcp(sdev)->port == port)
|
|
|
|
atomic_clear_mask(ZFCP_STATUS_COMMON_OPEN,
|
|
|
|
&sdev_to_zfcp(sdev)->status);
|
2009-07-13 13:06:02 +00:00
|
|
|
zfcp_erp_port_boxed(port, "fscpph2", req);
|
2009-11-24 15:54:15 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_ADAPTER_STATUS_AVAILABLE:
|
|
|
|
switch (header->fsf_status_qual.word[0]) {
|
|
|
|
case FSF_SQ_INVOKE_LINK_TEST_PROCEDURE:
|
2008-07-02 08:56:39 +00:00
|
|
|
/* fall through */
|
2005-04-16 22:20:36 +00:00
|
|
|
case FSF_SQ_ULP_DEPENDENT_ERP_REQUIRED:
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case FSF_GOOD:
|
|
|
|
/* can't use generic zfcp_erp_modify_port_status because
|
|
|
|
* ZFCP_STATUS_COMMON_OPEN must not be reset for the port
|
|
|
|
*/
|
|
|
|
atomic_clear_mask(ZFCP_STATUS_PORT_PHYS_OPEN, &port->status);
|
2010-09-08 12:39:55 +00:00
|
|
|
shost_for_each_device(sdev, port->adapter->scsi_host)
|
|
|
|
if (sdev_to_zfcp(sdev)->port == port)
|
|
|
|
atomic_clear_mask(ZFCP_STATUS_COMMON_OPEN,
|
|
|
|
&sdev_to_zfcp(sdev)->status);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
/**
|
|
|
|
* zfcp_fsf_close_physical_port - close physical port
|
|
|
|
* @erp_action: pointer to struct zfcp_erp_action
|
|
|
|
* Returns: 0 on success
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2008-07-02 08:56:39 +00:00
|
|
|
int zfcp_fsf_close_physical_port(struct zfcp_erp_action *erp_action)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2009-08-18 13:43:19 +00:00
|
|
|
struct zfcp_qdio *qdio = erp_action->adapter->qdio;
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_fsf_req *req;
|
|
|
|
int retval = -EIO;
|
|
|
|
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_lock_irq(&qdio->req_q_lock);
|
2010-04-30 16:09:35 +00:00
|
|
|
if (zfcp_qdio_sbal_get(qdio))
|
2005-04-16 22:20:36 +00:00
|
|
|
goto out;
|
|
|
|
|
2009-08-18 13:43:19 +00:00
|
|
|
req = zfcp_fsf_req_create(qdio, FSF_QTCB_CLOSE_PHYSICAL_PORT,
|
2010-04-30 16:09:34 +00:00
|
|
|
SBAL_FLAGS0_TYPE_READ,
|
2009-08-18 13:43:19 +00:00
|
|
|
qdio->adapter->pool.erp_req);
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2008-08-21 11:43:37 +00:00
|
|
|
if (IS_ERR(req)) {
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = PTR_ERR(req);
|
|
|
|
goto out;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-08-18 13:43:16 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_CLEANUP;
|
2010-04-30 16:09:34 +00:00
|
|
|
zfcp_qdio_set_sbale_last(qdio, &req->qdio_req);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
req->data = erp_action->port;
|
|
|
|
req->qtcb->header.port_handle = erp_action->port->handle;
|
|
|
|
req->erp_action = erp_action;
|
|
|
|
req->handler = zfcp_fsf_close_physical_port_handler;
|
2010-02-17 10:18:49 +00:00
|
|
|
erp_action->fsf_req_id = req->req_id;
|
2008-07-02 08:56:39 +00:00
|
|
|
|
2008-07-02 08:56:40 +00:00
|
|
|
zfcp_fsf_start_erp_timer(req);
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = zfcp_fsf_req_send(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (retval) {
|
2008-07-02 08:56:39 +00:00
|
|
|
zfcp_fsf_req_free(req);
|
2010-02-17 10:18:49 +00:00
|
|
|
erp_action->fsf_req_id = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2008-07-02 08:56:39 +00:00
|
|
|
out:
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2005-04-16 22:20:36 +00:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
2010-09-08 12:39:55 +00:00
|
|
|
static void zfcp_fsf_open_lun_handler(struct zfcp_fsf_req *req)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_adapter *adapter = req->adapter;
|
2010-09-08 12:39:55 +00:00
|
|
|
struct scsi_device *sdev = req->data;
|
|
|
|
struct zfcp_scsi_dev *zfcp_sdev = sdev_to_zfcp(sdev);
|
2008-07-02 08:56:39 +00:00
|
|
|
struct fsf_qtcb_header *header = &req->qtcb->header;
|
|
|
|
struct fsf_qtcb_bottom_support *bottom = &req->qtcb->bottom.support;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (req->status & ZFCP_STATUS_FSFREQ_ERROR)
|
2008-10-01 10:42:16 +00:00
|
|
|
return;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
atomic_clear_mask(ZFCP_STATUS_COMMON_ACCESS_DENIED |
|
2007-05-08 09:19:57 +00:00
|
|
|
ZFCP_STATUS_COMMON_ACCESS_BOXED |
|
2010-09-08 12:39:55 +00:00
|
|
|
ZFCP_STATUS_LUN_SHARED |
|
|
|
|
ZFCP_STATUS_LUN_READONLY,
|
|
|
|
&zfcp_sdev->status);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
|
|
|
switch (header->fsf_status) {
|
|
|
|
|
|
|
|
case FSF_PORT_HANDLE_NOT_VALID:
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_erp_adapter_reopen(adapter, 0, "fsouh_1", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
/* fall through */
|
2005-04-16 22:20:36 +00:00
|
|
|
case FSF_LUN_ALREADY_OPEN:
|
|
|
|
break;
|
|
|
|
case FSF_ACCESS_DENIED:
|
2010-09-08 12:39:59 +00:00
|
|
|
zfcp_cfdc_lun_denied(sdev, &header->fsf_status_qual);
|
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_PORT_BOXED:
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_erp_port_boxed(zfcp_sdev->port, "fsouh_2", req);
|
2009-11-24 15:54:15 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_LUN_SHARING_VIOLATION:
|
2010-09-08 12:39:59 +00:00
|
|
|
zfcp_cfdc_lun_shrng_vltn(sdev, &header->fsf_status_qual);
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_MAXIMUM_NUMBER_OF_LUNS_EXCEEDED:
|
2008-07-02 08:56:39 +00:00
|
|
|
dev_warn(&adapter->ccw_device->dev,
|
2008-10-01 10:42:15 +00:00
|
|
|
"No handle is available for LUN "
|
|
|
|
"0x%016Lx on port 0x%016Lx\n",
|
2010-09-08 12:39:55 +00:00
|
|
|
(unsigned long long)zfcp_scsi_dev_lun(sdev),
|
|
|
|
(unsigned long long)zfcp_sdev->port->wwpn);
|
|
|
|
zfcp_erp_lun_failed(sdev, "fsolh_4", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
/* fall through */
|
|
|
|
case FSF_INVALID_COMMAND_OPTION:
|
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_ADAPTER_STATUS_AVAILABLE:
|
|
|
|
switch (header->fsf_status_qual.word[0]) {
|
|
|
|
case FSF_SQ_INVOKE_LINK_TEST_PROCEDURE:
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_fc_test_link(zfcp_sdev->port);
|
2008-07-02 08:56:39 +00:00
|
|
|
/* fall through */
|
2005-04-16 22:20:36 +00:00
|
|
|
case FSF_SQ_ULP_DEPENDENT_ERP_REQUIRED:
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
|
|
|
|
case FSF_GOOD:
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_sdev->lun_handle = header->lun_handle;
|
|
|
|
atomic_set_mask(ZFCP_STATUS_COMMON_OPEN, &zfcp_sdev->status);
|
2010-09-08 12:39:59 +00:00
|
|
|
zfcp_cfdc_open_lun_eval(sdev, bottom);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
/**
|
2010-09-08 12:39:55 +00:00
|
|
|
* zfcp_fsf_open_lun - open LUN
|
2008-07-02 08:56:39 +00:00
|
|
|
* @erp_action: pointer to struct zfcp_erp_action
|
|
|
|
* Returns: 0 on success, error otherwise
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2010-09-08 12:39:55 +00:00
|
|
|
int zfcp_fsf_open_lun(struct zfcp_erp_action *erp_action)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_adapter *adapter = erp_action->adapter;
|
2009-08-18 13:43:19 +00:00
|
|
|
struct zfcp_qdio *qdio = adapter->qdio;
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_fsf_req *req;
|
|
|
|
int retval = -EIO;
|
|
|
|
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_lock_irq(&qdio->req_q_lock);
|
2010-04-30 16:09:35 +00:00
|
|
|
if (zfcp_qdio_sbal_get(qdio))
|
2005-04-16 22:20:36 +00:00
|
|
|
goto out;
|
|
|
|
|
2009-08-18 13:43:19 +00:00
|
|
|
req = zfcp_fsf_req_create(qdio, FSF_QTCB_OPEN_LUN,
|
2010-04-30 16:09:34 +00:00
|
|
|
SBAL_FLAGS0_TYPE_READ,
|
2009-08-18 13:43:15 +00:00
|
|
|
adapter->pool.erp_req);
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2008-08-21 11:43:37 +00:00
|
|
|
if (IS_ERR(req)) {
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = PTR_ERR(req);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2009-08-18 13:43:16 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_CLEANUP;
|
2010-04-30 16:09:34 +00:00
|
|
|
zfcp_qdio_set_sbale_last(qdio, &req->qdio_req);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
req->qtcb->header.port_handle = erp_action->port->handle;
|
2010-09-08 12:39:55 +00:00
|
|
|
req->qtcb->bottom.support.fcp_lun = zfcp_scsi_dev_lun(erp_action->sdev);
|
|
|
|
req->handler = zfcp_fsf_open_lun_handler;
|
|
|
|
req->data = erp_action->sdev;
|
2008-07-02 08:56:39 +00:00
|
|
|
req->erp_action = erp_action;
|
2010-02-17 10:18:49 +00:00
|
|
|
erp_action->fsf_req_id = req->req_id;
|
2008-07-02 08:56:39 +00:00
|
|
|
|
|
|
|
if (!(adapter->connection_features & FSF_FEATURE_NPIV_MODE))
|
|
|
|
req->qtcb->bottom.support.option = FSF_OPEN_LUN_SUPPRESS_BOXING;
|
|
|
|
|
2008-07-02 08:56:40 +00:00
|
|
|
zfcp_fsf_start_erp_timer(req);
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = zfcp_fsf_req_send(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
if (retval) {
|
2008-07-02 08:56:39 +00:00
|
|
|
zfcp_fsf_req_free(req);
|
2010-02-17 10:18:49 +00:00
|
|
|
erp_action->fsf_req_id = 0;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2008-07-02 08:56:39 +00:00
|
|
|
out:
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2005-04-16 22:20:36 +00:00
|
|
|
return retval;
|
|
|
|
}
|
|
|
|
|
2010-09-08 12:39:55 +00:00
|
|
|
static void zfcp_fsf_close_lun_handler(struct zfcp_fsf_req *req)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2010-09-08 12:39:55 +00:00
|
|
|
struct scsi_device *sdev = req->data;
|
|
|
|
struct zfcp_scsi_dev *zfcp_sdev = sdev_to_zfcp(sdev);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (req->status & ZFCP_STATUS_FSFREQ_ERROR)
|
2008-10-01 10:42:16 +00:00
|
|
|
return;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
switch (req->qtcb->header.fsf_status) {
|
2005-04-16 22:20:36 +00:00
|
|
|
case FSF_PORT_HANDLE_NOT_VALID:
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_erp_adapter_reopen(zfcp_sdev->port->adapter, 0, "fscuh_1",
|
|
|
|
req);
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_LUN_HANDLE_NOT_VALID:
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_erp_port_reopen(zfcp_sdev->port, 0, "fscuh_2", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_PORT_BOXED:
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_erp_port_boxed(zfcp_sdev->port, "fscuh_3", req);
|
2009-11-24 15:54:15 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
case FSF_ADAPTER_STATUS_AVAILABLE:
|
2008-07-02 08:56:39 +00:00
|
|
|
switch (req->qtcb->header.fsf_status_qual.word[0]) {
|
2005-04-16 22:20:36 +00:00
|
|
|
case FSF_SQ_INVOKE_LINK_TEST_PROCEDURE:
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_fc_test_link(zfcp_sdev->port);
|
2008-07-02 08:56:39 +00:00
|
|
|
/* fall through */
|
2005-04-16 22:20:36 +00:00
|
|
|
case FSF_SQ_ULP_DEPENDENT_ERP_REQUIRED:
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
case FSF_GOOD:
|
2010-09-08 12:39:55 +00:00
|
|
|
atomic_clear_mask(ZFCP_STATUS_COMMON_OPEN, &zfcp_sdev->status);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2010-09-08 12:39:55 +00:00
|
|
|
* zfcp_fsf_close_LUN - close LUN
|
|
|
|
* @erp_action: pointer to erp_action triggering the "close LUN"
|
2008-07-02 08:56:39 +00:00
|
|
|
* Returns: 0 on success, error otherwise
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2010-09-08 12:39:55 +00:00
|
|
|
int zfcp_fsf_close_lun(struct zfcp_erp_action *erp_action)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2009-08-18 13:43:19 +00:00
|
|
|
struct zfcp_qdio *qdio = erp_action->adapter->qdio;
|
2010-09-08 12:39:55 +00:00
|
|
|
struct zfcp_scsi_dev *zfcp_sdev = sdev_to_zfcp(erp_action->sdev);
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_fsf_req *req;
|
|
|
|
int retval = -EIO;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_lock_irq(&qdio->req_q_lock);
|
2010-04-30 16:09:35 +00:00
|
|
|
if (zfcp_qdio_sbal_get(qdio))
|
2005-04-16 22:20:36 +00:00
|
|
|
goto out;
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2009-08-18 13:43:19 +00:00
|
|
|
req = zfcp_fsf_req_create(qdio, FSF_QTCB_CLOSE_LUN,
|
2010-04-30 16:09:34 +00:00
|
|
|
SBAL_FLAGS0_TYPE_READ,
|
2009-08-18 13:43:19 +00:00
|
|
|
qdio->adapter->pool.erp_req);
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2008-08-21 11:43:37 +00:00
|
|
|
if (IS_ERR(req)) {
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = PTR_ERR(req);
|
|
|
|
goto out;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-08-18 13:43:16 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_CLEANUP;
|
2010-04-30 16:09:34 +00:00
|
|
|
zfcp_qdio_set_sbale_last(qdio, &req->qdio_req);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
req->qtcb->header.port_handle = erp_action->port->handle;
|
2010-09-08 12:39:55 +00:00
|
|
|
req->qtcb->header.lun_handle = zfcp_sdev->lun_handle;
|
|
|
|
req->handler = zfcp_fsf_close_lun_handler;
|
|
|
|
req->data = erp_action->sdev;
|
2008-07-02 08:56:39 +00:00
|
|
|
req->erp_action = erp_action;
|
2010-02-17 10:18:49 +00:00
|
|
|
erp_action->fsf_req_id = req->req_id;
|
2007-12-20 11:30:27 +00:00
|
|
|
|
2008-07-02 08:56:40 +00:00
|
|
|
zfcp_fsf_start_erp_timer(req);
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = zfcp_fsf_req_send(req);
|
|
|
|
if (retval) {
|
|
|
|
zfcp_fsf_req_free(req);
|
2010-02-17 10:18:49 +00:00
|
|
|
erp_action->fsf_req_id = 0;
|
2008-07-02 08:56:39 +00:00
|
|
|
}
|
|
|
|
out:
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2008-07-02 08:56:39 +00:00
|
|
|
return retval;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-05-06 09:00:05 +00:00
|
|
|
static void zfcp_fsf_update_lat(struct fsf_latency_record *lat_rec, u32 lat)
|
|
|
|
{
|
|
|
|
lat_rec->sum += lat;
|
2008-07-02 08:56:39 +00:00
|
|
|
lat_rec->min = min(lat_rec->min, lat);
|
|
|
|
lat_rec->max = max(lat_rec->max, lat);
|
2008-05-06 09:00:05 +00:00
|
|
|
}
|
|
|
|
|
2009-11-24 15:54:03 +00:00
|
|
|
static void zfcp_fsf_req_trace(struct zfcp_fsf_req *req, struct scsi_cmnd *scsi)
|
2008-05-06 09:00:05 +00:00
|
|
|
{
|
2009-11-24 15:54:03 +00:00
|
|
|
struct fsf_qual_latency_info *lat_in;
|
|
|
|
struct latency_cont *lat = NULL;
|
2010-09-08 12:39:55 +00:00
|
|
|
struct zfcp_scsi_dev *zfcp_sdev = sdev_to_zfcp(scsi->device);
|
2009-11-24 15:54:03 +00:00
|
|
|
struct zfcp_blk_drv_data blktrc;
|
|
|
|
int ticks = req->adapter->timer_ticks;
|
2008-05-06 09:00:05 +00:00
|
|
|
|
2009-11-24 15:54:03 +00:00
|
|
|
lat_in = &req->qtcb->prefix.prot_status_qual.latency_info;
|
2008-05-06 09:00:05 +00:00
|
|
|
|
2009-11-24 15:54:03 +00:00
|
|
|
blktrc.flags = 0;
|
|
|
|
blktrc.magic = ZFCP_BLK_DRV_DATA_MAGIC;
|
|
|
|
if (req->status & ZFCP_STATUS_FSFREQ_ERROR)
|
|
|
|
blktrc.flags |= ZFCP_BLK_REQ_ERROR;
|
2010-07-16 13:37:38 +00:00
|
|
|
blktrc.inb_usage = 0;
|
2010-02-17 10:18:59 +00:00
|
|
|
blktrc.outb_usage = req->qdio_req.qdio_outb_usage;
|
2009-11-24 15:54:03 +00:00
|
|
|
|
2010-04-01 11:04:08 +00:00
|
|
|
if (req->adapter->adapter_features & FSF_FEATURE_MEASUREMENT_DATA &&
|
|
|
|
!(req->status & ZFCP_STATUS_FSFREQ_ERROR)) {
|
2009-11-24 15:54:03 +00:00
|
|
|
blktrc.flags |= ZFCP_BLK_LAT_VALID;
|
|
|
|
blktrc.channel_lat = lat_in->channel_lat * ticks;
|
|
|
|
blktrc.fabric_lat = lat_in->fabric_lat * ticks;
|
|
|
|
|
|
|
|
switch (req->qtcb->bottom.io.data_direction) {
|
2010-07-16 13:37:42 +00:00
|
|
|
case FSF_DATADIR_DIF_READ_STRIP:
|
|
|
|
case FSF_DATADIR_DIF_READ_CONVERT:
|
2009-11-24 15:54:03 +00:00
|
|
|
case FSF_DATADIR_READ:
|
2010-09-08 12:39:55 +00:00
|
|
|
lat = &zfcp_sdev->latencies.read;
|
2009-11-24 15:54:03 +00:00
|
|
|
break;
|
2010-07-16 13:37:42 +00:00
|
|
|
case FSF_DATADIR_DIF_WRITE_INSERT:
|
|
|
|
case FSF_DATADIR_DIF_WRITE_CONVERT:
|
2009-11-24 15:54:03 +00:00
|
|
|
case FSF_DATADIR_WRITE:
|
2010-09-08 12:39:55 +00:00
|
|
|
lat = &zfcp_sdev->latencies.write;
|
2009-11-24 15:54:03 +00:00
|
|
|
break;
|
|
|
|
case FSF_DATADIR_CMND:
|
2010-09-08 12:39:55 +00:00
|
|
|
lat = &zfcp_sdev->latencies.cmd;
|
2009-11-24 15:54:03 +00:00
|
|
|
break;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-11-24 15:54:03 +00:00
|
|
|
if (lat) {
|
2010-09-08 12:39:55 +00:00
|
|
|
spin_lock(&zfcp_sdev->latencies.lock);
|
2009-11-24 15:54:03 +00:00
|
|
|
zfcp_fsf_update_lat(&lat->channel, lat_in->channel_lat);
|
|
|
|
zfcp_fsf_update_lat(&lat->fabric, lat_in->fabric_lat);
|
|
|
|
lat->counter++;
|
2010-09-08 12:39:55 +00:00
|
|
|
spin_unlock(&zfcp_sdev->latencies.lock);
|
2009-11-24 15:54:03 +00:00
|
|
|
}
|
2008-10-16 06:23:39 +00:00
|
|
|
}
|
|
|
|
|
2009-11-24 15:54:03 +00:00
|
|
|
blk_add_driver_data(scsi->request->q, scsi->request, &blktrc,
|
|
|
|
sizeof(blktrc));
|
2008-10-16 06:23:39 +00:00
|
|
|
}
|
|
|
|
|
2010-09-08 12:39:58 +00:00
|
|
|
static void zfcp_fsf_fcp_handler_common(struct zfcp_fsf_req *req)
|
2008-07-02 08:56:39 +00:00
|
|
|
{
|
2010-09-08 12:39:55 +00:00
|
|
|
struct scsi_cmnd *scmnd = req->data;
|
|
|
|
struct scsi_device *sdev = scmnd->device;
|
|
|
|
struct zfcp_scsi_dev *zfcp_sdev = sdev_to_zfcp(sdev);
|
2008-07-02 08:56:39 +00:00
|
|
|
struct fsf_qtcb_header *header = &req->qtcb->header;
|
|
|
|
|
|
|
|
if (unlikely(req->status & ZFCP_STATUS_FSFREQ_ERROR))
|
2010-09-08 12:39:58 +00:00
|
|
|
return;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
switch (header->fsf_status) {
|
|
|
|
case FSF_HANDLE_MISMATCH:
|
|
|
|
case FSF_PORT_HANDLE_NOT_VALID:
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_erp_adapter_reopen(zfcp_sdev->port->adapter, 0, "fssfch1",
|
|
|
|
req);
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
|
|
|
break;
|
|
|
|
case FSF_FCPLUN_NOT_VALID:
|
|
|
|
case FSF_LUN_HANDLE_NOT_VALID:
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_erp_port_reopen(zfcp_sdev->port, 0, "fssfch2", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2008-07-02 08:56:39 +00:00
|
|
|
case FSF_SERVICE_CLASS_NOT_SUPPORTED:
|
|
|
|
zfcp_fsf_class_not_supp(req);
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
2008-07-02 08:56:39 +00:00
|
|
|
case FSF_ACCESS_DENIED:
|
2010-09-08 12:39:59 +00:00
|
|
|
zfcp_cfdc_lun_denied(sdev, &header->fsf_status_qual);
|
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2008-07-02 08:56:39 +00:00
|
|
|
break;
|
|
|
|
case FSF_DIRECTION_INDICATOR_NOT_VALID:
|
|
|
|
dev_err(&req->adapter->ccw_device->dev,
|
2010-09-08 12:39:55 +00:00
|
|
|
"Incorrect direction %d, LUN 0x%016Lx on port "
|
2008-10-01 10:42:15 +00:00
|
|
|
"0x%016Lx closed\n",
|
2008-07-02 08:56:39 +00:00
|
|
|
req->qtcb->bottom.io.data_direction,
|
2010-09-08 12:39:55 +00:00
|
|
|
(unsigned long long)zfcp_scsi_dev_lun(sdev),
|
|
|
|
(unsigned long long)zfcp_sdev->port->wwpn);
|
|
|
|
zfcp_erp_adapter_shutdown(zfcp_sdev->port->adapter, 0,
|
|
|
|
"fssfch3", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
|
|
|
break;
|
|
|
|
case FSF_CMND_LENGTH_NOT_VALID:
|
|
|
|
dev_err(&req->adapter->ccw_device->dev,
|
2010-09-08 12:39:55 +00:00
|
|
|
"Incorrect CDB length %d, LUN 0x%016Lx on "
|
2008-10-01 10:42:15 +00:00
|
|
|
"port 0x%016Lx closed\n",
|
2008-07-02 08:56:39 +00:00
|
|
|
req->qtcb->bottom.io.fcp_cmnd_length,
|
2010-09-08 12:39:55 +00:00
|
|
|
(unsigned long long)zfcp_scsi_dev_lun(sdev),
|
|
|
|
(unsigned long long)zfcp_sdev->port->wwpn);
|
|
|
|
zfcp_erp_adapter_shutdown(zfcp_sdev->port->adapter, 0,
|
|
|
|
"fssfch4", req);
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
|
|
|
break;
|
|
|
|
case FSF_PORT_BOXED:
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_erp_port_boxed(zfcp_sdev->port, "fssfch5", req);
|
2009-11-24 15:54:15 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2008-07-02 08:56:39 +00:00
|
|
|
break;
|
|
|
|
case FSF_LUN_BOXED:
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_erp_lun_boxed(sdev, "fssfch6", req);
|
2009-11-24 15:54:15 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2008-07-02 08:56:39 +00:00
|
|
|
break;
|
|
|
|
case FSF_ADAPTER_STATUS_AVAILABLE:
|
|
|
|
if (header->fsf_status_qual.word[0] ==
|
|
|
|
FSF_SQ_INVOKE_LINK_TEST_PROCEDURE)
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_fc_test_link(zfcp_sdev->port);
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_ERROR;
|
2005-04-16 22:20:36 +00:00
|
|
|
break;
|
|
|
|
}
|
2010-09-08 12:39:58 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static void zfcp_fsf_fcp_cmnd_handler(struct zfcp_fsf_req *req)
|
|
|
|
{
|
|
|
|
struct scsi_cmnd *scpnt;
|
|
|
|
struct fcp_resp_with_ext *fcp_rsp;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
zfcp_fsf_fcp_handler_common(req);
|
|
|
|
|
|
|
|
read_lock_irqsave(&req->adapter->abort_lock, flags);
|
|
|
|
|
|
|
|
scpnt = req->data;
|
|
|
|
if (unlikely(!scpnt)) {
|
|
|
|
read_unlock_irqrestore(&req->adapter->abort_lock, flags);
|
|
|
|
return;
|
2008-07-02 08:56:39 +00:00
|
|
|
}
|
2010-09-08 12:39:58 +00:00
|
|
|
|
|
|
|
if (unlikely(req->status & ZFCP_STATUS_FSFREQ_ERROR)) {
|
|
|
|
set_host_byte(scpnt, DID_TRANSPORT_DISRUPTED);
|
|
|
|
goto skip_fsfstatus;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (req->qtcb->header.fsf_status) {
|
|
|
|
case FSF_INCONSISTENT_PROT_DATA:
|
|
|
|
case FSF_INVALID_PROT_PARM:
|
|
|
|
set_host_byte(scpnt, DID_ERROR);
|
|
|
|
goto skip_fsfstatus;
|
|
|
|
case FSF_BLOCK_GUARD_CHECK_FAILURE:
|
|
|
|
zfcp_scsi_dif_sense_error(scpnt, 0x1);
|
|
|
|
goto skip_fsfstatus;
|
|
|
|
case FSF_APP_TAG_CHECK_FAILURE:
|
|
|
|
zfcp_scsi_dif_sense_error(scpnt, 0x2);
|
|
|
|
goto skip_fsfstatus;
|
|
|
|
case FSF_REF_TAG_CHECK_FAILURE:
|
|
|
|
zfcp_scsi_dif_sense_error(scpnt, 0x3);
|
|
|
|
goto skip_fsfstatus;
|
|
|
|
}
|
|
|
|
fcp_rsp = (struct fcp_resp_with_ext *) &req->qtcb->bottom.io.fcp_rsp;
|
|
|
|
zfcp_fc_eval_fcp_rsp(fcp_rsp, scpnt);
|
|
|
|
|
|
|
|
skip_fsfstatus:
|
|
|
|
zfcp_fsf_req_trace(req, scpnt);
|
|
|
|
zfcp_dbf_scsi_result(req->adapter->dbf, scpnt, req);
|
|
|
|
|
|
|
|
scpnt->host_scribble = NULL;
|
|
|
|
(scpnt->scsi_done) (scpnt);
|
|
|
|
/*
|
|
|
|
* We must hold this lock until scsi_done has been called.
|
|
|
|
* Otherwise we may call scsi_done after abort regarding this
|
|
|
|
* command has completed.
|
|
|
|
* Note: scsi_done must not block!
|
|
|
|
*/
|
|
|
|
read_unlock_irqrestore(&req->adapter->abort_lock, flags);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2010-07-16 13:37:42 +00:00
|
|
|
static int zfcp_fsf_set_data_dir(struct scsi_cmnd *scsi_cmnd, u32 *data_dir)
|
|
|
|
{
|
|
|
|
switch (scsi_get_prot_op(scsi_cmnd)) {
|
|
|
|
case SCSI_PROT_NORMAL:
|
|
|
|
switch (scsi_cmnd->sc_data_direction) {
|
|
|
|
case DMA_NONE:
|
|
|
|
*data_dir = FSF_DATADIR_CMND;
|
|
|
|
break;
|
|
|
|
case DMA_FROM_DEVICE:
|
|
|
|
*data_dir = FSF_DATADIR_READ;
|
|
|
|
break;
|
|
|
|
case DMA_TO_DEVICE:
|
|
|
|
*data_dir = FSF_DATADIR_WRITE;
|
|
|
|
break;
|
|
|
|
case DMA_BIDIRECTIONAL:
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
|
|
|
|
case SCSI_PROT_READ_STRIP:
|
|
|
|
*data_dir = FSF_DATADIR_DIF_READ_STRIP;
|
|
|
|
break;
|
|
|
|
case SCSI_PROT_WRITE_INSERT:
|
|
|
|
*data_dir = FSF_DATADIR_DIF_WRITE_INSERT;
|
|
|
|
break;
|
|
|
|
case SCSI_PROT_READ_PASS:
|
|
|
|
*data_dir = FSF_DATADIR_DIF_READ_CONVERT;
|
|
|
|
break;
|
|
|
|
case SCSI_PROT_WRITE_PASS:
|
|
|
|
*data_dir = FSF_DATADIR_DIF_WRITE_CONVERT;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
/**
|
2010-09-08 12:39:55 +00:00
|
|
|
* zfcp_fsf_fcp_cmnd - initiate an FCP command (for a SCSI command)
|
2008-07-02 08:56:39 +00:00
|
|
|
* @scsi_cmnd: scsi command to be sent
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2010-09-08 12:39:55 +00:00
|
|
|
int zfcp_fsf_fcp_cmnd(struct scsi_cmnd *scsi_cmnd)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_fsf_req *req;
|
2009-11-24 15:54:08 +00:00
|
|
|
struct fcp_cmnd *fcp_cmnd;
|
2009-05-15 11:18:17 +00:00
|
|
|
unsigned int sbtype = SBAL_FLAGS0_TYPE_READ;
|
2010-07-16 13:37:42 +00:00
|
|
|
int real_bytes, retval = -EIO, dix_bytes = 0;
|
2010-09-08 12:39:55 +00:00
|
|
|
struct scsi_device *sdev = scsi_cmnd->device;
|
|
|
|
struct zfcp_scsi_dev *zfcp_sdev = sdev_to_zfcp(sdev);
|
|
|
|
struct zfcp_adapter *adapter = zfcp_sdev->port->adapter;
|
2009-08-18 13:43:19 +00:00
|
|
|
struct zfcp_qdio *qdio = adapter->qdio;
|
2010-07-16 13:37:42 +00:00
|
|
|
struct fsf_qtcb_bottom_io *io;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-09-08 12:39:55 +00:00
|
|
|
if (unlikely(!(atomic_read(&zfcp_sdev->status) &
|
2008-07-02 08:56:39 +00:00
|
|
|
ZFCP_STATUS_COMMON_UNBLOCKED)))
|
|
|
|
return -EBUSY;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-08-18 13:43:19 +00:00
|
|
|
spin_lock(&qdio->req_q_lock);
|
2010-07-16 13:37:38 +00:00
|
|
|
if (atomic_read(&qdio->req_q_free) <= 0) {
|
2009-08-18 13:43:19 +00:00
|
|
|
atomic_inc(&qdio->req_q_full);
|
2008-07-02 08:56:39 +00:00
|
|
|
goto out;
|
2009-03-02 12:09:01 +00:00
|
|
|
}
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2010-04-30 16:09:34 +00:00
|
|
|
if (scsi_cmnd->sc_data_direction == DMA_TO_DEVICE)
|
|
|
|
sbtype = SBAL_FLAGS0_TYPE_WRITE;
|
|
|
|
|
2009-08-18 13:43:19 +00:00
|
|
|
req = zfcp_fsf_req_create(qdio, FSF_QTCB_FCP_CMND,
|
2010-04-30 16:09:34 +00:00
|
|
|
sbtype, adapter->pool.scsi_req);
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2008-08-21 11:43:37 +00:00
|
|
|
if (IS_ERR(req)) {
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = PTR_ERR(req);
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
2010-07-16 13:37:42 +00:00
|
|
|
scsi_cmnd->host_scribble = (unsigned char *) req->req_id;
|
|
|
|
|
|
|
|
io = &req->qtcb->bottom.io;
|
2009-08-18 13:43:16 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_CLEANUP;
|
2008-07-02 08:56:39 +00:00
|
|
|
req->data = scsi_cmnd;
|
2010-09-08 12:39:58 +00:00
|
|
|
req->handler = zfcp_fsf_fcp_cmnd_handler;
|
2010-09-08 12:39:55 +00:00
|
|
|
req->qtcb->header.lun_handle = zfcp_sdev->lun_handle;
|
|
|
|
req->qtcb->header.port_handle = zfcp_sdev->port->handle;
|
2010-07-16 13:37:42 +00:00
|
|
|
io->service_class = FSF_CLASS_3;
|
|
|
|
io->fcp_cmnd_length = FCP_CMND_LEN;
|
2008-07-02 08:56:39 +00:00
|
|
|
|
2010-07-16 13:37:42 +00:00
|
|
|
if (scsi_get_prot_op(scsi_cmnd) != SCSI_PROT_NORMAL) {
|
|
|
|
io->data_block_length = scsi_cmnd->device->sector_size;
|
|
|
|
io->ref_tag_value = scsi_get_lba(scsi_cmnd) & 0xFFFFFFFF;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2010-07-16 13:37:42 +00:00
|
|
|
zfcp_fsf_set_data_dir(scsi_cmnd, &io->data_direction);
|
|
|
|
|
2009-11-24 15:54:08 +00:00
|
|
|
fcp_cmnd = (struct fcp_cmnd *) &req->qtcb->bottom.io.fcp_cmnd;
|
|
|
|
zfcp_fc_scsi_to_fcp(fcp_cmnd, scsi_cmnd);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-07-16 13:37:42 +00:00
|
|
|
if (scsi_prot_sg_count(scsi_cmnd)) {
|
|
|
|
zfcp_qdio_set_data_div(qdio, &req->qdio_req,
|
|
|
|
scsi_prot_sg_count(scsi_cmnd));
|
|
|
|
dix_bytes = zfcp_qdio_sbals_from_sg(qdio, &req->qdio_req,
|
|
|
|
scsi_prot_sglist(scsi_cmnd));
|
|
|
|
io->prot_data_length = dix_bytes;
|
|
|
|
}
|
|
|
|
|
2010-04-30 16:09:34 +00:00
|
|
|
real_bytes = zfcp_qdio_sbals_from_sg(qdio, &req->qdio_req,
|
2010-07-16 13:37:37 +00:00
|
|
|
scsi_sglist(scsi_cmnd));
|
2010-07-16 13:37:42 +00:00
|
|
|
|
|
|
|
if (unlikely(real_bytes < 0) || unlikely(dix_bytes < 0))
|
2008-07-02 08:56:39 +00:00
|
|
|
goto failed_scsi_cmnd;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-07-16 13:37:42 +00:00
|
|
|
zfcp_qdio_set_sbale_last(adapter->qdio, &req->qdio_req);
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = zfcp_fsf_req_send(req);
|
|
|
|
if (unlikely(retval))
|
|
|
|
goto failed_scsi_cmnd;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
failed_scsi_cmnd:
|
|
|
|
zfcp_fsf_req_free(req);
|
|
|
|
scsi_cmnd->host_scribble = NULL;
|
|
|
|
out:
|
2009-08-18 13:43:19 +00:00
|
|
|
spin_unlock(&qdio->req_q_lock);
|
2008-07-02 08:56:39 +00:00
|
|
|
return retval;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2010-09-08 12:39:58 +00:00
|
|
|
static void zfcp_fsf_fcp_task_mgmt_handler(struct zfcp_fsf_req *req)
|
|
|
|
{
|
|
|
|
struct fcp_resp_with_ext *fcp_rsp;
|
|
|
|
struct fcp_resp_rsp_info *rsp_info;
|
|
|
|
|
|
|
|
zfcp_fsf_fcp_handler_common(req);
|
|
|
|
|
|
|
|
fcp_rsp = (struct fcp_resp_with_ext *) &req->qtcb->bottom.io.fcp_rsp;
|
|
|
|
rsp_info = (struct fcp_resp_rsp_info *) &fcp_rsp[1];
|
|
|
|
|
|
|
|
if ((rsp_info->rsp_code != FCP_TMF_CMPL) ||
|
|
|
|
(req->status & ZFCP_STATUS_FSFREQ_ERROR))
|
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_TMFUNCFAILED;
|
|
|
|
}
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
/**
|
2010-09-08 12:39:55 +00:00
|
|
|
* zfcp_fsf_fcp_task_mgmt - send SCSI task management command
|
|
|
|
* @scmnd: SCSI command to send the task management command for
|
2008-07-02 08:56:39 +00:00
|
|
|
* @tm_flags: unsigned byte for task management flags
|
|
|
|
* Returns: on success pointer to struct fsf_req, NULL otherwise
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2010-09-08 12:39:55 +00:00
|
|
|
struct zfcp_fsf_req *zfcp_fsf_fcp_task_mgmt(struct scsi_cmnd *scmnd,
|
|
|
|
u8 tm_flags)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_fsf_req *req = NULL;
|
2009-11-24 15:54:08 +00:00
|
|
|
struct fcp_cmnd *fcp_cmnd;
|
2010-09-08 12:39:55 +00:00
|
|
|
struct zfcp_scsi_dev *zfcp_sdev = sdev_to_zfcp(scmnd->device);
|
|
|
|
struct zfcp_qdio *qdio = zfcp_sdev->port->adapter->qdio;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-09-08 12:39:55 +00:00
|
|
|
if (unlikely(!(atomic_read(&zfcp_sdev->status) &
|
2008-07-02 08:56:39 +00:00
|
|
|
ZFCP_STATUS_COMMON_UNBLOCKED)))
|
|
|
|
return NULL;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_lock_irq(&qdio->req_q_lock);
|
2010-04-30 16:09:35 +00:00
|
|
|
if (zfcp_qdio_sbal_get(qdio))
|
2008-07-02 08:56:39 +00:00
|
|
|
goto out;
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2009-08-18 13:43:19 +00:00
|
|
|
req = zfcp_fsf_req_create(qdio, FSF_QTCB_FCP_CMND,
|
2010-04-30 16:09:34 +00:00
|
|
|
SBAL_FLAGS0_TYPE_WRITE,
|
2009-08-18 13:43:19 +00:00
|
|
|
qdio->adapter->pool.scsi_req);
|
2009-08-18 13:43:16 +00:00
|
|
|
|
2008-11-26 17:07:37 +00:00
|
|
|
if (IS_ERR(req)) {
|
|
|
|
req = NULL;
|
2008-07-02 08:56:39 +00:00
|
|
|
goto out;
|
2008-11-26 17:07:37 +00:00
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
req->status |= ZFCP_STATUS_FSFREQ_TASK_MANAGEMENT;
|
2010-09-08 12:39:55 +00:00
|
|
|
req->data = scmnd;
|
2010-09-08 12:39:58 +00:00
|
|
|
req->handler = zfcp_fsf_fcp_task_mgmt_handler;
|
2010-09-08 12:39:55 +00:00
|
|
|
req->qtcb->header.lun_handle = zfcp_sdev->lun_handle;
|
|
|
|
req->qtcb->header.port_handle = zfcp_sdev->port->handle;
|
2008-07-02 08:56:39 +00:00
|
|
|
req->qtcb->bottom.io.data_direction = FSF_DATADIR_CMND;
|
|
|
|
req->qtcb->bottom.io.service_class = FSF_CLASS_3;
|
2009-11-24 15:54:08 +00:00
|
|
|
req->qtcb->bottom.io.fcp_cmnd_length = FCP_CMND_LEN;
|
2008-07-02 08:56:39 +00:00
|
|
|
|
2010-04-30 16:09:34 +00:00
|
|
|
zfcp_qdio_set_sbale_last(qdio, &req->qdio_req);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2009-11-24 15:54:08 +00:00
|
|
|
fcp_cmnd = (struct fcp_cmnd *) &req->qtcb->bottom.io.fcp_cmnd;
|
2010-09-08 12:39:55 +00:00
|
|
|
zfcp_fc_fcp_tm(fcp_cmnd, scmnd->device, tm_flags);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
zfcp_fsf_start_timer(req, ZFCP_SCSI_ER_TIMEOUT);
|
|
|
|
if (!zfcp_fsf_req_send(req))
|
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
zfcp_fsf_req_free(req);
|
|
|
|
req = NULL;
|
|
|
|
out:
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2008-07-02 08:56:39 +00:00
|
|
|
return req;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
static void zfcp_fsf_control_file_handler(struct zfcp_fsf_req *req)
|
|
|
|
{
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
/**
|
|
|
|
* zfcp_fsf_control_file - control file upload/download
|
|
|
|
* @adapter: pointer to struct zfcp_adapter
|
|
|
|
* @fsf_cfdc: pointer to struct zfcp_fsf_cfdc
|
|
|
|
* Returns: on success pointer to struct zfcp_fsf_req, NULL otherwise
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_fsf_req *zfcp_fsf_control_file(struct zfcp_adapter *adapter,
|
|
|
|
struct zfcp_fsf_cfdc *fsf_cfdc)
|
2005-04-16 22:20:36 +00:00
|
|
|
{
|
2009-08-18 13:43:19 +00:00
|
|
|
struct zfcp_qdio *qdio = adapter->qdio;
|
2008-07-02 08:56:39 +00:00
|
|
|
struct zfcp_fsf_req *req = NULL;
|
|
|
|
struct fsf_qtcb_bottom_support *bottom;
|
|
|
|
int direction, retval = -EIO, bytes;
|
|
|
|
|
|
|
|
if (!(adapter->adapter_features & FSF_FEATURE_CFDC))
|
|
|
|
return ERR_PTR(-EOPNOTSUPP);
|
|
|
|
|
|
|
|
switch (fsf_cfdc->command) {
|
|
|
|
case FSF_QTCB_DOWNLOAD_CONTROL_FILE:
|
|
|
|
direction = SBAL_FLAGS0_TYPE_WRITE;
|
|
|
|
break;
|
|
|
|
case FSF_QTCB_UPLOAD_CONTROL_FILE:
|
|
|
|
direction = SBAL_FLAGS0_TYPE_READ;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
return ERR_PTR(-EINVAL);
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_lock_irq(&qdio->req_q_lock);
|
2010-04-30 16:09:35 +00:00
|
|
|
if (zfcp_qdio_sbal_get(qdio))
|
2008-07-02 08:56:39 +00:00
|
|
|
goto out;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2010-04-30 16:09:34 +00:00
|
|
|
req = zfcp_fsf_req_create(qdio, fsf_cfdc->command, direction, NULL);
|
2008-08-21 11:43:37 +00:00
|
|
|
if (IS_ERR(req)) {
|
2008-07-02 08:56:39 +00:00
|
|
|
retval = -EPERM;
|
|
|
|
goto out;
|
|
|
|
}
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
req->handler = zfcp_fsf_control_file_handler;
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
bottom = &req->qtcb->bottom.support;
|
|
|
|
bottom->operation_subtype = FSF_CFDC_OPERATION_SUBTYPE;
|
|
|
|
bottom->option = fsf_cfdc->option;
|
2005-09-13 19:50:38 +00:00
|
|
|
|
2010-07-16 13:37:37 +00:00
|
|
|
bytes = zfcp_qdio_sbals_from_sg(qdio, &req->qdio_req, fsf_cfdc->sg);
|
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (bytes != ZFCP_CFDC_MAX_SIZE) {
|
|
|
|
zfcp_fsf_req_free(req);
|
|
|
|
goto out;
|
|
|
|
}
|
2010-07-16 13:37:42 +00:00
|
|
|
zfcp_qdio_set_sbale_last(adapter->qdio, &req->qdio_req);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
zfcp_fsf_start_timer(req, ZFCP_FSF_REQUEST_TIMEOUT);
|
|
|
|
retval = zfcp_fsf_req_send(req);
|
|
|
|
out:
|
[SCSI] zfcp: Change spin_lock_bh to spin_lock_irq to fix lockdep warning
With the change to use the data on the SCSI device, iterating through
all LUNs/scsi_devices takes the SCSI host_lock. This triggers warnings
from the lock dependency checker:
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #97
---------------------------------------------------------
chchp/3224 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->req_q_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this: [ 24.972394] 2 locks held by chchp/3224:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-....}, at: [<0000000000490302>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.34.1 #98
---------------------------------------------------------
chchp/3235 just changed the state of lock:
(&(shost->host_lock)->rlock){-.-...}, at: [<00000000003a73f4>] __scsi_iterate_devices+0x38/0xbc
but this lock took another, HARDIRQ-unsafe lock in the past:
(&(&qdio->stat_lock)->rlock){+.-...}
and interrupts could create inverse lock ordering between them.
other info that might help us debug this:
2 locks held by chchp/3235:
#0: (&(sch->lock)->rlock){-.-...}, at: [<0000000000401efa>] do_IRQ+0xb2/0x1e4
#1: (&adapter->port_list_lock){.-.-..}, at: [<00000000004902f6>] zfcp_erp_modify_adapter_status+0x9e/0x16c
[...]
To stop this warning, change the request queue lock to disable irqs,
not only softirq. The changes are required only outside of the
critical "send fcp command" path.
Reviewed-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: Christof Schmitt <christof.schmitt@de.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
2010-09-08 12:39:57 +00:00
|
|
|
spin_unlock_irq(&qdio->req_q_lock);
|
2005-09-13 19:50:38 +00:00
|
|
|
|
2008-07-02 08:56:39 +00:00
|
|
|
if (!retval) {
|
2009-08-18 13:43:14 +00:00
|
|
|
wait_for_completion(&req->completion);
|
2008-07-02 08:56:39 +00:00
|
|
|
return req;
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2008-07-02 08:56:39 +00:00
|
|
|
return ERR_PTR(retval);
|
2005-04-16 22:20:36 +00:00
|
|
|
}
|
2009-08-18 13:43:13 +00:00
|
|
|
|
|
|
|
/**
|
|
|
|
* zfcp_fsf_reqid_check - validate req_id contained in SBAL returned by QDIO
|
|
|
|
* @adapter: pointer to struct zfcp_adapter
|
|
|
|
* @sbal_idx: response queue index of SBAL to be processed
|
|
|
|
*/
|
2009-08-18 13:43:19 +00:00
|
|
|
void zfcp_fsf_reqid_check(struct zfcp_qdio *qdio, int sbal_idx)
|
2009-08-18 13:43:13 +00:00
|
|
|
{
|
2009-08-18 13:43:19 +00:00
|
|
|
struct zfcp_adapter *adapter = qdio->adapter;
|
2010-07-16 13:37:38 +00:00
|
|
|
struct qdio_buffer *sbal = qdio->res_q[sbal_idx];
|
2009-08-18 13:43:13 +00:00
|
|
|
struct qdio_buffer_element *sbale;
|
|
|
|
struct zfcp_fsf_req *fsf_req;
|
2010-02-17 10:18:50 +00:00
|
|
|
unsigned long req_id;
|
2009-08-18 13:43:13 +00:00
|
|
|
int idx;
|
|
|
|
|
|
|
|
for (idx = 0; idx < QDIO_MAX_ELEMENTS_PER_BUFFER; idx++) {
|
|
|
|
|
|
|
|
sbale = &sbal->element[idx];
|
|
|
|
req_id = (unsigned long) sbale->addr;
|
2010-02-17 10:18:50 +00:00
|
|
|
fsf_req = zfcp_reqlist_find_rm(adapter->req_list, req_id);
|
2009-08-18 13:43:13 +00:00
|
|
|
|
2010-07-16 13:37:43 +00:00
|
|
|
if (!fsf_req) {
|
2009-08-18 13:43:13 +00:00
|
|
|
/*
|
|
|
|
* Unknown request means that we have potentially memory
|
|
|
|
* corruption and must stop the machine immediately.
|
|
|
|
*/
|
2010-07-16 13:37:43 +00:00
|
|
|
zfcp_qdio_siosl(adapter);
|
2009-08-18 13:43:13 +00:00
|
|
|
panic("error: unknown req_id (%lx) on adapter %s.\n",
|
|
|
|
req_id, dev_name(&adapter->ccw_device->dev));
|
2010-07-16 13:37:43 +00:00
|
|
|
}
|
2009-08-18 13:43:13 +00:00
|
|
|
|
2010-02-17 10:18:59 +00:00
|
|
|
fsf_req->qdio_req.sbal_response = sbal_idx;
|
2009-08-18 13:43:13 +00:00
|
|
|
zfcp_fsf_req_complete(fsf_req);
|
|
|
|
|
|
|
|
if (likely(sbale->flags & SBAL_FLAGS_LAST_ENTRY))
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|