dect
/
asterisk
Archived
13
0
Fork 0
Commit Graph

264 Commits

Author SHA1 Message Date
murf 04118c0c21 This solves a crash in the cdr_tds module on 'stop gracefully', for situations where 'settings' is not set to a pointer
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123446 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-17 20:00:36 +00:00
seanbright d205516f1d Last commit for a bit, minor cleanups and move the lock initialization.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123076 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-16 17:33:10 +00:00
seanbright 1e3cc665ed Convert to use stringfields. Still some more work to do on config load/reload.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123044 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-16 17:14:11 +00:00
seanbright bd4312e1a9 Remove some unused variables
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123041 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-16 16:29:18 +00:00
seanbright a6f0a954b6 Coding guidelines stuff only.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@123009 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-16 15:25:03 +00:00
jpeeler 490730a6b3 Goodbye Zaptel, hello DAHDI. Removes Zaptel driver support with DAHDI. Configuration file and dialplan backwards compatability has been put in place where appropiate. Release announcement to follow.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@122234 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-12 17:27:55 +00:00
tilghman f820a7768e Don't unload config on reload, when config has not changed.
(Closes issue #12652)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@116631 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-15 17:58:22 +00:00
tilghman 7fe8fd8510 Ensure that "calldate" is acceptable for a column name.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@115596 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-10 14:19:41 +00:00
seanbright 72c0111028 Minor logging cleanups
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114314 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-20 14:52:07 +00:00
tilghman 67c7e1e162 Oops, buffer wasn't long enough for query
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114152 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-15 20:51:08 +00:00
tilghman 7fcb99764d If any field is not null, but has no default, then it must be set or the insert will fail.
(Closes issue #12285)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114090 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-11 23:26:56 +00:00
tilghman d3c8cbf15a Merged revisions 113874 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r113874 | tilghman | 2008-04-09 13:57:33 -0500 (Wed, 09 Apr 2008) | 4 lines

If the [csv] section does not exist in cdr.conf, then an unload/load sequence
is needed to correct the problem.  Track whether the load succeeded with a
variable, so we can fix this with a simple reload event, instead.

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@113875 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-09 19:00:40 +00:00
qwell 624520ee1c Merged revisions 110779 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r110779 | qwell | 2008-03-25 17:51:17 -0500 (Tue, 25 Mar 2008) | 6 lines

Make file access in cdr_custom similar to cdr_csv.

Fixes issue #12268.

Patch borrowed from r82344

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@110780 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-25 22:51:55 +00:00
twilson 9e8ebe6a94 Go through and fix a bunch of places where character strings were being interpreted as format strings. Most of these changes are solely to make compiling with -Wsecurity and -Wformat=2 happy, and were not
actual problems, per se.  I also added format attributes to any printf wrapper functions I found that didn't have them.  -Wsecurity and -Wmissing-format-attribute added to --enable-dev-mode.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@109447 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-18 15:43:34 +00:00
tilghman 5b1cec965f Convert prepare_and_execute to direct_execute for speed
(closes issue #11935)
 Reported by: falves11
 Patches: 
       20080208__bug11935.diff.txt uploaded by Corydon76 (license 14)
 Tested by: falves11, Corydon76


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@107722 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11 21:10:45 +00:00
tilghman 48fd5486a8 Whitespace changes only
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@107551 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11 16:28:03 +00:00
tilghman 712e98b0a0 Convert to use ast_str
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@105411 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-29 23:53:42 +00:00
tilghman e5122f6dca Permit additional CDR columns to be saved in Postgres. Note that these
changes are backward-compatible, so no changes to UPGRADE.txt are
necessary.
(closes issue #9279)
 Reported by: rottenroddy
 Patches: 
       20080125__bug9279.diff.txt uploaded by Corydon76 (license 14)
 Tested by: Corydon76


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@104101 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25 23:04:20 +00:00
tilghman 507fd79b11 Change the way the new filter feature works, by allowing it to be a column NOT
logged into the database.  This will allow more granularity of a decision
evaluated in the dialplan, then takes effect when posting the CDR.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@98987 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-17 00:13:32 +00:00
tilghman 01335bddee Add the "filter" keyword
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@98947 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-15 23:52:11 +00:00
tilghman 69d71a14de Port Nick Gorham's timestamp patch to adaptive_odbc, too
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@98269 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-11 18:35:30 +00:00
tilghman bcc664ccd5 Commit Nick Gorham's suggestion for timestamp fix
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@98268 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-11 18:30:00 +00:00
tilghman 45f02f8778 Fix problem with timestr going out of scope
(Closes issue #11726, closes issue #11731)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@97805 f38db490-d61c-443f-a65b-d21fe96a405b
2008-01-10 17:38:36 +00:00
rizzo 659205253c remove unnecessary (char *) casts for ast_config_AST_* variables.
There are some left in the .flex files, left to the maintainer...



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@93582 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-18 09:46:18 +00:00
kpfleming d4e966efcc Merged revisions 93180 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r93180 | kpfleming | 2007-12-16 22:44:51 -0800 (Sun, 16 Dec 2007) | 23 lines

In http://lists.digium.com/pipermail/asterisk-dev/2007-December/031145.html,
rizzo brought up some issues related to the way that the metadata required
for menuselect and the rest of the build system is extracted from the source
files. Since I had a few hours to kill on an airplane today, I decided to
improve this situation... so now the system caches the extracted metadata
and uses it to build the menuselect 'tree' as much as it can. The result
of this is that when a single source file is changed, only the metadata for
that file needs to be extracted again, and the rest is used from the cache
files. I also reduced the number of forked processes required to do the
metadata extraction; it was actually possible to do most of what we needed
in the Makefiles themselves without using any shell scripts at all! On my
laptop, these changes resulted in an 80% decrease in the time required
for the 'menuselect.makeopts' automatic check to occur after editing a single
source file.

While doing this work I also cleaned up a few minor things in the Makefiles,
adding a check for 'awk' to the configure script and changed all remaining
places we use 'grep' or 'awk' to use the ones found by the configure script,
and changed the 'prep_tarball' script to build the menuselect metadata so
that tarballs of Asterisk will include it and won't require the user to
wait while it is extracted after unpacking.


........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@93184 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-17 07:25:35 +00:00
tilghman 958387bc2e Don't use backslash as an escape character, unless it really is an escape character.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@92779 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-13 17:46:04 +00:00
rizzo aa85540763 Put into Makefile.moddir_rules the common instructions used to
generate loadable and embedded module lists.

Individual Makefiles now are a lot simpler, possibly as simple as this:

    -include $(ASTTOPDIR)/menuselect.makeopts $(ASTTOPDIR)/menuselect.makedeps
    MODULE_PREFIX=cdr_
    all: _all
    include $(ASTTOPDIR)/Makefile.moddir_rules

and also more flexible because in a single directory we can combine
various types of modules (app_, cdr_, func_, ... ) by simply
listing them in the MODULE_PREFIX variable.

The individual Makefiles can also create list of modules to be
excluded by listing them in the variablel MODULE_EXCLUDE (see an
example in channels/Makefile).

With this change it becomes trivial to integrate a directory with
locally created/modified sources into the main build.




git-svn-id: http://svn.digium.com/svn/asterisk/trunk@92082 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-10 03:50:38 +00:00
rizzo b50ce18fe8 normalize subdirs' Makefile by using ASTTOPDIR and not .. to reference
the top level directory.



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@92022 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-09 21:29:37 +00:00
qwell 21ea51e69a Fix a problem with quoting in sqlite3 cdr module..
Closes issue #11070, patch by seanbright.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@91598 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-06 21:57:28 +00:00
tilghman ee6901bb3c Merged revisions 90166,90736,90753 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r90166 | tilghman | 2007-11-29 13:48:10 -0600 (Thu, 29 Nov 2007) | 3 lines

Properly escape cdr->src and cdr->dst and ensure we use thread-safe escaping
(Fixes AST-2007-026)

........
r90736 | tilghman | 2007-12-03 17:23:55 -0600 (Mon, 03 Dec 2007) | 5 lines

If both dbhost and dbsock were not set, a NULL deref could result
Reported by: xrg
Patch by: tilghman
(Closes issue #11387)

........
r90753 | tilghman | 2007-12-03 17:50:51 -0600 (Mon, 03 Dec 2007) | 5 lines

Solaris requires the inclusion of sys/loadavg.h for getloadavg().
Reported by: snuffy
Patch by: snuffy,tilghman
(Closes issue #11430)

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@91561 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-06 20:52:26 +00:00
tilghman a17700ba80 Change cdr_manager to use a "CDR" level, rather than the (overcrowded) "call" level.
(Closes issue #11015)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@91173 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-05 16:46:47 +00:00
rizzo 150b2c22ef remove another set of redundant #include "asterisk/options.h"
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89512 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-21 23:24:55 +00:00
tilghman 1688610395 Make trunk build again
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89468 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-20 23:29:33 +00:00
rizzo 89d8d78652 move asterisk/paths.h outside asterisk.h and into those files
who really need it.



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89466 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-20 23:16:15 +00:00
rizzo 0cc47e4221 another bunch of include removals (errno.h and asterisk/logger.h)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89425 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-19 19:09:03 +00:00
rizzo ba761e2427 more removal of duplicate #include lines
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89349 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-17 00:02:33 +00:00
rizzo 883346d64a Start untangling header inclusion in a way that does not affect
build times - tested, there is no measureable difference before and
after this commit.

In this change:

use asterisk/compat.h to include a small set of system headers:
inttypes.h, unistd.h, stddef.h, stddint.h, sys/types.h, stdarg.h,
stdlib.h, alloca.h, stdio.h

Where available, the inclusion is conditional on HAVE_FOO_H as determined
by autoconf.

Normally, source files should not include any of the above system headers,
and instead use either "asterisk.h" or "asterisk/compat.h" which does it
better. 

For the time being I have left alone second-level directories
(main/db1-ast, etc.).



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89333 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-16 20:04:58 +00:00
murf 91879350be Based on a note in asterisk-dev by Brian Capouch, I determined I too agressive in not initializing arrays passed to pbx_substitute_variables_xxxx; I reviewed the code (again) and hopefully found every possible spot where substitute_variables is called conditionally, and made sure the char array involved was set to a null string.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89186 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-12 18:44:36 +00:00
qwell d257a152e5 Fix a few potential deadlocks in cdr_sqlite3_custom.
(also rename sample config to .sample)

Closes issue #11208, patch by Laureano.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89130 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-09 16:32:01 +00:00
murf 6d6b520aba Merged revisions 89088 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r89088 | murf | 2007-11-07 14:40:28 -0700 (Wed, 07 Nov 2007) | 1 line

In response to 10578, I just ran 1.4 thru valgrind; some of the config leakage I've already fixed, but it doesn't hurt to double check. I found and fixed leaks in res_jabber, cdr_tds, pbx_ael. Nothing major, tho.
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89089 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-07 22:09:10 +00:00
file a91d1a2abc Restore building under 64-bit platforms.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@88197 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-02 03:09:02 +00:00
tilghman d13f1492f0 Convert cdr_odbc to use res_odbc managed connections
Closes issue #10614


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@88182 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-01 22:43:46 +00:00
murf 47c8ea00b8 This commits the performance mods that give the priority processing engine in the pbx, a 25-30% speed boost. The two updates used, are, first, to merge the ast_exists_extension() and the ast_spawn_extension() where they are called sequentially in a loop in the code, into a slightly upgraded version of ast_spawn_extension(), with a few extra args; and, second, I modified the substitute_variables_helper_full, so it zeroes out the byte after the evaluated string instead of demanding you pre-zero the buffer; I also went thru the code and removed the code that zeroed this buffer before every call to the substitute_variables_helper_full. The first fix provides about a 9% speedup, and the second the rest. These figures come from the 'PIPS' benchmark I describe in blogs, conf. reports, etc.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@88166 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-01 22:26:51 +00:00
tilghman 8380627624 Fix memory leak
Reported by: eliel
Fixed by: tilghman
Closes issue #11136


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@88007 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-01 05:44:40 +00:00
tilghman 6bb53e8955 Set enablecdr at the end of re-reading the config file (Closes issue #10852)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@84130 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-29 18:21:36 +00:00
tilghman e520c2bf27 Fix cdr_manager, such that if the config file is created past load, it'll
start logging (and conversely, if the config file is destroyed or deactivated,
the logging is disabled).  Reported by Juggie via IRC, fix by me.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@83466 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-21 17:36:17 +00:00
file 43a4eed035 Fix memory leaks in pbx_dundi, cdr_pgsql, and the configuration file parser.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@83229 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-20 16:10:57 +00:00
file e346df68a2 Clean up code in cdr_csv. (Are you sensing a theme for me today?)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@83183 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-19 20:06:31 +00:00
qwell cb3876e55f Don't try to continue loading cdr_sqlite3_custom on a module load failure (such as the config not existing)
Closes issue #10749, patch by seanbright.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@82712 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-17 21:52:07 +00:00
qwell 5a7a7ec10e Merged revisions 82344 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r82344 | qwell | 2007-09-13 15:11:40 -0500 (Thu, 13 Sep 2007) | 9 lines

Fix a crash that could occur in cdr_csv when mutliple threads tried to close the same file.

Do we actually need the locking here?  What happens if you open the same file twice, and
 two threads try to write to it at the same time?  Is fputs() going to write out the entire
 line at once?  I suspect that it could be possible for the second fopen to run during the
 first fputs, so the position could be in the middle of the previously written line...

Issue 10347, initial patch by explidous (but I removed all of the paranoia stuff..)

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@82345 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-13 20:13:58 +00:00