3eca9bec9d
- staticize gettag() complete_sip_peer() get_calleridname() arguments;
...
- use strsep() instead of strchr() where appropriate
- constify some args and add comments.
- remove a conditional near line 1940 - we already know what to use.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18793 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-10 12:20:57 +00:00
09c492eb0a
- constification of some functions (args and return values):
...
transmit_response_reliable()
hangup_cause2sip()
- remove useless braces;
- add comments on some slightly cryptic code segments
- mark XXX possible critical pieces of code.
- remove an unneeded string termination after ast_copy_string
- mark usage of some rarely used functions;
- use strsep() instead of emulating it inline;
- replace magic constants with sizeof(array)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18792 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-10 11:57:40 +00:00
8511bfa7e2
- localize 'struct cfalias' into the only function using it;
...
- remove duplicate code to walk through sdp packets, replacing
sdpLineNum_iterator_init(&foo); with "foo = 0";
- remove duplicate code to test ast_test_flag(&p->flags[0], SIP_NAT_ROUTE);
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18791 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-10 11:36:02 +00:00
5e808c207f
constify get_sdp*() and friends.
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18790 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-10 11:19:14 +00:00
21a75386bc
constify get_header(), which let me find out and fix one bug (overwriting
...
a string in the buffer) and finding out another one (not fixed yet,
just marked XXX).
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18789 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-10 11:04:04 +00:00
6ffb63289a
- describe how sip packets are stored internally;
...
- remove useless braces or local variables;
- simplify some code sequences;
- mark with XXX a possible locking issue.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18788 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-10 10:40:13 +00:00
061e21584e
struct sip_request cleanup:
...
- remove a debug field that was read but never set, so it was basically
unused as well as the code testing it (also removed);
- make scalar fields contiguous so any array overflow will be
less harmful;
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18787 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-10 10:30:38 +00:00
fdd8d4339e
more cleanup: remove useless braces, replace "if" with "?",
...
localize a couple of variables, remove trailing whitespace.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18786 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-10 10:22:42 +00:00
e48597051f
Re-instate removed comment
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18785 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-10 10:01:14 +00:00
7717548395
another batch of minor code simplifications
...
(moving repeated expressions into a function, const on
some arguments)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18784 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-10 09:53:22 +00:00
57f651a43c
Bug 6829 - asprintf for Solaris
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18755 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-10 07:48:52 +00:00
2161a93e6e
remove a couple more unnecessary "out of memory" error messages
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18723 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-10 02:19:58 +00:00
b9253231be
use ast_*alloc and don't create duplicated error messages.
...
... as stated in the coding guidelines.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18722 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-10 02:15:47 +00:00
a06d9b22bc
Instead of using strncpy, use ast_copy_string. Also, in the case of copying a
...
constant string into a buffer that we know is big enough, don't use a length
limited copy at all, use strcpy.
... as stated in the coding guidelines.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18721 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-10 02:05:59 +00:00
70f8d1c38b
run the module through indent to fix the formatting issues that violate the
...
coding guidelines
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18704 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-10 02:01:39 +00:00
25faafd4f6
fix typo in the provided indent command
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18694 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-10 01:54:13 +00:00
18a8186d32
add back braces that were removed in a recent commit that leave a bunch of
...
nested statements in a block without branches, which is a violation of the
coding guidelines.
As a matter of fact, this module violates the coding guidelines in multiple
ways that including formatting and code issues. In my opinion, this module
should not have been merged into the trunk in this form.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18693 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-10 01:51:47 +00:00
c40963221e
a bunch of trivial code normalizations (removal of unnecessary
...
casts and parentheses, formatting fixes, pointing out replicated
code and so on). No functional changes.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18666 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-09 23:16:29 +00:00
88110b9c59
rename FR_SET_BUF to AST_FRAME_SET_BUFFER
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18639 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-09 22:31:38 +00:00
46fa1d3472
Issue 6917 - some cleanups for res_config_pgsql.c (mithraen)
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18607 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-09 18:57:25 +00:00
87af6389db
Issue 6919 - clarify error message
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18603 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-09 18:53:46 +00:00
34624c527c
update module license key text and update loader to accept it
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18574 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-08 22:37:30 +00:00
c70f89e9c8
a few cleanups from the last commit
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18572 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-08 22:16:34 +00:00
e4880150b1
since the module API is changing, it's a good time to const-ify the description() and key() return values
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18552 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-08 22:01:19 +00:00
f1822bc2a6
merge rizzo's codec module rework (very similar to the format module rework)
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18541 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-08 21:40:57 +00:00
5adcee992f
Merged revisions 18494 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r18494 | tilghman | 2006-04-08 14:20:45 -0500 (Sat, 08 Apr 2006) | 2 lines
Bug 6914 - .txt file fails to rename on operator out
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18495 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-08 19:22:29 +00:00
9ed3edaa09
fix bug in smdi config parsing (issue #6908 )
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18493 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-08 19:16:38 +00:00
3bf6b880d8
remove traces of "look", something that does not exist in the tree
...
(issue #6904 )
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18492 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-08 19:13:37 +00:00
8057b6139c
Merged revisions 18436 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r18436 | tilghman | 2006-04-07 17:07:38 -0500 (Fri, 07 Apr 2006) | 2 lines
Bug 6913 - fix for possible buffer overflow
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18437 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-07 22:11:12 +00:00
99065f49c3
-Fixing some debugging messages in history and console
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18403 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-07 20:19:44 +00:00
024babaa50
Add history events for re-invites
...
(need to nail this issue...)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18373 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-07 19:46:50 +00:00
6a5ce01672
make history easier to read
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18371 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-07 19:36:44 +00:00
65bae3d66b
Add some more information to SIP history
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18370 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-07 19:25:19 +00:00
3c9910c57e
Issue #6899 - remove OSP support code from chan_sip.c and app_dial.c
...
- implement all functions through internal APIs in res_osp.c and app_osplookup.c
(homesick)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18369 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-07 19:11:22 +00:00
b104ac7d19
Hmm. What is that keyword?? Let me see... Wait... Maybe... Ahh! OOPS!
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18342 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-07 18:52:23 +00:00
c12f6d26dd
change a couple uses of !strlen() to ast_strlen_zero(). Oddly enough, one of
...
these used to be this way and got changed ...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18309 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-07 16:28:50 +00:00
6e477f048b
- sip_alloc failures are also caused by too few available file descriptors, so we can not
...
open socket for RTP (audio/video/rtcp).
Error message change to clarify.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18307 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-07 16:22:28 +00:00
a6e48d17ea
- Add cause code for format error
...
- Change to SWITCH_CONGESTION instead of CONGESTION
(imported from 1.2)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18262 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-07 14:42:25 +00:00
d71370e406
Import of revistion 18250 from 1.2
...
- Fix minor memory leak
- Add proper cause codes on memory allocation failures
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18261 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-07 14:30:14 +00:00
434fabe737
sorry litle mistake
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18221 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-07 12:03:51 +00:00
fe7a25ae24
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18192 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-07 09:46:38 +00:00
0e1d48368b
fixed a bridging-endless-loop also fixed the rdnis is not exported issue
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18190 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-07 09:31:27 +00:00
9007ca78c2
Issue #6674 : Set the URI correctly on BYEs when we have an incoming call
...
Reported by aubergine, fix by oej
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18161 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-07 08:19:52 +00:00
03998522c4
Issue #6580 - Unify directory definitions to one section of Makefile (casper)
...
- Maybe we should define proper directories for OS/X too?
- Should OpenBSD and NetBSD follow the FreeBSD rules?
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18130 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-07 07:04:05 +00:00
21153820b8
Merged revisions 18087 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r18087 | kpfleming | 2006-04-06 17:04:58 -0500 (Thu, 06 Apr 2006) | 3 lines
don't try to support 'i' or 'r' options if chan_zap is not loaded, and warn the user when they attempt to use them (issue #6675 )
update application help text to more clearly define when Zaptel and chan_zap are required
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18090 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-06 22:16:23 +00:00
a8e9c4b68a
Cosmetic update for outbound REFERs
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18060 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-06 21:49:24 +00:00
e815e07c2e
Add "NewChan" event to history to track the birth of a new ast_chan from a
...
SIP invite
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18059 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-06 21:33:39 +00:00
13d18cd0b0
Improved handling of 491 responses
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18058 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-06 21:29:54 +00:00
370ce587c2
Small changes to parse_sip_options
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18057 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-06 21:18:12 +00:00
0ce44edb9c
Small fixes to handle_request_invite
...
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18056 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-06 21:13:32 +00:00
rizzo