Archived
14
0
Fork 0
Commit graph

68 commits

Author SHA1 Message Date
tilghman
80ece487c2 Oops
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@140355 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-27 23:23:56 +00:00
tilghman
6a7394d3c3 Memory leak
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@139707 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-24 16:26:48 +00:00
tilghman
980a351bb3 Eliminate open coding of ast_str
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@139704 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-24 16:23:15 +00:00
seanbright
4965ac5e36 More from the resolve-shadow-warnings branch. This time the cdr/ directory.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@136300 f38db490-d61c-443f-a65b-d21fe96a405b
2008-08-07 00:52:23 +00:00
seanbright
e4e30b0abe Quote column names when inserting CDRs into postgres to avoid conflicts
with reserved words.

(closes issue #12947)
Reported by: panolex


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@126274 f38db490-d61c-443f-a65b-d21fe96a405b
2008-06-29 12:06:46 +00:00
tilghman
7fe8fd8510 Ensure that "calldate" is acceptable for a column name.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@115596 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-10 14:19:41 +00:00
seanbright
72c0111028 Minor logging cleanups
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114314 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-20 14:52:07 +00:00
tilghman
67c7e1e162 Oops, buffer wasn't long enough for query
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114152 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-15 20:51:08 +00:00
tilghman
7fcb99764d If any field is not null, but has no default, then it must be set or the insert will fail.
(Closes issue #12285)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114090 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-11 23:26:56 +00:00
tilghman
48fd5486a8 Whitespace changes only
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@107551 f38db490-d61c-443f-a65b-d21fe96a405b
2008-03-11 16:28:03 +00:00
tilghman
e5122f6dca Permit additional CDR columns to be saved in Postgres. Note that these
changes are backward-compatible, so no changes to UPGRADE.txt are
necessary.
(closes issue #9279)
 Reported by: rottenroddy
 Patches: 
       20080125__bug9279.diff.txt uploaded by Corydon76 (license 14)
 Tested by: Corydon76


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@104101 f38db490-d61c-443f-a65b-d21fe96a405b
2008-02-25 23:04:20 +00:00
tilghman
ee6901bb3c Merged revisions 90166,90736,90753 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r90166 | tilghman | 2007-11-29 13:48:10 -0600 (Thu, 29 Nov 2007) | 3 lines

Properly escape cdr->src and cdr->dst and ensure we use thread-safe escaping
(Fixes AST-2007-026)

........
r90736 | tilghman | 2007-12-03 17:23:55 -0600 (Mon, 03 Dec 2007) | 5 lines

If both dbhost and dbsock were not set, a NULL deref could result
Reported by: xrg
Patch by: tilghman
(Closes issue #11387)

........
r90753 | tilghman | 2007-12-03 17:50:51 -0600 (Mon, 03 Dec 2007) | 5 lines

Solaris requires the inclusion of sys/loadavg.h for getloadavg().
Reported by: snuffy
Patch by: snuffy,tilghman
(Closes issue #11430)

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@91561 f38db490-d61c-443f-a65b-d21fe96a405b
2007-12-06 20:52:26 +00:00
rizzo
150b2c22ef remove another set of redundant #include "asterisk/options.h"
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89512 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-21 23:24:55 +00:00
rizzo
0cc47e4221 another bunch of include removals (errno.h and asterisk/logger.h)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89425 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-19 19:09:03 +00:00
rizzo
ba761e2427 more removal of duplicate #include lines
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89349 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-17 00:02:33 +00:00
rizzo
883346d64a Start untangling header inclusion in a way that does not affect
build times - tested, there is no measureable difference before and
after this commit.

In this change:

use asterisk/compat.h to include a small set of system headers:
inttypes.h, unistd.h, stddef.h, stddint.h, sys/types.h, stdarg.h,
stdlib.h, alloca.h, stdio.h

Where available, the inclusion is conditional on HAVE_FOO_H as determined
by autoconf.

Normally, source files should not include any of the above system headers,
and instead use either "asterisk.h" or "asterisk/compat.h" which does it
better. 

For the time being I have left alone second-level directories
(main/db1-ast, etc.).



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@89333 f38db490-d61c-443f-a65b-d21fe96a405b
2007-11-16 20:04:58 +00:00
file
43a4eed035 Fix memory leaks in pbx_dundi, cdr_pgsql, and the configuration file parser.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@83229 f38db490-d61c-443f-a65b-d21fe96a405b
2007-09-20 16:10:57 +00:00
tilghman
dbec3d56c1 Don't reload a configuration file if nothing has changed.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@79747 f38db490-d61c-443f-a65b-d21fe96a405b
2007-08-16 21:09:46 +00:00
file
a7df13a908 Merged revisions 77540 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77540 | file | 2007-07-27 14:04:08 -0300 (Fri, 27 Jul 2007) | 6 lines

(closes issue #10310)
Reported by: prashant_jois
Patches:
      cdr_pgsql.patch uploaded by prashant (license 114)
Finish the Postgresql connection after the log messages are printed so we don't access invalid memory.

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@77541 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-27 17:05:18 +00:00
mmichelson
a68fc90ea6 Merged revisions 77318 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r77318 | mmichelson | 2007-07-26 13:30:29 -0500 (Thu, 26 Jul 2007) | 8 lines

Two consecutive calls to PQfinish could occur, meaning free gets called on the same variable twice.
This patch sets the connection to NULL after calls to PQfinish so that the problem does not occur.
Also in this patch, prashant_jois informed me that it is safe to pass a null pointer to PQfinish, so
I have removed the check for conn's existence from my_unload_module.

(closes issue 10295, reported by junky, patched by me with input from prashant_jois)


........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@77319 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-26 18:31:28 +00:00
tilghman
74c2948c22 Merge in ast_strftime branch, which changes timestamps to be accurate to the microsecond, instead of only to the second
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@75706 f38db490-d61c-443f-a65b-d21fe96a405b
2007-07-18 19:47:20 +00:00
qwell
b46a50d87a Merged revisions 70612 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r70612 | qwell | 2007-06-20 18:32:39 -0500 (Wed, 20 Jun 2007) | 4 lines

Fix some potential memory leaks in cdr_pgsql.

Issue 10020, patch by me, with credit to prashant_jois for pointing out the problem.

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@70613 f38db490-d61c-443f-a65b-d21fe96a405b
2007-06-20 23:33:49 +00:00
qwell
e5bfda136f Merged revisions 70560 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r70560 | qwell | 2007-06-20 17:55:21 -0500 (Wed, 20 Jun 2007) | 1 line

Fix a stupid mistake in my last cdr_pgsql race condition fix
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@70561 f38db490-d61c-443f-a65b-d21fe96a405b
2007-06-20 22:55:47 +00:00
qwell
724553d96f Merged revisions 70554 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r70554 | qwell | 2007-06-20 17:31:35 -0500 (Wed, 20 Jun 2007) | 4 lines

Fix a race condition in cdr_pgsql that can occur when reloading the module.

Issue 10022, patch by me, with credit to prashant_jois for finding the bug.

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@70555 f38db490-d61c-443f-a65b-d21fe96a405b
2007-06-20 22:32:57 +00:00
kpfleming
4c5507d166 Merged revisions 69392 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r69392 | kpfleming | 2007-06-14 16:50:40 -0500 (Thu, 14 Jun 2007) | 2 lines

use ast_localtime() in every place localtime_r() was being used

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@69405 f38db490-d61c-443f-a65b-d21fe96a405b
2007-06-14 22:09:20 +00:00
russell
f042431847 Add a massive set of changes for converting to use the ast_debug() macro.
(issue #9957, patches from mvanbaak, caio1982, critch, and dimas)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@69327 f38db490-d61c-443f-a65b-d21fe96a405b
2007-06-14 19:39:12 +00:00
russell
f0549e843b Merged revisions 69016 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r69016 | russell | 2007-06-12 14:40:17 -0500 (Tue, 12 Jun 2007) | 4 lines

Fix a memory leak pointed out by prashant_jois in #asterisk-bugs.  PQclear() was
not called on the result structure after doing a PQexec().  Also, fix up some
formatting in passing.

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@69017 f38db490-d61c-443f-a65b-d21fe96a405b
2007-06-12 19:40:41 +00:00
tilghman
eb5d461ed4 Issue 9869 - replace malloc and memset with ast_calloc, and other coding guidelines changes
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@67864 f38db490-d61c-443f-a65b-d21fe96a405b
2007-06-06 21:20:11 +00:00
oej
9df447ca21 Creating new doxygen macro "\extref" to create page that lists
external libraries and URLs to these. Please help me add these
references.

We might want to create a similar macro "\linuxpackage" to list
the needed Linux packages in popular distributions.



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@56647 f38db490-d61c-443f-a65b-d21fe96a405b
2007-02-24 19:27:50 +00:00
file
bca8e89c10 Merged revisions 47584 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
r47584 | file | 2006-11-13 16:28:57 -0500 (Mon, 13 Nov 2006) | 10 lines

Merged revisions 47583 via svnmerge from 
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r47583 | file | 2006-11-13 16:26:36 -0500 (Mon, 13 Nov 2006) | 2 lines

Initialize global pointers for connection and result to NULL. (issue #8356 reported by james)

........

................


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@47585 f38db490-d61c-443f-a65b-d21fe96a405b
2006-11-13 21:32:13 +00:00
file
113df5b62a Magical eightball says warnings be gone.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@43369 f38db490-d61c-443f-a65b-d21fe96a405b
2006-09-20 21:03:37 +00:00
mogorman
73925ee14a everything that loads a config that needs a config file to run
now reports AST_MODULE_LOAD_DECLINE when loading if config file
is not there, also fixed an error in res_config_pgsql where it 
had a non static function when it should.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@41633 f38db490-d61c-443f-a65b-d21fe96a405b
2006-08-31 21:00:20 +00:00
kpfleming
8b0c007ad9 merge new_loader_completion branch, including (at least):
- restructured build tree and makefiles to eliminate recursion problems
  - support for embedded modules
  - support for static builds
  - simpler cross-compilation support
  - simpler module/loader interface (no exported symbols)



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@40722 f38db490-d61c-443f-a65b-d21fe96a405b
2006-08-21 02:11:39 +00:00
kpfleming
73c525e6e2 simplify autoconfig include mechanism (make tholo happy he can use lint again :-)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@32846 f38db490-d61c-443f-a65b-d21fe96a405b
2006-06-07 18:54:56 +00:00
russell
a0994f4447 remove an unused variable, and default the user to asterisk if not specified
in the config file (issue #7153, Mithraen)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@28936 f38db490-d61c-443f-a65b-d21fe96a405b
2006-05-20 01:35:12 +00:00
russell
1649bd82aa various fixes regarding coding guidelines issues
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@28935 f38db490-d61c-443f-a65b-d21fe96a405b
2006-05-20 01:29:08 +00:00
russell
c028a942f9 if a hostname is not specified, connect over a unix socket instead of
connecting to localhost (issue #7145, Mithraen)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@28897 f38db490-d61c-443f-a65b-d21fe96a405b
2006-05-20 00:57:04 +00:00
kpfleming
29f496ef12 Thanks to the fine work of Russell Bryant and Dancho Lazarov, we now have autoconf and menuselect tools for Asterisk!
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@22267 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-24 17:11:45 +00:00
kpfleming
2f4660a236 more module loader related fixes
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@20963 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-17 16:42:21 +00:00
kpfleming
e4880150b1 since the module API is changing, it's a good time to const-ify the description() and key() return values
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@18552 f38db490-d61c-443f-a65b-d21fe96a405b
2006-04-08 22:01:19 +00:00
tilghman
d723568b93 Merged revisions 11503 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r11503 | tilghman | 2006-03-01 11:41:52 -0600 (Wed, 01 Mar 2006) | 2 lines

Bug 6615 - Fix 64bit conversion errors by using a long int

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@11504 f38db490-d61c-443f-a65b-d21fe96a405b
2006-03-01 17:53:05 +00:00
oej
15e8ae94a9 - Adding whitespace that I found unused outside
- Adding "if (option_debug)" before outputting to DEBUG channel


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@8524 f38db490-d61c-443f-a65b-d21fe96a405b
2006-01-24 11:46:29 +00:00
oej
87f12a2537 Declaring conn and result static to avoid collission with realtime driver (issue 6336, pressureman)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@8523 f38db490-d61c-443f-a65b-d21fe96a405b
2006-01-24 11:42:09 +00:00
kpfleming
24c1e3c222 git-svn-id: http://svn.digium.com/svn/asterisk/trunk@7221 f38db490-d61c-443f-a65b-d21fe96a405b 2005-11-29 18:24:39 +00:00
russell
d3ddc001a2 issue #5605
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6979 f38db490-d61c-443f-a65b-d21fe96a405b
2005-11-06 15:09:47 +00:00
russell
bb65d2e30a more doxygenification (issue #5513)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6852 f38db490-d61c-443f-a65b-d21fe96a405b
2005-10-26 13:03:17 +00:00
kpfleming
f89c44df03 more license/copyright header updates (thanks Ian!)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6618 f38db490-d61c-443f-a65b-d21fe96a405b
2005-09-15 15:44:26 +00:00
kpfleming
95fe2b8fd4 update MANY more files with proper copyright/license info (thanks Ian!)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6596 f38db490-d61c-443f-a65b-d21fe96a405b
2005-09-14 20:46:50 +00:00
kpfleming
cfd662aa15 remove complex malloc-avoidance (bug #4601)
remove resetting of variables during unload that will only be freed or set to known values on reload


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@6085 f38db490-d61c-443f-a65b-d21fe96a405b
2005-07-11 21:06:27 +00:00
kpfleming
6f0f46299c more file version tags
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@5866 f38db490-d61c-443f-a65b-d21fe96a405b
2005-06-06 22:12:19 +00:00