dect
/
asterisk
Archived
13
0
Fork 0
Commit Graph

2975 Commits

Author SHA1 Message Date
russell a505dcedc6 Re-introduce proper error handling that was removed in recent commits.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@115850 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-13 17:42:17 +00:00
qwell fe71974780 Correctly document state interface for AddQueueMember. Discovered while looking at issue #12626.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@115705 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-12 16:35:50 +00:00
junky 2939dd5f9d ameliorate load and unload to dont use DECLINED or FAILED, when theres no .conf involved.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@115594 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-10 03:28:50 +00:00
mmichelson 9e3feeac9b Remove a debug line
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@115591 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-09 22:36:50 +00:00
mmichelson 71a41a28b1 Adding support for "urgent" voicemail messages. Messages which are
marked "urgent" are considered to be higher priority than other messages
and so they will be played before any other messages in a user's mailbox.

There are two ways to leave an urgent message. 
1. send the 'U' option to VoiceMail().
2. Set review=yes in voicemail.conf. This will give instructions for 
   a caller to mark a message as urgent after the message has been recorded.

I have tested that this works correctly with file and ODBC storage, and James
Rothenberger (who wrote initial support for this feature) has tested its use
with IMAP storage.

(closes issue #11817)
Reported by: jaroth
	Based on branch http://svn.digium.com/svn/asterisk/team/jrothenberger/asterisk-urgent
Tested by: putnopvut, jaroth



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@115588 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-09 21:22:42 +00:00
tilghman 44e2dbcb9a Allow a password change to be validated by an external script.
(closes issue #12090)
 Reported by: jaroth
 Patches: 
       vm-check-newpassword.diff.txt uploaded by mvanbaak (license 7)
       20080509__bug12090.diff.txt uploaded by Corydon76 (license 14)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@115582 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-09 17:28:06 +00:00
mmichelson 9a51bce912 Merged revisions 115320 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r115320 | mmichelson | 2008-05-05 16:41:34 -0500 (Mon, 05 May 2008) | 13 lines

Don't consider a caller "handled" until the caller is bridged with
a queue member. There was too much of an opportunity for the member
to hang up (either during a delay, announcement, or overly long
agi) between the time that he answered the phone and the time when
he actually was bridged with the caller. The consequence of this
was that if the member hung up in that interval, then proper
abandonment details would not be noted in the queue log if the caller
were to hang up at any point after the member hangup.

(closes issue #12561)
Reported by: ablackthorn


........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@115321 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-05 21:43:21 +00:00
file 520150ff17 Document the 'B' option of app_chanspy.
(closes issue #12582)
Reported by: IgorG
Patches:
      app_chanspy_B_option.diff uploaded by IgorG (license 20)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@115290 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-05 13:52:44 +00:00
dhubbard 42505cae88 app_voicemail uses a taskprocessor for mwi notification subscriptions
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@115274 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-03 04:23:18 +00:00
dhubbard fef763f8ea app_queue uses a taskprocessor for device state changes
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@115270 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-03 03:57:42 +00:00
tilghman 748f3cf456 Add attributes to various API calls, to help track down bugs (and remove a deprecated function)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@115157 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-02 02:33:04 +00:00
tilghman d1cc29c9c1 Modify TIMEOUT() to be accurate down to the millisecond.
(closes issue #10540)
 Reported by: spendergrass
 Patches: 
       20080417__bug10540.diff.txt uploaded by Corydon76 (license 14)
 Tested by: blitzrage


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@115076 f38db490-d61c-443f-a65b-d21fe96a405b
2008-05-01 23:06:23 +00:00
mmichelson ad5fb449de Adding new configuration options to app_queue. This adds two new values
to announce-position, "limit" and "more," as well as a new option, 
announce-position-limit. For more information on the use of these options,
see CHANGES or configs/queues.conf.sample.

(closes issue #10991)
Reported by: slavon
Patches:
      app_q.diff uploaded by slavon (license 288)
Tested by: slavon, putnopvut



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114906 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-30 19:30:41 +00:00
tilghman 712c72b0df Lock around variables retrieved, and copy the values, if they stay persistent,
since another thread could remove them.
(closes issue #12541)
 Reported by: snuffy
 Patches: 
       bug_12156_apps.diff uploaded by snuffy (license 35)
       Several additional changes by me


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114904 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-30 19:21:04 +00:00
mmichelson d5d920b890 Patching app_chanspy to jibe better with what is documented. This allows for
a colon-delimited list of spygroups to be specified when calling the ChanSpy application
with the 'g' option. Prior to this, you could only specify a single group when using the
'g' option.

I also have upped the maximum number of spygroups to 128 and added a #define so that this
can be easily increased or decreased later.

(closes issue #12497)
Reported by: jsmith
Patches:
      app_chanspy_multiple_groups_v2.patch uploaded by jsmith (license 15)
Tested by: atis, jvandal



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114857 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-29 21:07:36 +00:00
mmichelson 312e4a569d Merged revisions 114848 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114848 | mmichelson | 2008-04-29 14:40:06 -0500 (Tue, 29 Apr 2008) | 14 lines

Use the MACRO_CONTEXT and MACRO_EXTEN channel variables instead of the channel's macrocontext
and macroexten fields. This is needed because if macros are daisy-chained, the incorrect 
context and extension are placed on the new channel. I also added locking to the channel prior
to accessing these variables as noted in trunk's janitor project file.


(closes issue #12549)
Reported by: darren1713
Patches:
      app_queue.c.macroextenpatch uploaded by darren1713 (license 116)
	       (with modifications from me)
Tested by: putnopvut


........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114849 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-29 19:42:04 +00:00
mmichelson bcd5162d10 Make app_directory dependent on app_voicemail. This is because the function
which says the person's name is handled inside app_voicemail now.



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114841 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-29 18:48:26 +00:00
mmichelson 531c9307d1 Since there is now a globally available function for saying someone's name, a LOT of
functions in app_directory can be removed since the ODBC-specific lookups are accomplished
within app_voicemail. This change greatly reduces the amount of lines in app_directory that
were solely for the purpose of looking up a name when ODBC_STORAGE is specified for voicemail.

This commit also makes the name-saying interruptable via DTMF.



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114834 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-29 17:56:13 +00:00
mmichelson b473c5b6bf Fix a crash happening in app_directory. This crash would occur if a users.conf existed.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114832 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-29 17:31:26 +00:00
mmichelson fc66a44580 Adding a new option 'n' to app_chanspy. This option allows for the name of the spied-on
party to be spoken instead of the channel name or number.

This was accomplished by adding a new function pointer to point to a function in app_voicemail
which retrieves the name file and plays it. This makes for an easy way that applications may play
a user's name should it be necessary. app_directory, in particular, can be simplified greatly by
this change.

This change comes as a suggestion from Switchvox, which already has this feature. AST-23


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114813 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-28 22:38:07 +00:00
tilghman ab1d90ba28 Add incomplete matching to PBX code and app_dial
(closes issue #12351)
 Reported by: Corydon76
 Patches: 
       20080402__pbx_incomplete__3.diff.txt uploaded by Corydon76 (license 14)
       pbx_incomplete_with_timeout.diff uploaded by fabled (license 448)
 Tested by: Corydon76, fabled


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114773 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-28 16:37:45 +00:00
tilghman c5ab62085f Fix breakage caused by #12028. (Closes issue #12535)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114706 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-28 04:30:02 +00:00
mmichelson 37ff3d379f Adding a new option, 'B' to app_chanspy. This option allows the spy to
barge on the call. It is like the existing whisper option, except that
it allows the spy to talk to both sides of the conversation on which
he is spying.

This feature has existed in Switchvox, and this merges the functionality
into Asterisk.

(AST-32)



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114678 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-25 22:24:32 +00:00
tilghman 48f62970c3 Whitespace changes only
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114667 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-25 20:20:10 +00:00
mmichelson a1f4b242b9 Merged revisions 114662 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114662 | mmichelson | 2008-04-25 14:32:02 -0500 (Fri, 25 Apr 2008) | 4 lines

Move the unlock of the spyee channel to outside the start_spying() function so that
the channel is not unlocked twice when using whisper mode.


........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114663 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-25 19:33:27 +00:00
qwell 411be90034 Merge app_pickupchan with app_directed_pickup, for AST-27.
Initially, this was to be a new feature, with a patch from Switchvox,
 but after discussions, it was noted that this feature already existed in trunk.

The resulting discussions ended in a comment that was along the lines of
 "the patch provided here is a lot smaller than what is already in trunk,
 because it doesn't create a new application and duplicate existing code"

It was decided that these two applications could be easily merged to reduce
 code duplication.  SO, that's what this does.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114660 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-25 18:32:22 +00:00
mmichelson db040bdbf4 This patch allows for forwarding a message with a "comment" attachment
if using IMAP storage for voicemail. The comment will be recorded and attached
as a second attachment in addition to the original message. This will be invoked
if you choose to prepend a message the way you would with file or ODBC storage


(closes issue #12028)
Reported by: jaroth
Patches:
      forward_with_comment_v2.patch uploaded by jaroth (license 50)
Tested by: jaroth



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114656 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-25 18:18:30 +00:00
mmichelson e08435ea1a Fix a memory leak and protect against potential dereferences of a NULL
pointer.



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114651 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-25 16:25:17 +00:00
mvanbaak 94979a8bde Pass the hangup cause all the way to the calling app/channel.
(closes issue #11328)
Reported by: rain
Patches:
      20071207__pass_cause_in_hangup_control_frame.diff.txt uploaded by Corydon76 (license 14)
brought up-to-date to trunk by me


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114637 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-24 22:16:48 +00:00
mmichelson a06caadecb Merged revisions 114628 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114628 | mmichelson | 2008-04-24 15:43:03 -0500 (Thu, 24 Apr 2008) | 8 lines

Output of channel variables when eventwhencalled=vars was set
was being truncated two characters. This patch corrects the
problem.

(closes issue #12493)
Reported by: davidw


........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114629 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-24 20:43:52 +00:00
tilghman 0d0ec49ca5 Fix DST calculation, and fix bug in calculation of whether conf has started yet or not
(Closes issue #12292)
 Reported by: DEA
 Patches: 
       app_meetme-rt-dst-sched-fix.txt uploaded by DEA (license 3)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114617 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-24 19:24:31 +00:00
russell dd1a2730c8 Merged revisions 114597 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114597 | russell | 2008-04-23 15:49:18 -0500 (Wed, 23 Apr 2008) | 10 lines

Fix an issue that caused getting the correct next channel to not always work.
Also, remove setting the amount of time to wait for a digit from 5 seconds back
down to 1/10 of a second.  I believe this was so the beep didn't get played over
and over really fast, but a while back I put in another fix for that issue.

(closes issue #12498)
Reported by: jsmith
Patches:
      app_chanspy_channel_walk.trunk.patch uploaded by jsmith (license 15)

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114598 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-23 20:53:05 +00:00
mmichelson d9d585ff56 Round 2 of IMAP_STORAGE app_voicemail.c fixes:
This fixes a bug that was thought to be fixed already.

app_voicemail, if using IMAP_STORAGE, has a problem because
the IMAP header files include syslog.h, which define LOG_WARNING
and LOG_DEBUG to be different than what Asterisk uses for those
same macros. This was "fixed" in the past by including all the 
IMAP header files prior to including asterisk.h. This fix worked...
unless you were to try to compile with MALLOC_DEBUG. MALLOC_DEBUG
prepends the inclusion of astmm.h to every file, which means that no
matter what order the includes are in in app_voicemail, the unexpected
values for LOG_WARNING and LOG_DEBUG will be in place.

The action taken for this fix was to define AST_LOG_* macros in addition
to the LOG_* macros already defined. These new macros are used in app_voicemail.c,
logger.h, and astobj.h right now, and their use will be encouraged in the future.

In consideration of those who have written third-party modules which use 
the LOG_* macros, these will NOT be removed from the source, however future use
of these macros is discouraged.



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114577 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-23 00:58:49 +00:00
mmichelson 922f1ccbed Round 1 of IMAP_STORAGE-related app_voicemail changes
This makes IMAP_STORAGE include the proper headers if you
have specified the "system" option for --with-imap when running
the configure script and your IMAP-related headers exist in 
/usr/include/c-client.

This change is due to a hasty merge of a 1.4 change I made.



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114575 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-23 00:40:30 +00:00
qwell 1c1bb65c72 Allow setqueuevar=yes (et al) to work, after changes to pbx_builtin_setvar()
(closes issue #12490)
Reported by: bcnit
Patches:
      12490-queuevars-3.diff uploaded by qwell (license 4)
Tested by: qwell


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114540 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-22 18:14:09 +00:00
russell 58439d435a Add a c() option for the Jack() application and JACK_HOOK() funciton for supplying
a custom client name.  Using the channel name is still the default.  This was done
at the request of Jared Smith.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114533 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-22 16:47:00 +00:00
jpeeler 11ee51ef7d (closes issue #6113)
Reported by: oej
Tested by: jpeeler

This patch implements multiple parking lots for parked calls. The default parkinglot is used by default, however setting the channel variable PARKINGLOT in the dialplan will allow use of any other configured parkinglot. See configs/features.conf.sample for more details on setting up another non-default parkinglot. Also, one can (currently) set the default parkinglot to use in the driver configuration file via the parkinglot option.

Patch initially written by oej, brought up to date and finalized by mvanbaak, and then stabilized and converted to astobj2 by me.



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114487 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-21 23:42:45 +00:00
jpeeler 0cb9b81541 This removes an invalid warning message for an incorrectly entered pin, but more importantly removes an inapplicable check. If the first argument passed to app_authenticate does not contain a '/', the argument should be treated as the sole fixed "password" to match against and that is all. (Previous behavior was attempting to open a file based on the pin.)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114327 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-21 15:34:37 +00:00
file 4fabc3fc02 Add MEETME_INFO dialplan function that allows querying various properties of a Meetme conference.
(closes issue #11691)
Reported by: junky
Patches:
      meetme_info.patch uploaded by jpeeler (license 325)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114261 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-18 18:15:11 +00:00
tilghman b770616142 Merged revisions 114242 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114242 | tilghman | 2008-04-18 01:49:16 -0500 (Fri, 18 Apr 2008) | 3 lines

For consistency sake, ensure that the values that ${CALLINGPRES} returns are valid as an
input to SetCallingPres.  (Closes issue #12472)

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114243 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-18 06:53:47 +00:00
mmichelson be662a0ee1 Merged revisions 114226 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114226 | mmichelson | 2008-04-17 16:03:29 -0500 (Thu, 17 Apr 2008) | 9 lines

Declaration of the peer channel in this scope was making it so the peer variable defined
in the outer scope was never set properly, therefore making iterating through the channel
list always restart from the beginning. This bug would have affected anyone who called
chanspy without specifying a first argument.

(closes issue #12461)
Reported by: stever28


........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114227 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-17 21:04:40 +00:00
seanbright 2a329b3d37 Merged revisions 114191 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114191 | seanbright | 2008-04-17 06:51:20 -0400 (Thu, 17 Apr 2008) | 1 line

Make sure we have enough room for the recording's filename.
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114192 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-17 10:55:05 +00:00
tilghman d9fc402428 Standardized routines for forking processes (keeps all the specialized code in one place).
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114188 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-16 22:57:54 +00:00
seanbright 1152ea8b17 Add the ability to disable channel technology name playback when speaking the current channel name
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114165 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-16 12:23:13 +00:00
qwell 5e488b20d2 If somebody enters a digit during ast_stream_and_wait, the return value is the digit, which we need to use later.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114149 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-15 20:27:04 +00:00
seanbright 8ac781fcce I'm not sure why, but "this" bothers me. Ba dum dum.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114143 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-15 17:54:38 +00:00
qwell 33de15d8f6 Merged revisions 114133 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114133 | qwell | 2008-04-15 11:18:08 -0500 (Tue, 15 Apr 2008) | 8 lines

Allow autofill to work in the general section of queues.conf.
Additionally, don't try to (re)set options when they have empty values in realtime (all unset columns would have an empty value).

(closes issue #12445)
Reported by: atis
Patches:
      12445-autofill.diff uploaded by qwell (license 4)

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114134 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-15 16:18:38 +00:00
mmichelson ebaed1af03 Merged revisions 114112 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114112 | mmichelson | 2008-04-14 11:24:22 -0500 (Mon, 14 Apr 2008) | 9 lines

If the datastore has been moved to another channel due to a masquerade, then
freeing the datastore here causes an eventual double free when the new channel
hangs up. We should only free the datastore if we were able to successfully remove
it from the channel we are referencing (i.e. the datastore was not moved).

(closes issue #12359)
Reported by: pguido


........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114113 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-14 16:25:09 +00:00
tilghman 43728f9a34 Use ast_mkdir instead of mkdir
(Closes issue #12430)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114096 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-13 14:35:43 +00:00
file 20457e162e Merged revisions 114029 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r114029 | file | 2008-04-10 12:09:04 -0300 (Thu, 10 Apr 2008) | 6 lines

Create the directory where name recordings will go if it does not exist.
(closes issue #12311)
Reported by: rkeene
Patches:
      12311-mkdir.diff uploaded by qwell (license 4)

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@114030 f38db490-d61c-443f-a65b-d21fe96a405b
2008-04-10 15:10:47 +00:00