dect
/
asterisk
Archived
13
0
Fork 0
Commit Graph

5675 Commits

Author SHA1 Message Date
russell 33d2c8c815 Fix usage of the DAHDI_VMWI ioctl.
(closes issue #14090)
Reported by: alecdavis
Patches:
      chan_dahdi.VMWI_ioctl.diff.txt uploaded by alecdavis (license 585)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164602 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-16 14:17:45 +00:00
russell 4e37275b2f Open a timer before loading configuration so that the trunking configuration option
will take effect.

(closes issue #14082)
Reported by: seandarcy


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164525 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15 22:25:46 +00:00
russell c5bde913d7 Fix log message to refer to the generic timing interface, not DAHDI specifically
(inspired by issue #14082)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164522 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15 22:22:43 +00:00
tilghman 0513d1771d Revert ast_str opacity in chan_sip for now, since something wasn't quite right
in the merge.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164417 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15 19:48:02 +00:00
file 9f71bf15bb Merged revisions 164350 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r164350 | file | 2008-12-15 14:11:21 -0400 (Mon, 15 Dec 2008) | 6 lines
  
  Do not try to unlock a non-existant channel if the transfer fails.
  (closes issue #13800)
  Reported by: dwagner
  Patches:
        asterisk-1.4.22-chan-sip-nullp.patch uploaded by tweety (license 608)
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164351 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15 18:12:24 +00:00
russell 05e67d6ebb Fix a couple more build issues related to ast_str_opaque
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@164309 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-15 17:21:38 +00:00
tilghman a41b34a63c Merge ast_str_opaque branch (discontinue usage of ast_str internals)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163991 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-13 08:36:35 +00:00
murf a39114bf2e demote always-appearing debug message (for certain boards) to ast_debug lev 3 msg instead
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163675 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12 19:16:32 +00:00
russell be5e3b45ae Rename a number of tcptls_session variables. There are no functional changes here.
The name "ser" was used in a lot of places.  However, it is a relic from when
the struct was a server_instance, not a session_instance.  It was renamed since
it represents both a server or client connection.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163670 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12 18:45:03 +00:00
russell 7fecfb67c6 Fix a small race condition in sip_tcp_locate().
We must increase the reference count on the tcptls_session _before_ unlocking
the thread list.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163667 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12 18:33:27 +00:00
russell e3414054a5 Resolve crashes when using SIP TCP/TLS with qualify.
The problem was a reference count error on the tcptls_session structure.

(closes issue #13989)
Reported by: Nugget


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163642 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12 18:19:47 +00:00
file 87948c4647 When a device registers we need to unlink them (if linked) from the peers_by_ip container and link them back in since their IP address has changed. This would have manifested itself if you configured a new device (as type=peer), registered, and then tried to place a call from the device. Since the peer was not linked into the peers_by_ip container it would have never been found.
(closes issue #13811)
Reported by: pj


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163629 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12 18:17:12 +00:00
mvanbaak 524e085635 Fix codec capability setup in chan_skinny
Behaviour now is that general codec config flows to default_line and default_device. [devices] stuff amends default_device and similar for [lines]. These are copied to individual device and line as they are created.
Added confcapability and confprefs for the configured stuff which doesn't change as device and so on are connected. prefs are based on line prefs if they exist, else the device prefs are used (prefs identifies codec order).

(closes issue #13806)
Reported by: pj
Patches:
      codecs.diff uploaded by wedhorn (license 30)
Tested by: pj and me


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163582 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12 17:14:13 +00:00
file 420f3ee2f1 Since chan_sip is callback devicestate driven do not pass in actual states, pass in unknown so we get asked. Additionally do not pass in an actual device state value in ast_setstate since the channel may be callback driven.
(closes issue #13525)
Reported by: pj


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@163579 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-12 16:55:15 +00:00
file 0dce77a779 When a device registers to use it is entirely possible that they may be in use, so tell the core that we don't know the devstate and have it ask us for it.
(closes issue #13525)
Reported by: pj


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@162997 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-11 15:05:49 +00:00
file 79fb3b713f Merged revisions 162804 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r162804 | file | 2008-12-10 15:01:17 -0400 (Wed, 10 Dec 2008) | 6 lines
  
  Fix subscription based MWI up a bit. We only want to put sip: at the beginning of the URI if it is not already there and revert code to ignore destination check if subscribing for MWI.
  (closes issue #12560)
  Reported by: vsauer
  Patches:
        patch001.diff uploaded by ramonpeek (license 266)
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@162805 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-10 19:02:57 +00:00
file abd661613f Merged revisions 162738 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r162738 | file | 2008-12-10 13:50:43 -0400 (Wed, 10 Dec 2008) | 6 lines
  
  When a SIP peer unregisters set the expiry time back to 0 so that the 200 OK contains an expires of 0.
  (closes issue #13599)
  Reported by: hjourdain
  Patches:
        chan_sip.c.diff uploaded by hjourdain (license 583)
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@162739 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-10 17:53:09 +00:00
mmichelson 97103e9bdb Merged revisions 162663 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r162663 | mmichelson | 2008-12-10 10:24:56 -0600 (Wed, 10 Dec 2008) | 11 lines

Revert fix for issue 13570. It has caused more problems than
it helped to fix.

(closes issue #13783)
Reported by: navkumar


(closes issue #14025)
Reported by: ffs


........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@162664 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-10 16:34:35 +00:00
file 4a90fc41fd When transmitting a register set the socket port to the local one for the transport being used, not the port for the remote server.
(closes issue #13633)
Reported by: performer


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@162619 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-10 15:22:26 +00:00
file 4e8098d130 Finish conversion to using ARRAY_LEN and remove it as a janitor project.
(closes issue #14032)
Reported by: bkruse
Patches:
      14032.patch uploaded by bkruse (license 132)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@162542 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-10 01:09:06 +00:00
file 7298cead27 Merged revisions 161725 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r161725 | file | 2008-12-08 13:52:10 -0400 (Mon, 08 Dec 2008) | 6 lines
  
  Make the usereqphone option work again.
  (closes issue #13474)
  Reported by: mmaguire
  Patches:
        20080912_bug13474.diff uploaded by mmaguire (license 571)
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@161726 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-08 17:53:32 +00:00
mnicholson 136a0256a6 Fix a crash that can occur on a transfer in chan_sip when attempting to collect
rtp stats.

(closes issue #13956)
Reported by: chris-mac
Tested by: chris-mac


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@161721 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-08 17:23:41 +00:00
twilson 5a522bc447 Add the ability to play a courtesy tone to the transfer target in a native SIP attended transfer by setting the variable ATTENEDED_TRANSFER_COMPLETE_SOUND.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@161679 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-08 16:02:42 +00:00
eliel 6e243a5434 Janitor, use ARRAY_LEN() when possible.
(closes issue #13990)
Reported by: eliel
Patches:
      array_len.diff uploaded by eliel (license 64)



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@161218 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-05 10:31:25 +00:00
dhubbard a7ebc3e3af If 'faxdetect=yes' in sip.conf, switch to a 'fax' extension (if it exists) after T38 is negotiated.
Terry Wilson created the original patch for this functionality, which I slightly modified and added 
the faxdetect=yes|no configuration option.  This patch is only for T38 fax detection and does not 
do anything for G711 over SIP fax detection.  By default, this option is disabled. 

Reviewboard: http://reviewboard.digium.com/r/69/

This functionality is for issue AST-140.




git-svn-id: http://svn.digium.com/svn/asterisk/trunk@161115 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-04 23:00:30 +00:00
mvanbaak 0d74f1cf03 Add debug flag so skinny debug will show information about packets.
We dont want to scare users with this, so we added a devmode compile flag

(closes issue #13952)
Reported by: wedhorn
Patches:
      packetdebug3.diff uploaded by wedhorn (license 30)
Tested by: mvanbaak, wedhorn


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@160938 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-04 16:37:13 +00:00
eliel 5b0e2e9029 - iax2-provision was not freeing iax_templates structure when unloading the chan_iax2.so module.
- Move the code to start using the LIST macros.

Review: http://reviewboard.digium.com/r/72

(closes issue #13232)
Reported by: eliel
Patches:
      iax2-provision.patch.txt uploaded by eliel (license 64)
      (with minor changes pointed by Mark Michelson on review board)
Tested by: eliel



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@160663 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-03 19:25:30 +00:00
tilghman 56ff6e011e Merged revisions 160480 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r160480 | tilghman | 2008-12-03 08:09:35 -0600 (Wed, 03 Dec 2008) | 7 lines
  
  Jon Bonilla (Manwe) pointed out on the -dev list:
  "I guess that having only ip-phones in mind is not a good approach. Since it is
  possible to have a sip proxy connected to asterisk we could receive a 407
  (unauthorized) or 483 (too many hops) as response and dialog ending would not be
  a good behavior."
  So modified.
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@160481 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-03 14:11:53 +00:00
jpeeler 7d9ae22261 remove duplicate comment that I accidentally merged
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@160333 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-02 18:04:51 +00:00
jpeeler 60cb1eef09 (closes issue #13786)
Reported by: tzafrir

Readding DAHDI_CHECK_HOOKSTATE define that was removed in r134260 which fixes not being able to make outgoing calls on some FXO adapters:
http://lists.digium.com/pipermail/asterisk-users/2008-November/thread.html#221553



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@160319 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-02 18:00:24 +00:00
tilghman 4641797ace Merged revisions 160297 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r160297 | tilghman | 2008-12-02 11:42:09 -0600 (Tue, 02 Dec 2008) | 10 lines
  
  When the text does not match exactly (e.g. RTP/SAVP), then the %n conversion
  fails, and the resulting integer is garbage.  Thus, we must initialize the
  integer and check it afterwards for success.
  (closes issue #14000)
   Reported by: folke
   Patches: 
         asterisk-sipbg-sscanf-1.4.22.diff uploaded by folke (license 626)
         asterisk-sipbg-sscanf-1.6.0.1.diff uploaded by folke (license 626)
         asterisk-sipbg-sscanf-trunk-r159896.diff uploaded by folke (license 626)
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@160308 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-02 17:56:24 +00:00
tilghman ad1d52df72 Merged revisions 160207 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r160207 | tilghman | 2008-12-01 18:25:16 -0600 (Mon, 01 Dec 2008) | 3 lines
  
  Ensure that Asterisk builds with --enable-dev-mode, even on the latest gcc
  and glibc.
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@160208 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-02 00:37:21 +00:00
seanbright 0bf70e2117 Silence a build warning. (chan_phone.c:810: warning: value computed is not used)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@160171 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-01 23:18:48 +00:00
russell 14324a5259 Merged revisions 160003 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r160003 | russell | 2008-12-01 11:27:30 -0600 (Mon, 01 Dec 2008) | 6 lines

Apply some logic used in iax2_indicate() to iax2_setoption(), as well, since they
both have the potential to send control frames in the middle of call setup.  We
have to wait until we have received a message back from the remote end before
we try to send any more frames.  Otherwise, the remote end will consider it
invalid, and we'll get stuck in an INVAL/VNAK storm.

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@160004 f38db490-d61c-443f-a65b-d21fe96a405b
2008-12-01 17:34:31 +00:00
kpfleming 246ce365ae incorporates r159808 from branches/1.4:
------------------------------------------------------------------------
r159808 | kpfleming | 2008-11-29 10:58:29 -0600 (Sat, 29 Nov 2008) | 7 lines

update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors

since this branch already had some printf format attributes, enable checking for them and tag functions that didn't have them

format attributes in a consistent way


------------------------------------------------------------------------

in addition:

move some format attributes from main/utils.c to the header files they belong in, and fix up references to the relevant functions based on new compiler warnings



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@159818 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-29 17:57:39 +00:00
kpfleming bc729d661c we can now build with -Wformat=2, which found a couple of real bugs
because SPRINTF() use non-literal format strings (which cannot be checked), move it into its own module so the rest of func_strings can benefit from format string checking



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@159774 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-29 15:29:33 +00:00
mmichelson afe8f24ea9 Don't allow for configuration options to overwrite options
set via channel variables on a reload.

(closes issue #13921)
Reported by: davidw
Patches:
      13921.patch uploaded by putnopvut (license 60)
Tested by: davidw



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@159437 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-26 14:58:17 +00:00
murf 25c015126d Merged revisions 159316 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r159316 | murf | 2008-11-25 15:41:10 -0700 (Tue, 25 Nov 2008) | 15 lines

(closes issue #12694)
Reported by: yraber
Patches:
      12694.2nd.diff uploaded by murf (license 17)
Tested by: murf, laurav

Thanks to file (Joshua Colp) for his IAX fix.

the change to cdr.c allows no-answer to percolate
up into CDR's, and feels like the right place to
locate this fix; if BUSY is done here, no-answer
should be, too.



........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@159360 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-25 23:03:01 +00:00
tilghman a836c3d93b Add an option, waitfordialtone, for UK analog lines which do not end a call
until the originating line hangs up.
(closes issue #12382)
 Reported by: one47
 Patches: 
       zap-waitfordialtone-trunk.080901.patch uploaded by one47 (license 23)
       zap-waitfordialtone-bra-1.4.21.2.patch uploaded by fleed (license 463)
 Tested by: fleed


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@159317 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-25 22:45:59 +00:00
tilghman 41e940096a Merged revisions 159269 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r159269 | tilghman | 2008-11-25 15:56:48 -0600 (Tue, 25 Nov 2008) | 7 lines
  
  Don't try to send a response on a NULL pvt.
  (closes issue #13919)
   Reported by: barthpbx
   Patches: 
         chan_iax2.c.patch uploaded by eliel (license 64)
   Tested by: barthpbx
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@159276 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-25 21:57:59 +00:00
tilghman 3a6ac00947 Merged revisions 159246 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

................
  r159246 | tilghman | 2008-11-25 15:40:28 -0600 (Tue, 25 Nov 2008) | 14 lines
  
  Merged revisions 159245 via svnmerge from 
  https://origsvn.digium.com/svn/asterisk/branches/1.2
  
  ........
    r159245 | tilghman | 2008-11-25 15:37:06 -0600 (Tue, 25 Nov 2008) | 7 lines
    
    Regression fix for last security fix.  Set the iseqno correctly.
    (closes issue #13918)
     Reported by: ffloimair
     Patches: 
           20081119__bug13918.diff.txt uploaded by Corydon76 (license 14)
     Tested by: ffloimair
  ........
................


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@159247 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-25 21:42:42 +00:00
tilghman 5d1e952b32 Merged revisions 159025 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r159025 | tilghman | 2008-11-24 22:50:00 -0600 (Mon, 24 Nov 2008) | 3 lines
  
  System call ioperm is non-portable, so check for its existence in autoconf.
  (Closes issue #13863)
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@159050 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-25 05:02:11 +00:00
twilson 279d77a282 Make chan_usbradio compile under dev mode
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@158992 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-25 03:49:30 +00:00
seanbright 3ce5f8f4ee This is basically a complete rollback of r155401, as it was determined that
it would be best to maintain API compatibility.  Instead, this commit introduces
ao2_callback_data() which is functionally identical to ao2_callback() except
that it allows you to pass arbitrary data to the callback.

Reviewed by Mark Michelson via ReviewBoard:
	http://reviewboard.digium.com/r/64


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@158959 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-25 01:01:49 +00:00
seanbright f671568cb2 If you enabled 'notifycid' one of the limitations is that the calling channel
is only found if it dialed the extension that was subscribed to.  You can now
specify 'ignore-context' for the 'notifycid' option in sip.conf which will, as
it's value implies, ignore the current context of the caller when doing the
lookup.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@158756 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-23 03:36:52 +00:00
seanbright 8fd195cf55 No need to use a separate structure for this since we can just pass
our sip_pvt pointer in directly.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@158754 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-23 03:30:46 +00:00
mvanbaak e8ed625b27 dont send reorder tone after a device is hungup if a dialout is abandoned or failed.
Without this reorder tone will play after hangup and both wedhorn's and my wife have threatened to use an axe on our asterisk box

(closes issue #13948)
Reported by: wedhorn
Patches:
	switch.diff uploaded by wedhorn (license 30)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@158694 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-22 16:57:11 +00:00
mvanbaak 6cba30174e Add Media Source Update to skinny's control2str
(issue #13948)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@158690 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-22 16:48:09 +00:00
mvanbaak 8fbea88fa0 fix a very occasional core dump in chan_skinny found by wedhorn.
(issue #13948)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@158688 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-22 16:06:38 +00:00
mattf eb5e55e9c9 Fix for #13963. Make physical channel mapping unconfigured default
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@158482 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-21 21:06:59 +00:00