- removing transmit_reinvite_with_t38_sdp in favour of adding an argument to
transmit_reinvite_with_sdp
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@46385 f38db490-d61c-443f-a65b-d21fe96a405b
lock when needed - when we remove the dialog from the dialog list
If this doesn't lead to severe problems, it might help with some locking issues
in 1.4/1.2.
- Remove the term "interface" as a synonym for a SIP dialog. Sorry, Mark, but no
one understands it... ;-)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@46379 f38db490-d61c-443f-a65b-d21fe96a405b
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r46370 | russell | 2006-10-27 14:03:32 -0500 (Fri, 27 Oct 2006) | 4 lines
move the copy of the default settings to the global settings back out of
process_zap, so that they aren't overwritten when process_zap is called
multiple times
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@46371 f38db490-d61c-443f-a65b-d21fe96a405b
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r46358 | russell | 2006-10-27 10:32:40 -0500 (Fri, 27 Oct 2006) | 5 lines
Instead of iterating all of the options once to look for jitterbuffer options,
and then again for everything else, move the processing of jitterbuffer
options into the main loop so that there are no erroneous messages about
ignoring unknown options. (issue #8226)
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@46359 f38db490-d61c-443f-a65b-d21fe96a405b
https://origsvn.digium.com/svn/asterisk/branches/1.4
................
r46351 | crichter | 2006-10-27 11:49:20 +0200 (Fr, 27 Okt 2006) | 9 lines
Merged revisions 46176 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r46176 | crichter | 2006-10-25 10:41:59 +0200 (Mi, 25 Okt 2006) | 1 line
added nttimeout option to configure wether we disconnect calls on NT timeouts or not during an overlapdial session
........
................
r46352 | crichter | 2006-10-27 11:58:44 +0200 (Fr, 27 Okt 2006) | 1 line
fixed not compile issue, which was just introduced
................
r46353 | crichter | 2006-10-27 12:03:23 +0200 (Fr, 27 Okt 2006) | 9 lines
Merged revisions 46350 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r46350 | crichter | 2006-10-27 11:24:01 +0200 (Fr, 27 Okt 2006) | 1 line
fixed a bug which caused chan_misdn to try to allocate 2 times the same channel on high load, which then caused instability of mISDN. removed a useless function from isdn_lib.c
........
................
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@46354 f38db490-d61c-443f-a65b-d21fe96a405b
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r46082 | kpfleming | 2006-10-23 22:45:42 -0500 (Mon, 23 Oct 2006) | 2 lines
add an API call to allow channel drivers to determine which media formats are compatible (passthrough or transcode) with the format an existing channel is already using
........
r46083 | kpfleming | 2006-10-23 22:53:32 -0500 (Mon, 23 Oct 2006) | 2 lines
ensure that the translation matrix is properly lock-protected every place it is used
........
r46152 | kpfleming | 2006-10-24 18:45:19 -0500 (Tue, 24 Oct 2006) | 2 lines
if multiple translators are registered for the same source/dest combination, ensure that the lowest-cost one is always inserted earlier in the list
........
r46153 | kpfleming | 2006-10-24 19:10:54 -0500 (Tue, 24 Oct 2006) | 2 lines
code zone experiment: don't offer formats in the outbound INVITE that aren't either passthrough or translatable
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@46203 f38db490-d61c-443f-a65b-d21fe96a405b
https://origsvn.digium.com/svn/asterisk/branches/1.4
........
r46200 | kpfleming | 2006-10-25 09:32:08 -0500 (Wed, 25 Oct 2006) | 2 lines
apparently developers are still not aware that they should be use ast_copy_string instead of strncpy... fix up many more users, and fix some bugs in the process
........
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@46201 f38db490-d61c-443f-a65b-d21fe96a405b
when the number of channels fill the MTU on a given link.
In the future, this needs to be configurable per peer with trunking enabled.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@46195 f38db490-d61c-443f-a65b-d21fe96a405b
appreciated really. (Read the coding guidelines).
I've worked hard to make chan_sip a better place to code in, let's
keep it that way and don't add more stuff without comments.
Thank you.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@46183 f38db490-d61c-443f-a65b-d21fe96a405b
so fix the places where this might happen.
This is also a fix that ought to go into 1.4
[The difference between the two functions is a bit confusing,
and in asterisk i believe all string handling functions
should be able to handl a NULL string as argument,
but changing the API in trunk and not in 1.4 would make
backporting harder.]
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@46045 f38db490-d61c-443f-a65b-d21fe96a405b
As discussed on the mailing lists, 0 is a legal value
for Cseq, so there is no point to treat it specially.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@46035 f38db490-d61c-443f-a65b-d21fe96a405b
for NULL is certainly wrong and usually disables the
checks that we want to make instead.
This commit fixes a number of the above bugs where the result
of get_header() is immediately checked for NULL.
This is certainly a candidate for merging into 1.4
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@46026 f38db490-d61c-443f-a65b-d21fe96a405b
On passing, remove a wrong comment (that probably I wrote
myself!) and introduce a temporary variable to avoid a
misleading cast.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@46003 f38db490-d61c-443f-a65b-d21fe96a405b
simplifies its usage.
+ add another client for parse_uri, in handling Contact: strings
(on passing, document the content of the "fullcontact" field);
+ in register_verify(), mark with XXX what i believe is another
misinterpretation on the URI format when '@' is missing.
No code changed here, so no fixes applied.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@45977 f38db490-d61c-443f-a65b-d21fe96a405b
fix parse_uri() to interpret a missing userinfo
section as a domain-only URI, and comment a wrong
interpretation of the above in check_user_full().
The function has been patched to preserve the existing
behaviour (in what admittedly is a corner case, but
could be received under attacks).
Hopefully the From: based matching will go away soon!
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@45976 f38db490-d61c-443f-a65b-d21fe96a405b
before splitting around the @, otherwise the refer_to_domain
might contain arguments as well, causing failures.
I think this is a true bug that ought to be fixed in 1.4 as well.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@45966 f38db490-d61c-443f-a65b-d21fe96a405b
introducing the function parse_uri() that splits
a URI in its components.
Right now use it only in one place, because the custom
parsing that is done here and there sometimes has
bugs that i want to figure out first.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@45965 f38db490-d61c-443f-a65b-d21fe96a405b
apart from a small (but disabled by default) new option.
In detail:
+ introduce a new value for enum check_auth_result, AUTH_DONT_KNOW,
used (read below) when a function does not have a conclusive response.
Possibly this is the same as AUTH_NOT_FOUND, but need to check further.
+ move the large blocks (checking in the users list and in the peers
list, respectively) from check_user_full() to separate functions.
They return AUTH_DONT_KNOW in case they don't find a match, so
the caller know that it has to try the next method.
There is still some duplication of code here, but i
have not tried yet to remove it.
+ [new option] a new option in sip.conf, match_auth_username,
has been introduced, and disabled by default.
If set, and the incoming request carries authentication info,
the username to match in the users list is taken from there
rather than from the From: field.
This change is easy to identify, being made of
- one line to declare the variable match_auth_username
- a block of 15 lines in check_user_full()
- one line in sip list settings
- two lines for parsing the config file.
check_user_full() is now a lot cleaner - basically a sequence of
checks that are applied to the request. This will help future
work with new matching schemes.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@45945 f38db490-d61c-443f-a65b-d21fe96a405b
A large block needs reindentation now, but we don't do that because
it can be moved to a separate function.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@45905 f38db490-d61c-443f-a65b-d21fe96a405b
lock these data structures.
This improve readability, and also hides the underlying
locking mechanism so it is a lot easier to add diagnostic
code, or move the object locks somewhere else, etc.
On passing, rename the lock field in sip_pvt to pvt_lock,
also for ease of readability.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@45786 f38db490-d61c-443f-a65b-d21fe96a405b
oej