Archived
14
0
Fork 0
Commit graph

16800 commits

Author SHA1 Message Date
kpfleming
253ec3c141 correct small bug introduced during API conversion
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157743 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-19 13:45:48 +00:00
kpfleming
119d74be4a move relevant entries into UPGRADE.txt and resync UPGRADE-1.6.txt with previous branches
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157739 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-19 13:27:02 +00:00
kpfleming
7ad42d39db make some corrections to the ast_agi_register_multiple(), ast_agi_unregister_multiple() and ast_agi_fdprintf() API calls to be consistent with API guidelines
also, move UPGRADE.txt to UPGRADE-1.6.txt and make the new UPGRADE.txt contain information about upgrading between Asterisk 1.6 releases



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157706 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-19 12:42:19 +00:00
twilson
421ba24996 Comment out config line that is in a commented out context
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157675 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-19 05:37:10 +00:00
tilghman
6e814d6644 Starting with a change to ensure that ast_verbose() preserves ABI compatibility
in 1.6.1 (as compared to 1.6.0 and versions of 1.4), this change also
deprecates the use of Asterisk with FreeBSD 4, given the central use of va_copy
in core functions.  va_copy() is C99, anyway, and we already require C99 for
other purposes, so this isn't really a big change anyway.  This change also
simplifies some of the core ast_str_* functions.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157639 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-19 01:02:45 +00:00
mmichelson
88ec29a481 If malloc returns NULL, we need to return NULL immediately or
else Asterisk will crash when attempting to dereference the NULL
pointer

(closes issue #13858)
Reported by: eliel
Patches:
      astmm.c.patch uploaded by eliel (license 64)



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157632 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-19 00:59:48 +00:00
seanbright
d5dcd2feb8 Fix a few build problems on Solaris (and check for an md5 utility in
configure instead of the icky loop I was doing before).

(closes issue #13842)
Reported by: snuffy
Patches:
      bug13842_20081106.diff uploaded by snuffy (license 35)
      13842.diff uploaded by seanbright (license 71)
Tested by: snuffy


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157600 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-19 00:27:45 +00:00
mmichelson
7fe747fbe1 This change prevents a crash from occurring if res_musiconhold.so
is unloaded and then Asterisk is stopped. The problem was that
we are not unregistering the ast_moh_destroy function at exit.

(closes issue #13761)
Reported by: eliel
Patches:
      res_musiconhold.c.patch uploaded by eliel (license 64)



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157592 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-18 23:59:02 +00:00
mmichelson
1be8f9fe8f Add some missing $(DESTDIR)s to the bininstall
target of the Makefile.

(closes issue #13875)
Reported by: pabelanger
Patches:
      Makefile.155928 uploaded by pabelanger (license 224)



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157564 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-18 23:39:41 +00:00
mmichelson
c6f4f6c1e7 Fix the logic for when delete=yes when IMAP storage
is in use so that the message is deleted from both
local and IMAP storage.

(closes issue #13642)
Reported by: jaroth
Patches:
      deleteyes.patch uploaded by jaroth (license 50)




git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157562 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-18 23:28:23 +00:00
mmichelson
05b1fae086 Merged revisions 157503 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r157503 | mmichelson | 2008-11-18 16:47:57 -0600 (Tue, 18 Nov 2008) | 13 lines

Add some missing invite state changes necessary in the sip_write
function. Not setting the invite state correctly on the call was
resulting in the Record application leaving empty files. I also
have updated the doxygen comment next to the declaration of the
INV_EARLY_MEDIA constant to reflect that we also use this state
when we *send* a 18X response to an INVITE.

(closes issue #13878)
Reported by: nahuelgreco
Patches:
      sip-early-media-recording-1.4.22.patch uploaded by nahuelgreco (license 162)
	  Tested by: putnopvut

........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157512 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-18 22:54:08 +00:00
mmichelson
8c3fa3762b Based on Russell's advice on the asterisk-dev list, I have
changed from using a global lock in update_call_counter to
using the locks within the sip_pvt and sip_peer structures
instead.



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157496 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-18 21:59:24 +00:00
qwell
be51c79720 Remove echo line that is unnecessary (Thanks seanbright).
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157463 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-18 21:15:08 +00:00
qwell
9a229a7375 Make this executable
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157461 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-18 21:03:12 +00:00
qwell
fd973179a6 Add init script for ArchLinux
(closes issue #13667)
Reported by: sherif
Patches:
      archlinux_rc_makefile.patch uploaded by sherif (license 591)
      archlinux_rc_makefile-2.patch uploaded by mvanbaak (license 7)


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157460 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-18 21:01:46 +00:00
mmichelson
58b7f09f59 * Add a lock to be used in the update_call_counter function.
* Revert logic to mirror 1.4's in the sense that it will not allow
  the call counter to dip below 0.

These two measures prevent potential races that could cause a SIP peer
to appear to be busy forever.

(closes issue #13668)
Reported by: mjc
Patches:
      hintfix_trunk_rev152649.patch uploaded by wolfelectronic (license 586)



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157427 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-18 20:23:58 +00:00
jpeeler
da605bfc3c Merged revisions 157365 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r157365 | jpeeler | 2008-11-18 13:13:33 -0600 (Tue, 18 Nov 2008) | 6 lines

(closes issue #13899)
Reported by: akkornel

This fix is the result of a bug fix in ast_app_separate_args r124395. If an argument does not exist it should always be set to a null string rather than a null pointer.


........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157366 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-18 19:16:00 +00:00
mmichelson
135ce47598 Merged revisions 157305 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r157305 | mmichelson | 2008-11-18 12:25:55 -0600 (Tue, 18 Nov 2008) | 12 lines

Fix a crash in the end_bridge_callback of app_dial and
app_followme which would occur at the end of an attended
transfer. The error occurred because we initially stored
a pointer to an ast_channel which then was hung up due
to a masquerade.

This commit adds a "fixup" callback to the bridge_config
structure to allow for end_bridge_callback_data to be
changed in the case that a new channel pointer is needed
for the end_bridge_callback.


........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157306 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-18 18:31:08 +00:00
murf
fe4ad3a4a2 (closes issue #13420)
Reported by: alex70
Patches:
      13420.13539.patch uploaded by murf (license 17)
Tested by: murf, awk

This fixes two problems: a spurious linefeed insertion
probably left over from pre-precomment times. Only
generated when category had no previous comments.

The other problem: Insertions could get the line-numbering
out of whack and generate negative line numbers, causing 
chunks of line numbers to be emitted, on the scale of the
number of lines up to that point in the file. In such cases,
abort the looping, and all is well.




git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157302 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-18 18:07:55 +00:00
tilghman
af90ed7cfd Can't use items duplicated off the stack frame in an element returned from
a function: in these cases, we have to use the heap, or garbage will result.
(closes issue #13898)
 Reported by: alecdavis
 Patches: 
       20081114__bug13898__2.diff.txt uploaded by Corydon76 (license 14)
 Tested by: alecdavis


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157253 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-17 22:25:06 +00:00
kpfleming
bf74907f91 ensure that if a .i file (preprocessed source) is present, the .o file is made from it, not from the .c file (this only works because GNU makes respects the order the rules are defined)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157167 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-15 19:51:29 +00:00
kpfleming
296092ed22 Merged revisions 157162-157163 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r157162 | kpfleming | 2008-11-15 20:24:24 +0100 (Sat, 15 Nov 2008) | 1 line
  
  dist-clean should remove dependency information files as well
........
  r157163 | kpfleming | 2008-11-15 20:31:03 +0100 (Sat, 15 Nov 2008) | 1 line
  
  when an individual directory dist-clean is run, run clean in that directory first, and when running top-level dist-clean, do not run subdirectory clean operations twice
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157164 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-15 19:45:19 +00:00
kpfleming
866999e745 Merged revisions 157104 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r157104 | kpfleming | 2008-11-15 19:00:32 +0100 (Sat, 15 Nov 2008) | 13 lines
  
  major update to doxygen configuration file:
  
  1) update to doxygen 1.5.x style file, as used in trunk
  
  2) tell doxygen where are header files are, so include-file processing can be done
  
  3) make all macros that are used to define variables/functions be expanded, so that doxygen will properly document the resulting variable/function
  
  4) make all macros that are used to provide the contents of a variable (structure) be expanded, so that doxygen will be able to document the resulting fields
  
  5) suppress compiler attributes (__attribute__(xxx)) from being seen by doxygen, so it will properly match up function definition and usage (for an example of th effect of this, look at the doxygen docs for ast_log() from before and afte this commit)
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157105 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-15 18:25:01 +00:00
eliel
b17c75817d Avoid a not needed cast, making code more readable.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157073 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-15 15:37:11 +00:00
russell
7927af69d9 Fix a few more places where the case insensitive hash should be used since
the comparison is case insensitive.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157041 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-15 04:25:57 +00:00
russell
ccf9135534 Use the new case insensitive hash function for console interfaces. The comparison
function is case insensitive.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157039 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-15 04:08:42 +00:00
tilghman
50a02870ae Allow setting static values in CDRs
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@157006 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-14 22:36:30 +00:00
mmichelson
1cb5c3372d Revision 155513 of chan_sip.c in trunk inadvertently
removed a very important line to set the "len" field
for incoming SIP requests. The result was that all incoming
SIP messages appeared to be 0-length, meaning Asterisk
could do no meaningful processing of anything SIP-related



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156962 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-14 21:19:58 +00:00
twilson
ec2602aeb3 Cleanup whitespace issues
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156918 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-14 17:35:33 +00:00
twilson
3eb1d5a741 Use Mark's new ast_str_case_hash function instead of jumping through hoops to do insensitive case lookups
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156916 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-14 17:29:05 +00:00
tilghman
5f8bb934f4 Ping is missing the standard double-newline after the event.
(closes issue #13903)
 Reported by: kebl0155


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156911 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-14 17:02:00 +00:00
mmichelson
8bbcf78384 Fix some refcounting in app_queue.c and change the
hashing used by app_queue.c to be case-insensitive.
This is accomplished by adding a new case-insensitive
hashing function.

This was necessary to prevent bad refcount errors
(and potential crashes) which would occur due to the
fact that queues were initially read from the config
file in a case-sensitive manner. Then, when a user
issued a CLI command or manager action, we allowed
for case-insensitive input and used that input to 
directly try to find the queue in the hash table. The result
was either that we could not find a queue that was input or
worse, we would end up hashing to a completely bogus value
based on the input.

This commit resolves the problem presented in
issue #13703. However, that issue was reported against
1.6.0. Since this fix introduces a behavior change, I am
electing to not place this same fix in to the 1.6.0 or 1.6.1
branches, and instead will opt for a change which does not
change behavior.



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156883 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-14 16:53:38 +00:00
mattf
7e9cdbaadb Remove some useless locking and make sure we hangup channels on a link when we get a GRS.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156874 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-14 16:34:33 +00:00
mmichelson
f32a129a9c Merged revisions 156816 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r156816 | mmichelson | 2008-11-14 09:18:59 -0600 (Fri, 14 Nov 2008) | 10 lines

If the prompt to reenter a voicemail password timed out, it
resulted in the password not being saved, even if the input matched
what you gave when first prompted to enter a new password. This is
because the return value of ast_readstring was checked, but not checked
properly.

This bug was discovered by Jared Smith during an Asterisk training course.
Thanks for reporting it!


........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156817 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-14 15:20:03 +00:00
tilghman
e37ac19848 Merged revisions 156755 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r156755 | tilghman | 2008-11-13 18:41:37 -0600 (Thu, 13 Nov 2008) | 6 lines
  
  ast_waitfordigit() requires that the channel be up, for no good logical
  reason.  This prevents While/EndWhile from working within the "h"
  extension.
  Reported by: jgalarneau (for ABE C.2)
  Fixed by: me
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156756 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-14 00:43:13 +00:00
tilghman
ca96e392ca Merged revisions 156688 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r156688 | tilghman | 2008-11-13 15:24:00 -0600 (Thu, 13 Nov 2008) | 7 lines
  
  Provide more space for all the data which can appear in an originating
  channel name.
  (closes issue #13398)
   Reported by: bamby
   Patches: 
         manager.c.diff uploaded by bamby (license 430)
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156690 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-13 21:30:41 +00:00
jpeeler
62c00648f0 (closes issue #13891)
Reported by: smurfix

This reverts a change I made in 116297. At the time it seemed the change was required to solve an issue with attempting a transfer but then letting it timeout without dialing any digits. However, I didn't realize that having an empty extension was possible. I'm removing the immediate return that was added in pbx_find_extension if the extension is null.



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156649 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-13 19:17:50 +00:00
tilghman
c35b7f560f Command offsets were not changed correctly when the command syntax for
'pri set debug' was changed from 'pri debug'.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156647 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-13 19:10:28 +00:00
mmichelson
9a53e8d9e9 Kevin sent a note indicating that this change is
not necessary, so I am reverting it



git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156612 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-13 17:07:56 +00:00
eliel
20313cb12e Introduce XML documentation for:
- MeetMe()
  - MeetMeCount()
  - MeetMeChannelAdmin()
  - MeetMeAdmin()
  - SLAStation()
  - SLATrunk()

- Add an attribute to optionlist 'hasparams' with the same functionality as the one
we have in <parameter> and <argument> (the DTD was updated)
- Fix a leak when getting an attribute while parsing an <optionlist>.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156575 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-13 15:46:06 +00:00
eliel
b8b9781f95 Fix a typo introduced when changing xmldoc_has_arguments() to xmldoc_has_inside()
we need to pass the name of the node that we are looking for.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156541 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-13 13:53:13 +00:00
eliel
28bb0c48be Remove trailing whitespaces
using ':%s/\s\+$//' pointed by seanbright on #asterisk-dev


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156535 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-13 13:08:34 +00:00
seanbright
f754a12b5a Use the reviewboard:url SVN property so post-review will work without modification.
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156443 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-12 23:13:42 +00:00
tilghman
30ddebb09d Merged revisions 156386 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r156386 | tilghman | 2008-11-12 15:18:57 -0600 (Wed, 12 Nov 2008) | 5 lines
  
  When using call limits under 1 second, infinite call lengths are allowed,
  instead.
  (closes issue #13851)
   Reported by: ruddy
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156388 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-12 21:34:51 +00:00
eliel
7daa8c57ab - Make alias->real_cmd point to the allocated space outside alias->alias.
- Register the aliased cli command (or we will not alias anything).
- Use ARRAY_LEN() when possible.


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156355 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-12 20:27:40 +00:00
murf
c2775595e6 Merged revisions 156297 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r156297 | murf | 2008-11-12 12:36:16 -0700 (Wed, 12 Nov 2008) | 18 lines

It turns out that the 0x0XX00 codes being returned for
N, X, and Z are off by one, as per conversation with
jsmith on #asterisk-dev;  he was teaching a class
and disconcerted that this published rule was not
being followed, with patterns _NXX, _[1-8]22 and
_[2-9]22... and NXX was winning, but [1-8] should
have been. 

This change, tested on these 3 patterns now 
picks the proper one.

However, this change may surprise users who
set up dialplans based on previous behavior,
which has been there for what, 2 and half 
years or so now.



........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156299 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-12 19:47:29 +00:00
russell
d65a1375b1 Fix a bug caused by using sizeof(pointer) instead of sizeof(the struct)
git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156298 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-12 19:38:51 +00:00
tilghman
e7bb3059ca Merged revisions 156294 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r156294 | tilghman | 2008-11-12 13:26:45 -0600 (Wed, 12 Nov 2008) | 6 lines
  
  If the SLA thread is not started, then reload causes a memory leak.
  (closes issue #13889)
   Reported by: eliel
   Patches: 
         app_meetme.c.patch uploaded by eliel (license 64)
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156295 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-12 19:28:22 +00:00
jpeeler
b22f3e95b1 Merged revisions 156289 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r156289 | jpeeler | 2008-11-12 13:10:12 -0600 (Wed, 12 Nov 2008) | 3 lines

For whatever reason, gcc only warned me about the possible use of an uninitialized variable when compiling 1.6.1. 


........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156290 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-12 19:11:15 +00:00
tilghman
79a53174fa Merged revisions 156229 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
  r156229 | tilghman | 2008-11-12 12:39:21 -0600 (Wed, 12 Nov 2008) | 11 lines
  
  Revert revision 132506, since it occasionally caused IAX2 HANGUP packets not
  to be sent, and instead, schedule a task to destroy the iax2 pvt structure
  10 seconds later.  This allows the IAX2 HANGUP packet to be queued,
  transmitted, and ACKed before the pvt is destroyed.
  (closes issue #13645)
   Reported by: dzajro
   Patches: 
         20081111__bug13645__3.diff.txt uploaded by Corydon76 (license 14)
   Tested by: vazir
   Reviewed: http://reviewboard.digium.com/r/51/
........


git-svn-id: http://svn.digium.com/svn/asterisk/trunk@156243 f38db490-d61c-443f-a65b-d21fe96a405b
2008-11-12 18:55:18 +00:00